DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Pallantla Poornima <pallantlax.poornima@intel.com>
Cc: dev@dpdk.org, Aaron Conole <aconole@redhat.com>,
	reshma.pattan@intel.com, ferruh.yigit@intel.com,
	bruce.richardson@intel.com, stephen@networkplumber.org,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix sprintf with strlcat
Date: Tue, 02 Apr 2019 02:37:50 +0200	[thread overview]
Message-ID: <11514522.tD9ysAbmMG@xps> (raw)
Message-ID: <20190402003750.EuFTHKhBnogAJGEeLoxIhkP7fDZFkFQPCQm5d-9jDs8@z> (raw)
In-Reply-To: <f7t5zsmrify.fsf@dhcp-25.97.bos.redhat.com>

13/03/2019 14:51, Aaron Conole:
> Pallantla Poornima <pallantlax.poornima@intel.com> writes:
> 
> > sprintf function is not secure as it doesn't check the length of string.
> > More secure function strlcat is used.
> >
> > Fixes: 727909c592 ("app/test: introduce dynamic commands list")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> > ---
> > v2: Used strlcat to avoid buffer overflow.
> > ---
> 
> LGTM.
> 
> Reviewed-by: Aaron Conole <aconole@redhat.com>

Applied, thanks



  reply	other threads:[~2019-04-02  0:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 11:07 Pallantla Poornima
2019-03-13 13:51 ` Aaron Conole
2019-04-02  0:37   ` Thomas Monjalon [this message]
2019-04-02  0:37     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11514522.tD9ysAbmMG@xps \
    --to=thomas@monjalon.net \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=pallantlax.poornima@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).