Re: [dpdk-dev] [PATCH v7 7/8] doc: add documentation for windows

[Pallavi Kadam <pallavi.kadam@intel.com>]

On 4/1/2019 4:22 PM, Thomas Monjalon wrote:
> 29/03/2019 00:24, Anand Rawat:
>> Added documentation to build helloworld example
>> on windows using meson and clang. Updated the
>> maintainers list to include windows maintainers.
> [...]
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> +Windows support
>> +M: Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>
>> +M: Omar Cardona <ocardona@microsoft.com>
>> +M: Anand Rawat <anand.rawat@intel.com>
>> +M: Ranjit Menon <ranjit.menon@intel.com>
>> +F: lib/librte_eal/windows/
> This change should be in the first patch (when introducing eal/windows).
> In this doc patch, you should add
> 	F: doc/guides/windows_gsg/
Ok, will be done in the coming patch v8.
>
> [...]
>> +The DPDK and its applications require the Clang-LLVM* C compiler and MSVC* linker.
>> +The Meson* Build system is used to prepare the sources for compilation with the Ninja backend.
>> +
>> +\*Other names and brands may be claimed as the property of others.
> This sentence looks weird. What does it mean?

Thought of adding asterisk in front of names and brands

those are claimed from other websites/ organizations

for instance, MSFT, LLVM.

Can be removed, if not required.

>
> [...]
>> +Download and install the clang compiler from `LLVM* website <http://releases.llvm.org/download.html>`_.
> Why is there an asterisk after LLVM?

As the link has been copied from LLVM website (other property).

Can be removed, if not required.

>
> [...]
>> +Download and install the Build Tools for Visual Studio to link and build the files on windows, from `Microsoft* website <https://visualstudio.microsoft.com/downloads>`_.
>> +When installing build tools, select the "Visual C++ build tools" option and ensure the Windows SDK is selected.
> Please try to limit the line length.
> We are supposed to not exceed 80-chars if possible.
> The best is to wrap lines logically (as in code)
> after a comma or a point, etc.

Will limit the line length in v8.

>
> [...]
>> +    cd C:\Users\me\dpdk\build
>> +    helloworld.exe
>> +    hello from core 1
>> +    hello from core 3
>> +    hello from core 0
>> +    hello from core 2
> That's definitely a good goal for release 19.05!
>
>> +Limitations
>> +===========
>> +
>> +DPDK for Windows is currently a work in progress. Not all DPDK source files
>> +compile. Support is being added in pieces so as to limit the overall scope
>> +of any individual patch series. The goal is to be able to run any DPDK
>> +application natively on Windows.
> Yes
>
>