From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7FCA1A0679 for <public@inbox.dpdk.org>; Tue, 2 Apr 2019 03:01:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C32F4D27; Tue, 2 Apr 2019 03:01:39 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D1AD94CA7 for <dev@dpdk.org>; Tue, 2 Apr 2019 03:01:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 18:01:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,298,1549958400"; d="scan'208";a="332829498" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 01 Apr 2019 18:01:36 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 1 Apr 2019 18:01:36 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 1 Apr 2019 18:01:36 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.92]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 09:01:34 +0800 From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com> CC: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "O'Hare, Cathal" <cathal.ohare@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com> Thread-Topic: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE Thread-Index: AQHU45rWNyYnVP7X2UeEqhPkDd0APqYdJUmAgAhA0YCAAV/eAIAACg6AgAAdMoCAAACngIABKKHg Date: Tue, 2 Apr 2019 01:01:33 +0000 Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC0909407F954A@shsmsx102.ccr.corp.intel.com> References: <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com> <2606731.xEWlXSy69y@xps> <e32d75b3-b743-8a87-0e36-862aa1fce6d5@intel.com> <2282021.H7KxSoY9xU@xps> In-Reply-To: <2282021.H7KxSoY9xU@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190402010133.JvFzqG2ui7YazuuFY_2WUNpn63IaEFyQhNgKUYr1BZs@z> Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, April 1, 2019 11:14 PM > To: Yigit, Ferruh <ferruh.yigit@intel.com> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi Z > <qi.z.zhang@intel.com>; dev@dpdk.org; O'Hare, Cathal > <cathal.ohare@intel.com>; Mcnamara, John <john.mcnamara@intel.com> > Subject: Re: [dpdk-dev] [PATCH v7 0/8] Support vector instructions on ICE >=20 > 01/04/2019 17:12, Ferruh Yigit: > > On 4/1/2019 2:27 PM, Thomas Monjalon wrote: > > > 01/04/2019 14:51, Ferruh Yigit: > > >> On 3/31/2019 4:52 PM, Thomas Monjalon wrote: > > >>> 26/03/2019 10:50, Ferruh Yigit: > > >>>>> Wenzhuo Lu (8): > > >>>>> net/ice: fix Tx function setting > > >>>>> net/ice: add pointer for queue buffer release > > >>>>> net/ice: support vector SSE in RX > > >>>>> net/ice: support Rx scatter SSE vector > > >>>>> net/ice: support Tx SSE vector > > >>>>> net/ice: support Rx AVX2 vector > > >>>>> net/ice: support Rx scatter AVX2 vector > > >>>>> net/ice: support vector AVX2 in TX > > >>>> > > >>>> This version (v7) pulled from next-net-intel to next-net. > > >>> > > >>> I assume these patches have been tested, or at least compiled. > > >>> However, when running devtools/test-meson-builds.sh, there is a > > >>> compilation error for build-x86-default: > > >>> > > >>> In file included from ../drivers/net/ice/ice_ethdev.h:10: > > >>> rte_ethdev_pci.h:38:10: fatal error: 'rte_pci.h' file not found > > >> > > >> I tested this with meson but not able to catch the issue. Perhaps > > >> for my case dependencies were build fast enough to cause a problem. > > > > > > No, it's not a matter of speed. > > > > No it is not, > > > > > Are you running devtools/test-meson-builds.sh ? > > > > No, I am using with another script but not building 'default' > > architecture with meson where problem happens, that is why not able to > > catch this. Will try to catch next time.. >=20 > Ferruh, why not using the scripts we are building in devtools? I have a suggestion. Why not integrating all the compile check here, like h= ttp://mails.dpdk.org/archives/test-report/2019-March/077966.html. If it fa= ils, the patch state should be changed to "compile error". It will not be a= ccepted. It can help everyone, especially the committer. We cannot assume everyone knows everything. To me, have to say not familiar= with meson build.