From: Shahaf Shuler <shahafs@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v4 09/13] net/mlx5: switch to the shared IB device context
Date: Tue, 2 Apr 2019 04:49:57 +0000 [thread overview]
Message-ID: <AM0PR0502MB37952C85D974BC40F17FE8A6C3560@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190402044957.IYq8_XBFn1hmvLnWu4JrTTf_WXYHHnxCXt79xWZ246k@z> (raw)
In-Reply-To: <1553692547-16695-10-git-send-email-viacheslavo@mellanox.com>
Slava,
Wednesday, March 27, 2019 3:16 PM, Viacheslav Ovsiienko:
> Subject: [PATCH v4 09/13] net/mlx5: switch to the shared IB device context
>
> The code is updated to use the shared IB device context and device handles.
> The IB device context is shared between reprentors created over the single
> multiport IB device. All Verbs and DevX objects will be created whithin this
> shared context.
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 3 +--
> drivers/net/mlx5/mlx5.h | 1 -
> drivers/net/mlx5/mlx5_ethdev.c | 13 +++++++------
> drivers/net/mlx5/mlx5_flow_dv.c | 8 ++++----
> drivers/net/mlx5/mlx5_flow_verbs.c | 6 ++++--
> drivers/net/mlx5/mlx5_rxq.c | 23 ++++++++++++-----------
> drivers/net/mlx5/mlx5_socket.c | 4 ++--
> drivers/net/mlx5/mlx5_trigger.c | 2 +-
> drivers/net/mlx5/mlx5_txq.c | 4 ++--
> 9 files changed, 33 insertions(+), 31 deletions(-)
>
>
> a/drivers/net/mlx5/mlx5_flow_verbs.c
> b/drivers/net/mlx5/mlx5_flow_verbs.c
> index 6c4f52f..9548d12 100644
> --- a/drivers/net/mlx5/mlx5_flow_verbs.c
> +++ b/drivers/net/mlx5/mlx5_flow_verbs.c
> @@ -56,10 +56,11 @@
> {
> #if defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42)
> struct mlx5_priv *priv = dev->data->dev_private;
> + struct ibv_context ctx = priv->sh->ctx;
> struct ibv_counter_set_init_attr init = {
> .counter_set_id = counter->id};
>
> - counter->cs = mlx5_glue->create_counter_set(priv->ctx, &init);
> + counter->cs = mlx5_glue->create_counter_set(ctx, &init);
> if (!counter->cs) {
> rte_errno = ENOTSUP;
> return -ENOTSUP;
This code piece was causing compilation error w/ older rdma-core versions.
It was replaced w/ the below during the merge.
> #if defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42)
> struct mlx5_priv *priv = dev->data->dev_private;
> - struct ibv_context ctx = priv->sh->ctx;
> + struct ibv_context *ctx = priv->sh->ctx;
> struct ibv_counter_set_init_attr init = {
> .counter_set_id = counter->id};
>
next prev parent reply other threads:[~2019-04-02 4:50 UTC|newest]
Thread overview: 217+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 18:02 [dpdk-dev] [RFC 00/10] net/mlx5: add support for multiport IB devices Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 01/10] net/mlx5: add multiport IB device port structure Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 02/10] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 03/10] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-02-28 18:02 ` [dpdk-dev] [RFC 04/10] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 05/10] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 06/10] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 07/10] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 08/10] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 09/10] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-02-28 18:03 ` [dpdk-dev] [RFC 10/10] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 00/14] net/mlx5: add support for multiport IB devices Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 01/14] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:13 ` Shahaf Shuler
2019-03-21 12:13 ` Shahaf Shuler
2019-03-21 15:08 ` Stephen Hemminger
2019-03-21 15:08 ` Stephen Hemminger
2019-03-21 15:31 ` Slava Ovsiienko
2019-03-21 15:31 ` Slava Ovsiienko
2019-03-21 19:08 ` Stephen Hemminger
2019-03-21 19:08 ` Stephen Hemminger
2019-03-22 8:15 ` Slava Ovsiienko
2019-03-22 8:15 ` Slava Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 02/14] net/mlx5: introduce multiport IB device shared structure Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 03/14] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 04/14] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 05/14] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:54 ` Slava Ovsiienko
2019-03-21 12:54 ` Slava Ovsiienko
2019-03-21 12:57 ` Slava Ovsiienko
2019-03-21 12:57 ` Slava Ovsiienko
2019-03-24 9:00 ` Shahaf Shuler
2019-03-24 9:00 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 06/14] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 07/14] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 08/14] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 09/14] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 10/14] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 12:14 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 11/14] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 12/14] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 14:01 ` Slava Ovsiienko
2019-03-21 14:01 ` Slava Ovsiienko
2019-03-24 9:07 ` Shahaf Shuler
2019-03-24 9:07 ` Shahaf Shuler
2019-03-21 8:11 ` [dpdk-dev] [PATCH 13/14] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 14:08 ` Slava Ovsiienko
2019-03-21 14:08 ` Slava Ovsiienko
2019-03-21 8:11 ` [dpdk-dev] [PATCH 14/14] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-21 8:11 ` Viacheslav Ovsiienko
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 12:15 ` Shahaf Shuler
2019-03-21 14:11 ` Slava Ovsiienko
2019-03-21 14:11 ` Slava Ovsiienko
2019-03-24 9:13 ` Shahaf Shuler
2019-03-24 9:13 ` Shahaf Shuler
2019-03-25 7:44 ` Slava Ovsiienko
2019-03-25 7:44 ` Slava Ovsiienko
2019-03-21 12:13 ` [dpdk-dev] [PATCH 00/14] net/mlx5: add support for multiport IB devices Shahaf Shuler
2019-03-21 12:13 ` Shahaf Shuler
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-21 12:58 ` Slava Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 01/13] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 18:06 ` Stephen Hemminger
2019-03-25 18:06 ` Stephen Hemminger
2019-03-25 18:07 ` Stephen Hemminger
2019-03-25 18:07 ` Stephen Hemminger
2019-03-26 7:33 ` Slava Ovsiienko
2019-03-26 7:33 ` Slava Ovsiienko
2019-03-26 12:20 ` Shahaf Shuler
2019-03-26 12:20 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 02/13] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 11:47 ` Shahaf Shuler
2019-03-26 11:47 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 03/13] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 04/13] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:02 ` Shahaf Shuler
2019-03-26 12:02 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 05/13] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:10 ` Shahaf Shuler
2019-03-26 12:10 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 06/13] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 07/13] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 08/13] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 09/13] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 10/13] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 11/13] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:14 ` Shahaf Shuler
2019-03-26 12:14 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 12/13] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:16 ` Shahaf Shuler
2019-03-26 12:16 ` Shahaf Shuler
2019-03-25 17:03 ` [dpdk-dev] [PATCH v2 13/13] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-25 17:03 ` Viacheslav Ovsiienko
2019-03-26 12:21 ` Shahaf Shuler
2019-03-26 12:21 ` Shahaf Shuler
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 01/13] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 19:37 ` Shahaf Shuler
2019-03-26 19:37 ` Shahaf Shuler
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 02/13] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 03/13] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 04/13] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 05/13] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 19:35 ` Shahaf Shuler
2019-03-26 19:35 ` Shahaf Shuler
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 06/13] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 07/13] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 08/13] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 09/13] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 10/13] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 11/13] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 12/13] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 15:35 ` [dpdk-dev] [PATCH v3 13/13] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-26 15:35 ` Viacheslav Ovsiienko
2019-03-26 19:38 ` Shahaf Shuler
2019-03-26 19:38 ` Shahaf Shuler
2019-03-27 6:00 ` [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices Shahaf Shuler
2019-03-27 6:00 ` Shahaf Shuler
2019-03-27 7:31 ` Slava Ovsiienko
2019-03-27 7:31 ` Slava Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 " Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 01/13] net/mlx5: add representor recognition on kernels 5.x Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 02/13] net/mlx5: modify get ifindex routine for multiport IB Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 03/13] net/mlx5: add getting IB ports number " Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 04/13] net/mlx5: add multiport IB device support to probing Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 05/13] net/mlx5: add IB shared context alloc/free functions Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 06/13] net/mlx5: switch to the names in the shared IB context Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 07/13] net/mlx5: switch to the shared Protection Domain Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 08/13] net/mlx5: switch to the shared context IB attributes Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 09/13] net/mlx5: switch to the shared IB device context Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-04-02 4:49 ` Shahaf Shuler [this message]
2019-04-02 4:49 ` Shahaf Shuler
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 10/13] net/mlx5: provide IB port for the object being created Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 11/13] net/mlx5: update install/uninstall int handler routines Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 12/13] net/mlx5: update event handler for multiport IB devices Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-27 13:15 ` [dpdk-dev] [PATCH v4 13/13] net/mlx5: add source vport match to the ingress rules Viacheslav Ovsiienko
2019-03-27 13:15 ` Viacheslav Ovsiienko
2019-03-28 9:21 ` [dpdk-dev] [PATCH v4 00/14] net/mlx5: add support for multiport IB devices Shahaf Shuler
2019-03-28 9:21 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB37952C85D974BC40F17FE8A6C3560@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).