From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 3BDC2A0679
	for <public@inbox.dpdk.org>; Tue,  2 Apr 2019 10:49:04 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 883CA343C;
	Tue,  2 Apr 2019 10:49:03 +0200 (CEST)
Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com
 [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id 34FEF316B
 for <dev@dpdk.org>; Tue,  2 Apr 2019 10:49:02 +0200 (CEST)
Received: from core.dev.6wind.com (unknown [10.0.0.1])
 by proxy.6wind.com (Postfix) with ESMTPS id 1E3E828F644;
 Tue,  2 Apr 2019 10:49:02 +0200 (CEST)
Received: from [10.16.0.195] (helo=6wind.com)
 by core.dev.6wind.com with smtp (Exim 4.84_2)
 (envelope-from <olivier.matz@6wind.com>)
 id 1hBF6L-00010i-0d; Tue, 02 Apr 2019 10:49:02 +0200
Received: by 6wind.com (sSMTP sendmail emulation);
 Tue, 02 Apr 2019 10:49:01 +0200
Date: Tue, 2 Apr 2019 10:49:00 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org, akhil.goyal@nxp.com
Message-ID: <20190402084900.auhnhbmy7vqjuu52@glumotte.dev.6wind.com>
References: <20190401125656.7636-1-konstantin.ananyev@intel.com>
 <20190402083444.24755-1-konstantin.ananyev@intel.com>
 <20190402083444.24755-2-konstantin.ananyev@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Disposition: inline
In-Reply-To: <20190402083444.24755-2-konstantin.ananyev@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH v6 1/9] mbuf: new function to generate raw Tx
 offload value
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190402084900._4F8QRpy6sppN0f5U5u1PyuA5mMQhtuoJjhiOUxbrrw@z>

On Tue, Apr 02, 2019 at 09:34:36AM +0100, Konstantin Ananyev wrote:
> Operations to set/update bit-fields often cause compilers
> to generate suboptimal code.
> To help avoid such situation for tx_offload fields:
> introduce new enum for tx_offload bit-fields lengths and offsets,
> and new function to generate raw tx_offload value.
> Add new test-case into UT for introduced function.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks