From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"alialnu@mellanox.com" <alialnu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Subject: [dpdk-dev] [PATCH v6 2/4] app/testpmd: use bulk ops for allocating segments
Date: Tue, 2 Apr 2019 09:53:29 +0000 [thread overview]
Message-ID: <20190402095255.848-2-pbhagavatula@marvell.com> (raw)
Message-ID: <20190402095329.5c0AP7HJAvb_do2LtxjLivqYxRGOnSJPgY29YxHkF8U@z> (raw)
In-Reply-To: <20190402095255.848-1-pbhagavatula@marvell.com>
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Use bulk ops for allocating segments instead of having a inner loop
for every segment.
This reduces the number of calls to the mempool layer.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
app/test-pmd/txonly.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
index 0d411dbf4..65171c1d1 100644
--- a/app/test-pmd/txonly.c
+++ b/app/test-pmd/txonly.c
@@ -155,6 +155,7 @@ static void
pkt_burst_transmit(struct fwd_stream *fs)
{
struct rte_mbuf *pkts_burst[MAX_PKT_BURST];
+ struct rte_mbuf *pkt_segs[RTE_MAX_SEGS_PER_PKT];
struct rte_port *txp;
struct rte_mbuf *pkt;
struct rte_mbuf *pkt_seg;
@@ -216,18 +217,23 @@ pkt_burst_transmit(struct fwd_stream *fs)
rte_pktmbuf_reset_headroom(pkt);
pkt->data_len = tx_pkt_seg_lengths[0];
pkt_seg = pkt;
+
if (tx_pkt_split == TX_PKT_SPLIT_RND)
nb_segs = random() % tx_pkt_nb_segs + 1;
else
nb_segs = tx_pkt_nb_segs;
- pkt_len = pkt->data_len;
- for (i = 1; i < nb_segs; i++) {
- pkt_seg->next = rte_mbuf_raw_alloc(mbp);
- if (pkt_seg->next == NULL) {
- pkt->nb_segs = i;
+
+ if (nb_segs > 1) {
+ if (rte_mempool_get_bulk(mbp, (void **)pkt_segs,
+ nb_segs)) {
rte_pktmbuf_free(pkt);
goto nomore_mbuf;
}
+ }
+
+ pkt_len = pkt->data_len;
+ for (i = 1; i < nb_segs; i++) {
+ pkt_seg->next = pkt_segs[i - 1];
pkt_seg = pkt_seg->next;
pkt_seg->data_len = tx_pkt_seg_lengths[i];
pkt_len += pkt_seg->data_len;
--
2.21.0
next prev parent reply other threads:[~2019-04-02 9:53 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 19:42 [dpdk-dev] [PATCH] app/testpmd: use mempool bulk get for txonly mode Pavan Nikhilesh Bhagavatula
2019-03-01 7:38 ` Andrew Rybchenko
2019-03-01 8:45 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-03-01 13:47 ` [dpdk-dev] [PATCH v2] app/testpmd: add " Pavan Nikhilesh Bhagavatula
2019-03-19 16:48 ` Ferruh Yigit
2019-03-19 16:48 ` Ferruh Yigit
2019-03-20 4:53 ` Pavan Nikhilesh Bhagavatula
2019-03-20 4:53 ` Pavan Nikhilesh Bhagavatula
2019-03-26 8:43 ` Ferruh Yigit
2019-03-26 8:43 ` Ferruh Yigit
2019-03-26 11:00 ` Thomas Monjalon
2019-03-26 11:00 ` Thomas Monjalon
2019-03-26 11:50 ` Iremonger, Bernard
2019-03-26 11:50 ` Iremonger, Bernard
2019-03-26 12:06 ` Pavan Nikhilesh Bhagavatula
2019-03-26 12:06 ` Pavan Nikhilesh Bhagavatula
2019-03-26 13:16 ` Jerin Jacob Kollanukkaran
2019-03-26 13:16 ` Jerin Jacob Kollanukkaran
2019-03-26 12:26 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: optimize testpmd " Pavan Nikhilesh Bhagavatula
2019-03-26 12:26 ` Pavan Nikhilesh Bhagavatula
2019-03-26 12:27 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add mempool bulk get for " Pavan Nikhilesh Bhagavatula
2019-03-26 12:27 ` Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: optimize testpmd " Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add mempool bulk get for " Pavan Nikhilesh Bhagavatula
2019-03-26 13:03 ` Pavan Nikhilesh Bhagavatula
2019-03-26 16:13 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: optimize testpmd " Iremonger, Bernard
2019-03-26 16:13 ` Iremonger, Bernard
2019-03-31 13:14 ` [dpdk-dev] [PATCH v5 " Pavan Nikhilesh Bhagavatula
2019-03-31 13:14 ` Pavan Nikhilesh Bhagavatula
2019-03-31 13:14 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add mempool bulk get for " Pavan Nikhilesh Bhagavatula
2019-03-31 13:14 ` Pavan Nikhilesh Bhagavatula
2019-04-01 20:25 ` [dpdk-dev] [PATCH v5 1/2] app/testpmd: optimize testpmd " Ferruh Yigit
2019-04-01 20:25 ` Ferruh Yigit
2019-04-01 20:53 ` Thomas Monjalon
2019-04-01 20:53 ` Thomas Monjalon
2019-04-02 1:03 ` Jerin Jacob Kollanukkaran
2019-04-02 1:03 ` Jerin Jacob Kollanukkaran
2019-04-02 7:06 ` Thomas Monjalon
2019-04-02 7:06 ` Thomas Monjalon
2019-04-02 8:31 ` Jerin Jacob Kollanukkaran
2019-04-02 8:31 ` Jerin Jacob Kollanukkaran
2019-04-02 9:03 ` Ali Alnubani
2019-04-02 9:03 ` Ali Alnubani
2019-04-02 9:06 ` Pavan Nikhilesh Bhagavatula
2019-04-02 9:06 ` Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 1/4] app/testpmd: move eth header generation outside the loop Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula [this message]
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 2/4] app/testpmd: use bulk ops for allocating segments Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula
2019-04-09 9:28 ` Lin, Xueqin
2019-04-09 9:28 ` Lin, Xueqin
2019-04-09 9:32 ` Pavan Nikhilesh Bhagavatula
2019-04-09 9:32 ` Pavan Nikhilesh Bhagavatula
2019-04-09 12:24 ` Yao, Lei A
2019-04-09 12:24 ` Yao, Lei A
2019-04-09 12:29 ` Ferruh Yigit
2019-04-09 12:29 ` Ferruh Yigit
2019-04-02 9:53 ` [dpdk-dev] [PATCH v6 4/4] app/testpmd: add mempool bulk get for txonly mode Pavan Nikhilesh Bhagavatula
2019-04-02 9:53 ` Pavan Nikhilesh Bhagavatula
2019-04-02 15:21 ` [dpdk-dev] [PATCH v6 1/4] app/testpmd: move eth header generation outside the loop Raslan Darawsheh
2019-04-02 15:21 ` Raslan Darawsheh
2019-04-04 16:23 ` Ferruh Yigit
2019-04-04 16:23 ` Ferruh Yigit
2019-04-05 17:37 ` Ferruh Yigit
2019-04-05 17:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402095255.848-2-pbhagavatula@marvell.com \
--to=pbhagavatula@marvell.com \
--cc=alialnu@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).