* [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation
@ 2019-04-02 17:09 Ferruh Yigit
2019-04-02 17:09 ` Ferruh Yigit
2019-04-08 7:16 ` Olivier Matz
0 siblings, 2 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-04-02 17:09 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, stable, Chas Williams
Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
they are to say packet contains VLAN or QINQ information.
Updating the definition as they are requests from application to
driver to insert VLAN or double VLAN tags into packet.
Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan")
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Chas Williams <3chas3@gmail.com>
---
lib/librte_mbuf/rte_mbuf.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 73daa8140..f61510f78 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -279,9 +279,11 @@ extern "C" {
#define PKT_TX_TUNNEL_MASK (0xFULL << 45)
/**
- * Second VLAN insertion (QinQ) flag.
+ * Double VLAN insertion (QINQ) request to driver, driver may offload the
+ * insertion based on device capability.
+ * mbuf 'vlan_tci' & 'vlan_tci_outer' must be valid when this flag is set.
*/
-#define PKT_TX_QINQ (1ULL << 49) /**< TX packet with double VLAN inserted. */
+#define PKT_TX_QINQ (1ULL << 49)
/* this old name is deprecated */
#define PKT_TX_QINQ_PKT PKT_TX_QINQ
@@ -337,7 +339,9 @@ extern "C" {
#define PKT_TX_IPV6 (1ULL << 56)
/**
- * TX packet is a 802.1q VLAN packet.
+ * VLAN tag insertion request to driver, driver may offload the insertion
+ * based on the device capability.
+ * mbuf 'vlan_tci' field must be valid when this flag is set.
*/
#define PKT_TX_VLAN (1ULL << 57)
/* this old name is deprecated */
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation
2019-04-02 17:09 [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation Ferruh Yigit
@ 2019-04-02 17:09 ` Ferruh Yigit
2019-04-08 7:16 ` Olivier Matz
1 sibling, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2019-04-02 17:09 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev, stable, Chas Williams
Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
they are to say packet contains VLAN or QINQ information.
Updating the definition as they are requests from application to
driver to insert VLAN or double VLAN tags into packet.
Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan")
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Chas Williams <3chas3@gmail.com>
---
lib/librte_mbuf/rte_mbuf.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 73daa8140..f61510f78 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -279,9 +279,11 @@ extern "C" {
#define PKT_TX_TUNNEL_MASK (0xFULL << 45)
/**
- * Second VLAN insertion (QinQ) flag.
+ * Double VLAN insertion (QINQ) request to driver, driver may offload the
+ * insertion based on device capability.
+ * mbuf 'vlan_tci' & 'vlan_tci_outer' must be valid when this flag is set.
*/
-#define PKT_TX_QINQ (1ULL << 49) /**< TX packet with double VLAN inserted. */
+#define PKT_TX_QINQ (1ULL << 49)
/* this old name is deprecated */
#define PKT_TX_QINQ_PKT PKT_TX_QINQ
@@ -337,7 +339,9 @@ extern "C" {
#define PKT_TX_IPV6 (1ULL << 56)
/**
- * TX packet is a 802.1q VLAN packet.
+ * VLAN tag insertion request to driver, driver may offload the insertion
+ * based on the device capability.
+ * mbuf 'vlan_tci' field must be valid when this flag is set.
*/
#define PKT_TX_VLAN (1ULL << 57)
/* this old name is deprecated */
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation
2019-04-02 17:09 [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation Ferruh Yigit
2019-04-02 17:09 ` Ferruh Yigit
@ 2019-04-08 7:16 ` Olivier Matz
2019-04-08 7:16 ` Olivier Matz
2019-04-19 20:56 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Olivier Matz @ 2019-04-08 7:16 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, stable, Chas Williams
On Tue, Apr 02, 2019 at 06:09:46PM +0100, Ferruh Yigit wrote:
> Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
> they are to say packet contains VLAN or QINQ information.
>
> Updating the definition as they are requests from application to
> driver to insert VLAN or double VLAN tags into packet.
>
> Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan")
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Chas Williams <3chas3@gmail.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation
2019-04-08 7:16 ` Olivier Matz
@ 2019-04-08 7:16 ` Olivier Matz
2019-04-19 20:56 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Olivier Matz @ 2019-04-08 7:16 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, stable, Chas Williams
On Tue, Apr 02, 2019 at 06:09:46PM +0100, Ferruh Yigit wrote:
> Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
> they are to say packet contains VLAN or QINQ information.
>
> Updating the definition as they are requests from application to
> driver to insert VLAN or double VLAN tags into packet.
>
> Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan")
> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Chas Williams <3chas3@gmail.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation
2019-04-08 7:16 ` Olivier Matz
2019-04-08 7:16 ` Olivier Matz
@ 2019-04-19 20:56 ` Thomas Monjalon
2019-04-19 20:56 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-19 20:56 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Olivier Matz, stable, Chas Williams
08/04/2019 09:16, Olivier Matz:
> On Tue, Apr 02, 2019 at 06:09:46PM +0100, Ferruh Yigit wrote:
> > Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
> > they are to say packet contains VLAN or QINQ information.
> >
> > Updating the definition as they are requests from application to
> > driver to insert VLAN or double VLAN tags into packet.
> >
> > Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan")
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation
2019-04-19 20:56 ` Thomas Monjalon
@ 2019-04-19 20:56 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-19 20:56 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Olivier Matz, stable, Chas Williams
08/04/2019 09:16, Olivier Matz:
> On Tue, Apr 02, 2019 at 06:09:46PM +0100, Ferruh Yigit wrote:
> > Currently PKT_TX_VLAN and PKT_TX_QINQ mbuf flags are documented as
> > they are to say packet contains VLAN or QINQ information.
> >
> > Updating the definition as they are requests from application to
> > driver to insert VLAN or double VLAN tags into packet.
> >
> > Fixes: dc6c911c9993 ("mbuf: use reserved space for double vlan")
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-19 20:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02 17:09 [dpdk-dev] [PATCH] mbuf: update Tx VLAN and QinQ mbuf flags documentation Ferruh Yigit
2019-04-02 17:09 ` Ferruh Yigit
2019-04-08 7:16 ` Olivier Matz
2019-04-08 7:16 ` Olivier Matz
2019-04-19 20:56 ` Thomas Monjalon
2019-04-19 20:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).