From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 63932A0679 for ; Wed, 3 Apr 2019 00:12:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1AC985F1B; Wed, 3 Apr 2019 00:12:00 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id F0AEE4CBD for ; Wed, 3 Apr 2019 00:11:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 15:11:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,302,1549958400"; d="scan'208";a="333194752" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by fmsmga006.fm.intel.com with ESMTP; 02 Apr 2019 15:11:57 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-4-anand.rawat@intel.com> <2058052.CBssHhMYLK@xps> <9537388.5AKJxibmNW@xps> From: Anand Rawat Message-ID: Date: Tue, 2 Apr 2019 15:11:57 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <9537388.5AKJxibmNW@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 03/10] eal: add new rte_os.h header to build system X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402221157.4B4uwiHFjtUU5Gk5zUOXtTFntRyKz6dnfeqrZqHu3n8@z> On 4/2/2019 1:47 PM, Thomas Monjalon wrote: > 02/04/2019 21:56, Thomas Monjalon: >> 02/04/2019 05:54, Anand Rawat: >>> Added rte_os.h files to support OS specific functionality. >>> Updated build system to contain OS headers in the include >>> path. >>> >>> Signed-off-by: Anand Rawat >>> Reviewed-by: Pallavi Kadam >>> --- >>> --- a/meson.build >>> +++ b/meson.build >>> -global_inc = include_directories('.', 'config', 'lib/librte_eal/common/include') >>> +global_inc = include_directories('.', 'config', >>> + 'lib/librte_eal/common/include', >>> + 'lib/librte_eal/@0@/eal/include'.format(host_machine.system())) >> >> After having worked on rte_kni_common.h which is only in Linux, >> I think we should add rte_os.h in meson file of each OS: >> - lib/librte_eal/linux/eal/meson.build >> - lib/librte_eal/freebsd/eal/meson.build >> - lib/librte_eal/windows/eal/meson.build > > I confirm: > "global_inc" is used in "includes" variable but not in "headers" variable, > so rte_os.h is not installed as other files in "headers". > We must fill "env_headers" which is pulled by: > headers = common_headers + env_headers > > I will fix it before merging in master if you agree. > > Agreed, env_headers need to be updated for rte_os.h. I have tested the same and will incorporating the changes in v9. Please update this patch with your fix. -- Anand Rawat