From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9EFA0A0679 for <public@inbox.dpdk.org>; Wed, 3 Apr 2019 12:10:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61FBC1B129; Wed, 3 Apr 2019 12:10:13 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id CFBED1B11F for <dev@dpdk.org>; Wed, 3 Apr 2019 12:10:11 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x33A5FXi025405; Wed, 3 Apr 2019 03:10:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=c5ft0NJJnXrsMmFWIERH9Gx9Mwv+3I/TfONm//N/b3Q=; b=YBN46IL9IBDa3FgiCmTsH914CZZ+f1Mi5+aV7pmUzJRPOnTx78zTA1RJ9Z8OgPUxPNNq jWrRg2xYQS3AQF67HEoduXO26Uh/dz/7WspB9j0BxbMD356h9PrYy1f0ikOAFeZsXckz va53JQsRl2Fi2D3YKX66UmJxdwvaquALNfFt6lDmvLCJaKCEKirZkorhdv46rCKZdk0B DHMZ2ne1TOkpequ3uko7SN+EPzuRalCS3BnAKfzh3nQwi98AmYy3CvoDGQGOrNi3qWEa DecscFGJSUh3Mg8FvVcIMzLWP2L2g1lqjaXpI7uxwaLA8aLuXVdJokhtSQZ/qUR8FqDH QA== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2rmd9cj8nq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 03 Apr 2019 03:10:10 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 3 Apr 2019 03:09:59 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.53) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 3 Apr 2019 03:09:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5ft0NJJnXrsMmFWIERH9Gx9Mwv+3I/TfONm//N/b3Q=; b=nJasAzRYb9PRqkwj73oUfdQdZbgNGvWkOsTnp6Pm9vT4YlpQ6FblymAMWcCGncOeaEM/lDjsE+Z+HdzNRJ4X4hPg74bZUnLUSdDOatk8l32DfSOjHGy3rqNj6SwefeZoGGwY4P2B9Mtabg26jgwcYYBaZhmgPm4qci+KQ3Uioio= Received: from MN2PR18MB2542.namprd18.prod.outlook.com (20.179.82.221) by MN2PR18MB2863.namprd18.prod.outlook.com (20.179.21.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.16; Wed, 3 Apr 2019 10:09:58 +0000 Received: from MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90]) by MN2PR18MB2542.namprd18.prod.outlook.com ([fe80::ecb7:6a6e:f852:3d90%6]) with mapi id 15.20.1750.014; Wed, 3 Apr 2019 10:09:58 +0000 From: Ayuj Verma <ayverma@marvell.com> To: Akhil Goyal <akhil.goyal@nxp.com> CC: "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>, "Shally Verma" <shallyv@marvell.com>, Sunila Sahu <ssahu@marvell.com>, "Kanaka Durga Kotamarthy" <kkotamarthy@marvell.com>, Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v3 0/4] adding rsa priv key feature flag Thread-Index: AQHU5VDmFr4Qf/EZl0y7lnKudFqeNKYiumWAgAdumYCAABcRYA== Date: Wed, 3 Apr 2019 10:09:58 +0000 Message-ID: <MN2PR18MB2542AA19707557440C723157AD570@MN2PR18MB2542.namprd18.prod.outlook.com> References: <1553768834-19072-1-git-send-email-ayverma@marvell.com> <487d9431-4de8-b22f-eb92-cec2a6b4a500@nxp.com>, <aa61e105-0494-31aa-d86a-3456d5ffd370@nxp.com> In-Reply-To: <aa61e105-0494-31aa-d86a-3456d5ffd370@nxp.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aae8e90a-6da0-4eb3-26a2-08d6b81c873c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR18MB2863; x-ms-traffictypediagnostic: MN2PR18MB2863: x-microsoft-antispam-prvs: <MN2PR18MB2863617AE625339EB4538C17AD570@MN2PR18MB2863.namprd18.prod.outlook.com> x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(376002)(136003)(396003)(366004)(189003)(199004)(55236004)(8676002)(55016002)(476003)(97736004)(486006)(229853002)(86362001)(478600001)(66066001)(19627405001)(4326008)(74316002)(446003)(81156014)(53546011)(6916009)(14444005)(71190400001)(6436002)(52536014)(6506007)(7736002)(71200400001)(33656002)(256004)(99946001)(11346002)(5660300002)(9686003)(3846002)(6606003)(7696005)(81166006)(68736007)(99286004)(25786009)(54896002)(53936002)(8936002)(6116002)(186003)(2906002)(54906003)(26005)(106356001)(102836004)(76176011)(105586002)(316002)(14454004)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2863; H:MN2PR18MB2542.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: HE3/LBl3xmRjgnsP0zJIFhFHURuAFB07wPCwCsIlS4mUqV6mVQB3/m+/bQS+qjdIwAZqY+e6OIHEvCF8JuyqNJxY4g+y82OUu7BZW2DPwaQAXyJtz/Y7+V7wkqvKv3gXOveVs4gGVzyXCXp/+StC74RWvs3yvn1DcJi9FpEYM+Qlw/SyADzG0iUTQQhWvtKfPIaS0VzwIntR+NBDg/rFF1OIwvOcqp6XeoVz1XJWkeLcE0locaIb/P8sgQE60vZPwpHViU7i4iyIwtdRD7/DupyaL2Mz9X5YjdaYc4DNj19DWGLm1owSS7eGlq6Jt5/N9p5RLis04e7OI6X3vANLF1Xw35Uj4xSAGqp3sy3AH1sQVv9wnEdQ3DBV08iPE5tbz1svpyvQtd3oC5u1ZW5ckSAyBGo9is8ob9TlIgnQKWo= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: aae8e90a-6da0-4eb3-26a2-08d6b81c873c X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2019 10:09:58.5303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2863 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-03_06:, , signatures=0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 0/4] adding rsa priv key feature flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190403100958.fHYazf0secJLPqbmZeNVYtOK7WoaB1VBAWJIUw4T2-0@z> Hi Akhil, Thanks. Regards Ayuj Verma ________________________________ From: Akhil Goyal <akhil.goyal@nxp.com> Sent: 03 April 2019 14:17:11 To: Ayuj Verma Cc: arkadiuszx.kusztal@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga K= otamarthy; Arvind Desai; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/4] adding rsa priv key feature flag On 3/29/2019 8:47 PM, Akhil Goyal wrote: > > On 3/28/2019 3:57 PM, Ayuj Verma wrote: >> Some PMDs can support RSA private key operations using CRT >> (quintuple) or exponent key only. Thus add a feature flag >> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_EXP and >> RTE_CRYPTODEV_FF_RSA_PRIV_OP_KEY_QT in PMD to reflect which key >> type is supported to perform rsa private key op. >> >> App should query PMD feature flag to check if specific >> key type is supported and call operation with relevant key type. >> >> Changes in v3: >> - Rebase changes on top of latest unit test application >> - add feature flag description in documentation >> >> Changes in v2: >> - RSA key type feature flags exponenet and quintuple, >> in place of making them part of xform capabilities. >> >> Ayuj Verma (4): >> lib/cryptodev: add rsa priv key feature flag >> crypto/openssl: set rsa private op feature flag >> app/test: check for key type ff in asym unit test >> doc: add rsa key type to feature list >> >> app/test/test_cryptodev_asym.c | 26 +++++++++++++++++++++= +++++ >> doc/guides/cryptodevs/features/openssl.ini | 2 ++ >> doc/guides/cryptodevs/overview.rst | 6 ++++++ >> drivers/crypto/openssl/rte_openssl_pmd.c | 4 +++- >> lib/librte_cryptodev/rte_cryptodev.c | 4 ++++ >> lib/librte_cryptodev/rte_cryptodev.h | 4 ++++ >> 6 files changed, 45 insertions(+), 1 deletion(-) >> > Applied to dpdk-next-crypto > > 4th patch squashed to 1st and 2nd. > Also added description for 3rd patch. Please add relevant information in > the description in future. > > Thanks. Following errors were observed in compiling documentation Warning generate_overview_table(): Unknown feature 'RSA PRIV OP KEY EXP' in 'openssl.ini' Warning generate_overview_table(): Unknown feature 'RSA PRIV OP KEY QT' in 'openssl.ini' I corrected these byadding the two features in features/default.ini. -Akhil