From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6F71AA0679 for ; Wed, 3 Apr 2019 15:30:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EAEB1B3B9; Wed, 3 Apr 2019 15:30:20 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E8ED81B3A5; Wed, 3 Apr 2019 15:30:17 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 06:30:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="139799635" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga007.fm.intel.com with SMTP; 03 Apr 2019 06:30:11 -0700 Received: by (sSMTP sendmail emulation); Wed, 03 Apr 2019 14:30:10 +0100 Date: Wed, 3 Apr 2019 14:30:10 +0100 From: Bruce Richardson To: "Burakov, Anatoly" Cc: Andrius Sirvys , dev@dpdk.org, Kevin Laatz , stable@dpdk.org, ciara.power@intel.com Message-ID: <20190403133010.GB1309@bricha3-MOBL.ger.corp.intel.com> References: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com> <7e3a6736-24bb-b235-0ce9-aae17ab5d4a0@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <7e3a6736-24bb-b235-0ce9-aae17ab5d4a0@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] usertools: replace unsafe input function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403133010.IAnJgeoWx_rlREZ8MHhYrm2slLBIaojh8S5qRB5YTso@z> On Wed, Apr 03, 2019 at 11:44:40AM +0100, Burakov, Anatoly wrote: > On 20-Mar-19 4:43 PM, Andrius Sirvys wrote: > > LGTM static code analysis tool reports that the function 'input' is > > unsafe. Changed to use raw_input which then converts it using > > ast.literal_eval() which is safe. > > > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > > Cc: ciara.power@intel.com > > > > Signed-off-by: Andrius Sirvys > > --- > > usertools/dpdk-telemetry-client.py | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py > > index ce0c7a9..c3ba77d 100755 > > --- a/usertools/dpdk-telemetry-client.py > > +++ b/usertools/dpdk-telemetry-client.py > > @@ -72,7 +72,7 @@ def requestMetrics(self): # Requests metrics for given client > > def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client > > print("\nPlease enter the number of times you'd like to continuously request Metrics:") > > - n_requests = int(input("\n:")) > > + n_requests = int(ast.literal_eval(raw_input("\n:"))) > > print("\033[F") #Removes the user input from screen, cleans it up > > print("\033[K") > > for i in range(n_requests): > > @@ -87,7 +87,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr > > print("[3] Unregister client") > > try: > > - self.choice = int(input("\n:")) > > + self.choice = int(ast.literal_eval(raw_input("\n:"))) > > print("\033[F") #Removes the user input for screen, cleans it up > > print("\033[K") > > if self.choice == 1: > > > > raw_input doesn't exist in Python 3. > > Perhaps you should do this at the top of the script: > > try: > raw_input # Python 2 > except NameError: > raw_input = input # Python 3 > > That way, all calls to raw_input will call the intended function. > The suggested way in the python docs is a little different: https://python-future.org/compatible_idioms.html#raw_input()