From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DBD331B43D for ; Wed, 3 Apr 2019 15:34:43 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 06:34:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="139800490" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga007.fm.intel.com with SMTP; 03 Apr 2019 06:34:40 -0700 Received: by (sSMTP sendmail emulation); Wed, 03 Apr 2019 14:34:39 +0100 Date: Wed, 3 Apr 2019 14:34:39 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: David Marchand , Thomas Monjalon , dev , Anand Rawat Message-ID: <20190403133439.GC1309@bricha3-MOBL.ger.corp.intel.com> References: <20190401230712.31864-1-thomas@monjalon.net> <20190402193048.27410-1-thomas@monjalon.net> <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 13:34:44 -0000 On Tue, Apr 02, 2019 at 08:52:12PM +0100, Ferruh Yigit wrote: > On 4/2/2019 8:46 PM, David Marchand wrote: > > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon wrote: > > > >> Only one header file (rte_kni_common.h) was in the sub-directory > >> include/exec-env/ > >> This file was installed in a sub-directory of the same name > >> in the makefile-based build. > >> Source and install directories are moved as below: > >> > >> lib/librte_eal/linux/eal/include/exec-env/ > >> -> lib/librte_eal/linux/eal/include/ > >> > >> build/include/exec-env/ > >> -> build/include/ > >> > >> The consequence is to have a file hierarchy a bit more flat. > >> > >> Signed-off-by: Thomas Monjalon > >> > > > > Looks good to me. > > Reviewed-by: David Marchand > > Tested-by: David Marchand > > > > > > Bruce, while testing with meson, I noticed this: > > kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument > > "console". > > WARNING: This will become a hard error in the future. > > WARNING: Unknown keyword arguments in target rte_kni: console > > I am not seeing this... It's ok. The keyword is new in newer versions which obviously won't give an error on it being invalid then. Older versions just ignore it, other than printing the warning you see. In short, harmless, ignore! :-) /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 90055A0679 for ; Wed, 3 Apr 2019 15:34:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A7451B448; Wed, 3 Apr 2019 15:34:45 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id DBD331B43D for ; Wed, 3 Apr 2019 15:34:43 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 06:34:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,304,1549958400"; d="scan'208";a="139800490" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga007.fm.intel.com with SMTP; 03 Apr 2019 06:34:40 -0700 Received: by (sSMTP sendmail emulation); Wed, 03 Apr 2019 14:34:39 +0100 Date: Wed, 3 Apr 2019 14:34:39 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: David Marchand , Thomas Monjalon , dev , Anand Rawat Message-ID: <20190403133439.GC1309@bricha3-MOBL.ger.corp.intel.com> References: <20190401230712.31864-1-thomas@monjalon.net> <20190402193048.27410-1-thomas@monjalon.net> <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <5ff1fa8a-25d1-7676-1ee7-cf9b4c3973c6@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403133439.mv3JiuPxv02j9kzEanvo6LVdWtjpMxv_qmib_podrMQ@z> On Tue, Apr 02, 2019 at 08:52:12PM +0100, Ferruh Yigit wrote: > On 4/2/2019 8:46 PM, David Marchand wrote: > > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon wrote: > > > >> Only one header file (rte_kni_common.h) was in the sub-directory > >> include/exec-env/ > >> This file was installed in a sub-directory of the same name > >> in the makefile-based build. > >> Source and install directories are moved as below: > >> > >> lib/librte_eal/linux/eal/include/exec-env/ > >> -> lib/librte_eal/linux/eal/include/ > >> > >> build/include/exec-env/ > >> -> build/include/ > >> > >> The consequence is to have a file hierarchy a bit more flat. > >> > >> Signed-off-by: Thomas Monjalon > >> > > > > Looks good to me. > > Reviewed-by: David Marchand > > Tested-by: David Marchand > > > > > > Bruce, while testing with meson, I noticed this: > > kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword argument > > "console". > > WARNING: This will become a hard error in the future. > > WARNING: Unknown keyword arguments in target rte_kni: console > > I am not seeing this... It's ok. The keyword is new in newer versions which obviously won't give an error on it being invalid then. Older versions just ignore it, other than printing the warning you see. In short, harmless, ignore! :-) /Bruce