From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 6A66FA0679
for <public@inbox.dpdk.org>; Wed, 3 Apr 2019 18:08:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 06E061B48E;
Wed, 3 Apr 2019 18:08:40 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id 0E44D1B447
for <dev@dpdk.org>; Wed, 3 Apr 2019 18:08:37 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
03 Apr 2019 09:08:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,305,1549958400"; d="scan'208";a="147742069"
Received: from awal-z170x.ir.intel.com ([163.33.210.59])
by orsmga002.jf.intel.com with ESMTP; 03 Apr 2019 09:08:35 -0700
From: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
To: dev@dpdk.org
Cc: maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com,
Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Date: Wed, 3 Apr 2019 17:08:11 +0100
Message-Id: <20190403160811.1282-1-mohammad.abdul.awal@intel.com>
X-Mailer: git-send-email 2.17.1
Subject: [dpdk-dev] [PATCH 2/3] net/virtio: fix null pointer checking
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20190403160811.-lAYYbY3DpBxv7-A__skX6YNb1U9WOPC6NxRbBWz8sE@z>
Null value of device name should return error without further processing.
Fixes: 1c8489da56 ("net/virtio-user: fix multi-process support")
Signed-off-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
---
drivers/net/virtio/virtio_user_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 129c2b9ef..cefc6da66 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -516,6 +516,10 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)
if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
const char *name = rte_vdev_device_name(dev);
+ if (name == NULL) {
+ RTE_LOG(ERR, PMD, "Device name is NULL\n");
+ return -1;
+ }
eth_dev = rte_eth_dev_attach_secondary(name);
if (!eth_dev) {
RTE_LOG(ERR, PMD, "Failed to probe %s\n", name);
--
2.17.1