From: Gage Eads <gage.eads@intel.com>
To: dev@dpdk.org
Cc: olivier.matz@6wind.com, arybchenko@solarflare.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com,
gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, nd@arm.com,
chaozhu@linux.vnet.ibm.com, jerinj@marvell.com,
hemant.agrawal@nxp.com, thomas@monjalon.net
Subject: [dpdk-dev] [PATCH v4 0/1] Add 128-bit compare and set
Date: Wed, 3 Apr 2019 12:34:37 -0500 [thread overview]
Message-ID: <20190403173438.23691-1-gage.eads@intel.com> (raw)
Message-ID: <20190403173437.E-xjSkURFJ6jaXgOtI84xU5lrmwbGXwtjucYTiYgMzk@z> (raw)
In-Reply-To: <20190304205133.2248-1-gage.eads@intel.com>
This patch addresses x86-64 only; other architectures can/will be supported
in the future. The __atomic intrinsic was considered for the implementation,
however libatomic was found[1] to use locks to implement the 128-bit CAS on at
least one architecture and so is eschewed here. The interface is modeled after
the __atomic_compare_exchange_16 (which itself is based on the C++11 memory
model) to best support weak consistency architectures.
This patch was originally part of a series that introduces a non-blocking stack
mempool handler[2], and is required by a non-blocking ring patchset. This
patch was spun off so that the the NB ring depends only on this patch
and not on the entire non-blocking stack patchset.
[1] http://mails.dpdk.org/archives/dev/2019-January/124002.html
[2] http://mails.dpdk.org/archives/dev/2019-January/123653.html
v4:
- Move function declaration from generic/rte_atomic.h to x86-64 header file
v3:
- Rename function to ISA-neutral rte_atomic128_cmp_exchange()
- Fix two pseudocode bugs in function documentation
v2:
- Rename function to rte_atomic128_cmpxchg()
- Replace "=A" output constraint with "=a" and "=d" to prevent GCC from using
the al register for the sete destination
- Extend 'weak' definition to allow non-atomic 'exp' updates.
- Add const keyword to 'src' and remove volatile keyword from 'dst'
- Put __int128 in a union in rte_int128_t and move the structure definition
inside the RTE_ARCH_x86_64 ifdef
- Drop enum rte_atomic_memmodel_t in favor of compiler-defined __ATOMIC_*
- Drop unnecessary comment relating to X86_64
- Tweak the pseudocode to reflect the 'exp' update on failure.
Gage Eads (1):
eal: add 128-bit compare exchange (x86-64 only)
.../common/include/arch/x86/rte_atomic_64.h | 81 ++++++++++++++++++++++
1 file changed, 81 insertions(+)
--
2.13.6
next prev parent reply other threads:[~2019-04-03 17:35 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 17:29 [dpdk-dev] [PATCH " Gage Eads
2019-01-28 17:29 ` [dpdk-dev] [PATCH 1/1] eal: add 128-bit cmpset (x86-64 only) Gage Eads
2019-01-28 23:01 ` Ola Liljedahl
2019-02-01 17:06 ` Eads, Gage
2019-02-01 19:01 ` Ola Liljedahl
2019-02-01 19:28 ` Eads, Gage
2019-02-01 19:43 ` Ola Liljedahl
2019-02-01 21:05 ` Eads, Gage
2019-02-01 23:11 ` Ola Liljedahl
2019-02-04 18:33 ` Honnappa Nagarahalli
2019-01-31 5:48 ` Honnappa Nagarahalli
2019-02-01 17:11 ` Eads, Gage
2019-02-22 15:46 ` [dpdk-dev] [PATCH v2 0/1] Add 128-bit compare and set Gage Eads
2019-02-22 15:46 ` [dpdk-dev] [PATCH v2 1/1] eal: add 128-bit cmpxchg (x86-64 only) Gage Eads
2019-03-04 20:19 ` Honnappa Nagarahalli
2019-03-04 20:47 ` Eads, Gage
2019-03-04 20:51 ` [dpdk-dev] [PATCH v3 0/1] Add 128-bit compare and set Gage Eads
2019-03-04 20:51 ` [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-03-27 23:12 ` Thomas Monjalon
2019-03-27 23:12 ` Thomas Monjalon
2019-03-28 16:22 ` Eads, Gage
2019-03-28 16:22 ` Eads, Gage
2019-04-03 17:34 ` Gage Eads [this message]
2019-04-03 17:34 ` [dpdk-dev] [PATCH v4 0/1] Add 128-bit compare and set Gage Eads
2019-04-03 17:34 ` [dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-04-03 17:34 ` Gage Eads
2019-04-03 19:04 ` Thomas Monjalon
2019-04-03 19:04 ` Thomas Monjalon
2019-04-03 19:21 ` Eads, Gage
2019-04-03 19:21 ` Eads, Gage
2019-04-03 19:27 ` Thomas Monjalon
2019-04-03 19:27 ` Thomas Monjalon
2019-04-03 19:35 ` [dpdk-dev] [PATCH v5] eal/x86: add 128-bit atomic compare exchange Thomas Monjalon
2019-04-03 19:35 ` Thomas Monjalon
2019-04-03 19:44 ` [dpdk-dev] [PATCH v6] " Gage Eads
2019-04-03 19:44 ` Gage Eads
2019-04-03 20:01 ` Thomas Monjalon
2019-04-03 20:01 ` Thomas Monjalon
2019-04-04 11:47 ` Ferruh Yigit
2019-04-04 11:47 ` Ferruh Yigit
2019-04-04 12:08 ` Thomas Monjalon
2019-04-04 12:08 ` Thomas Monjalon
2019-04-04 12:12 ` Thomas Monjalon
2019-04-04 12:12 ` Thomas Monjalon
2019-04-04 12:14 ` Eads, Gage
2019-04-04 12:14 ` Eads, Gage
2019-04-04 12:18 ` Thomas Monjalon
2019-04-04 12:18 ` Thomas Monjalon
2019-04-04 12:22 ` Eads, Gage
2019-04-04 12:22 ` Eads, Gage
2019-04-04 12:24 ` Eads, Gage
2019-04-04 12:24 ` Eads, Gage
2019-04-04 12:52 ` Ferruh Yigit
2019-04-04 12:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403173438.23691-1-gage.eads@intel.com \
--to=gage.eads@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).