From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 35F11A0679 for ; Thu, 4 Apr 2019 07:34:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C5AB34CBD; Thu, 4 Apr 2019 07:34:31 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B81B6293B for ; Thu, 4 Apr 2019 07:34:30 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 22:34:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,306,1549958400"; d="scan'208";a="313018865" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by orsmga005.jf.intel.com with ESMTP; 03 Apr 2019 22:34:27 -0700 Date: Thu, 4 Apr 2019 13:29:33 +0800 From: Ye Xiaolong To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger , Luca Boccassi , Qi Zhang , Karlsson Magnus , Topel Bjorn , Maxime Coquelin , Bruce Richardson , Ananyev Konstantin , David Marchand , Andrew Rybchenko , Olivier Matz Message-ID: <20190404052933.GA45121@intel.com> References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190403165949.44857-1-xiaolong.ye@intel.com> <20190403165949.44857-2-xiaolong.ye@intel.com> <25be95ff-132c-9e3e-fe3d-b5aac3dfb388@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <25be95ff-132c-9e3e-fe3d-b5aac3dfb388@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v10 1/1] net/af_xdp: introduce AF XDP PMD driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190404052933.Cp8Iz5DLY9335uIrmcjDv4b9g-229HOIXUlX1VXC4A0@z> Hi, Ferruh On 04/03, Ferruh Yigit wrote: >On 4/3/2019 5:59 PM, Xiaolong Ye wrote: >> Add a new PMD driver for AF_XDP which is a proposed faster version of >> AF_PACKET interface in Linux. More info about AF_XDP, please refer to [1] >> [2]. >> >> This is the vanilla version PMD which just uses a raw buffer registered as >> the umem. >> >> [1] https://fosdem.org/2018/schedule/event/af_xdp/ >> [2] https://lwn.net/Articles/745934/ >> >> Signed-off-by: Xiaolong Ye > >I am not able to test functionality but code looks good to me, I can compile via >Makefile (with suggested steps in doc) but not able to build with meson, can you >please check below comments? > My bad, sorry for not testing out meson build. ><...> > >> @@ -0,0 +1,21 @@ >> +# SPDX-License-Identifier: BSD-3-Clause >> +# Copyright(c) 2019 Intel Corporation >> + >> +if host_machine.system() != 'linux' >> + build = false >> +endif > >After this point, if build is false it shouldn't continue to below checks I think. Make sense, will do. > >> + >> +bpf_dep = dependency('libbpf', required: false) > >My library is in '/usr/local/lib64/libbpf.so' but this line can't find it. Where >does 'dependency()' checks for libraries? > >> +if bpf_dep.found() >> + build = true >> +else >> + bpf_dep = cc.find_library('libbpf', required: false) > >Also this line can't find it, in log it says "(tried pkgconfig and cmake)" and >yes there is no pkgconfig for it, any idea how 'cmake' used? As Luca said, it should be cc.find_library('bpf', required: false), will correct it in next version. > >> + if bpf_dep.found() and cc.has_header('xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h') > >Should this be 'lib/xsk.h' now? Will change to bpf/xsk.h in next version. Thanks, Xiaolong > >> + build = true >> + pkgconfig_extra_libs += '-lbpf' >> + else >> + build = false >> + endif >> +endif >> +sources = files('rte_eth_af_xdp.c') >> +ext_deps += bpf_dep >