From: "Eads, Gage" <gage.eads@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
Matan Azrad <matan@mellanox.com>,
Yongseok Koh <yskoh@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"gavin.hu@arm.com" <gavin.hu@arm.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"nd@arm.com" <nd@arm.com>,
"chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare exchange
Date: Thu, 4 Apr 2019 12:24:51 +0000 [thread overview]
Message-ID: <9184057F7FC11744A2107296B6B8EB1E54210CEA@FMSMSX108.amr.corp.intel.com> (raw)
Message-ID: <20190404122451.MVOttrFawWWhhW_r2fzNUm7ieZrxLS9xf1LCrQ1UzD8@z> (raw)
In-Reply-To: <2748440.W4LoRDhJ5f@xps>
> -----Original Message-----
> From: Eads, Gage
> Sent: Thursday, April 4, 2019 7:23 AM
> To: 'Thomas Monjalon' <thomas@monjalon.net>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Yongseok Koh <yskoh@mellanox.com>;
> dev@dpdk.org; olivier.matz@6wind.com; arybchenko@solarflare.com;
> Richardson, Bruce <bruce.richardson@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; gavin.hu@arm.com;
> Honnappa.Nagarahalli@arm.com; nd@arm.com;
> chaozhu@linux.vnet.ibm.com; jerinj@marvell.com;
> hemant.agrawal@nxp.com
> Subject: RE: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare
> exchange
>
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Thursday, April 4, 2019 7:18 AM
> > To: Eads, Gage <gage.eads@intel.com>; Yigit, Ferruh
> > <ferruh.yigit@intel.com>
> > Cc: Shahaf Shuler <shahafs@mellanox.com>; Matan Azrad
> > <matan@mellanox.com>; Yongseok Koh <yskoh@mellanox.com>;
> dev@dpdk.org;
> > olivier.matz@6wind.com; arybchenko@solarflare.com; Richardson, Bruce
> > <bruce.richardson@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; gavin.hu@arm.com;
> > Honnappa.Nagarahalli@arm.com; nd@arm.com;
> chaozhu@linux.vnet.ibm.com;
> > jerinj@marvell.com; hemant.agrawal@nxp.com
> > Subject: Re: [dpdk-dev] [PATCH v6] eal/x86: add 128-bit atomic compare
> > exchange
> >
> > 04/04/2019 14:14, Eads, Gage:
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > 04/04/2019 14:08, Thomas Monjalon:
> > > > > 04/04/2019 13:47, Ferruh Yigit:
> > > > > > .../dpdk/x86_64-native-linuxapp-
> gcc/include/rte_atomic_64.h:223:3:
> > > > > > error: ISO C does not support ‘__int128’ types
> > > > > > [-Werror=pedantic]
> > > > >
> > > > > We can try this kind of workaround (disable pedantic locally):
> > > > >
> > > >
> >
> https://github.com/HowardHinnant/date/pull/38/commits/177032852d5b46
> > > > 14
> > > > > 112ca1ab3ef42d6b41824816
> > > >
> > > > Or better:
> > > > __extension__ typedef __int128 int128;
> > > >
> > >
> > > Taking that one step further -- RTE_STD_C11 evaluates to
> > > __extension__
> > (when the STD C version is sufficiently old).
> >
> > I don't think __int128 is part of C11. Is it?
>
> You're right, this is a compiler extension. Using '__extension__' makes more
> sense.
FYI, __int128 was added in GCC 4.6 (and DPDK's minimum version is currently 4.9).
next prev parent reply other threads:[~2019-04-04 12:24 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 17:29 [dpdk-dev] [PATCH 0/1] Add 128-bit compare and set Gage Eads
2019-01-28 17:29 ` [dpdk-dev] [PATCH 1/1] eal: add 128-bit cmpset (x86-64 only) Gage Eads
2019-01-28 23:01 ` Ola Liljedahl
2019-02-01 17:06 ` Eads, Gage
2019-02-01 19:01 ` Ola Liljedahl
2019-02-01 19:28 ` Eads, Gage
2019-02-01 19:43 ` Ola Liljedahl
2019-02-01 21:05 ` Eads, Gage
2019-02-01 23:11 ` Ola Liljedahl
2019-02-04 18:33 ` Honnappa Nagarahalli
2019-01-31 5:48 ` Honnappa Nagarahalli
2019-02-01 17:11 ` Eads, Gage
2019-02-22 15:46 ` [dpdk-dev] [PATCH v2 0/1] Add 128-bit compare and set Gage Eads
2019-02-22 15:46 ` [dpdk-dev] [PATCH v2 1/1] eal: add 128-bit cmpxchg (x86-64 only) Gage Eads
2019-03-04 20:19 ` Honnappa Nagarahalli
2019-03-04 20:47 ` Eads, Gage
2019-03-04 20:51 ` [dpdk-dev] [PATCH v3 0/1] Add 128-bit compare and set Gage Eads
2019-03-04 20:51 ` [dpdk-dev] [PATCH v3 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-03-27 23:12 ` Thomas Monjalon
2019-03-27 23:12 ` Thomas Monjalon
2019-03-28 16:22 ` Eads, Gage
2019-03-28 16:22 ` Eads, Gage
2019-04-03 17:34 ` [dpdk-dev] [PATCH v4 0/1] Add 128-bit compare and set Gage Eads
2019-04-03 17:34 ` Gage Eads
2019-04-03 17:34 ` [dpdk-dev] [PATCH v4 1/1] eal: add 128-bit compare exchange (x86-64 only) Gage Eads
2019-04-03 17:34 ` Gage Eads
2019-04-03 19:04 ` Thomas Monjalon
2019-04-03 19:04 ` Thomas Monjalon
2019-04-03 19:21 ` Eads, Gage
2019-04-03 19:21 ` Eads, Gage
2019-04-03 19:27 ` Thomas Monjalon
2019-04-03 19:27 ` Thomas Monjalon
2019-04-03 19:35 ` [dpdk-dev] [PATCH v5] eal/x86: add 128-bit atomic compare exchange Thomas Monjalon
2019-04-03 19:35 ` Thomas Monjalon
2019-04-03 19:44 ` [dpdk-dev] [PATCH v6] " Gage Eads
2019-04-03 19:44 ` Gage Eads
2019-04-03 20:01 ` Thomas Monjalon
2019-04-03 20:01 ` Thomas Monjalon
2019-04-04 11:47 ` Ferruh Yigit
2019-04-04 11:47 ` Ferruh Yigit
2019-04-04 12:08 ` Thomas Monjalon
2019-04-04 12:08 ` Thomas Monjalon
2019-04-04 12:12 ` Thomas Monjalon
2019-04-04 12:12 ` Thomas Monjalon
2019-04-04 12:14 ` Eads, Gage
2019-04-04 12:14 ` Eads, Gage
2019-04-04 12:18 ` Thomas Monjalon
2019-04-04 12:18 ` Thomas Monjalon
2019-04-04 12:22 ` Eads, Gage
2019-04-04 12:22 ` Eads, Gage
2019-04-04 12:24 ` Eads, Gage [this message]
2019-04-04 12:24 ` Eads, Gage
2019-04-04 12:52 ` Ferruh Yigit
2019-04-04 12:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9184057F7FC11744A2107296B6B8EB1E54210CEA@FMSMSX108.amr.corp.intel.com \
--to=gage.eads@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=matan@mellanox.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).