DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: gage.eads@intel.com,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	david.marchand@redhat.com, alialnu@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
Date: Thu, 04 Apr 2019 15:22:18 +0200	[thread overview]
Message-ID: <3998032.4XeIfXOuir@xps> (raw)
Message-ID: <20190404132218.is1EMPrs90QUZRk9hGe9L1wjCYT_5a1THAfmonlwFag@z> (raw)
In-Reply-To: <20190404130009.22042-1-thomas@monjalon.net>

04/04/2019 15:00, Thomas Monjalon:
> When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> the compiler complains about non standard 128-bit integer type:
> 
> include/rte_atomic_64.h:223:3: error:
> ISO C does not support ‘__int128’ types [-Werror=pedantic]
> 
> It must be marked as an extension of the standard C language
> to be accepted in pedantic compilation.
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Forgot one line:

Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")

Note: It seems only Ferruh can reproduce it.
I wonder whether the RTE_STD_C11 of the union is hiding the issue.




  parent reply	other threads:[~2019-04-04 13:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 13:00 Thomas Monjalon
2019-04-04 13:00 ` Thomas Monjalon
2019-04-04 13:22 ` Thomas Monjalon [this message]
2019-04-04 13:22   ` Thomas Monjalon
2019-04-04 14:14   ` Eads, Gage
2019-04-04 14:14     ` Eads, Gage
2019-04-04 15:13     ` Ferruh Yigit
2019-04-04 15:13       ` Ferruh Yigit
2019-04-04 15:23       ` Thomas Monjalon
2019-04-04 15:23         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3998032.4XeIfXOuir@xps \
    --to=thomas@monjalon.net \
    --cc=alialnu@mellanox.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gage.eads@intel.com \
    --cc=konstantin.ananyev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).