* [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide
@ 2019-03-15 9:19 Rami Rosen
2019-03-15 9:19 ` Rami Rosen
2019-03-15 10:39 ` Kovacevic, Marko
0 siblings, 2 replies; 6+ messages in thread
From: Rami Rosen @ 2019-03-15 9:19 UTC (permalink / raw)
To: dev; +Cc: john.mcnamara, marko.kovacevic, bruce.richardson, Rami Rosen
This patch fixes two typos in the coding style part of
DPDK contributing guide:
- The header entry should have .h file instead of .c file.
- The will->This will
Fixes: 44a6dface13b ("doc: describe how to add new components")
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/contributing/coding_style.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index d96698a73..656563dde 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -825,10 +825,10 @@ format.
.. code-block:: python
sources = files('file1.c', ...)
- headers = files('file1.c', ...)
+ headers = files('file1.h', ...)
-The will build based on a number of conventions and assumptions within the DPDK
+This will build based on a number of conventions and assumptions within the DPDK
itself, for example, that the library name is the same as the directory name in
which the files are stored.
--
2.19.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide
2019-03-15 9:19 [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide Rami Rosen
@ 2019-03-15 9:19 ` Rami Rosen
2019-03-15 10:39 ` Kovacevic, Marko
1 sibling, 0 replies; 6+ messages in thread
From: Rami Rosen @ 2019-03-15 9:19 UTC (permalink / raw)
To: dev; +Cc: john.mcnamara, marko.kovacevic, bruce.richardson, Rami Rosen
This patch fixes two typos in the coding style part of
DPDK contributing guide:
- The header entry should have .h file instead of .c file.
- The will->This will
Fixes: 44a6dface13b ("doc: describe how to add new components")
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/contributing/coding_style.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index d96698a73..656563dde 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -825,10 +825,10 @@ format.
.. code-block:: python
sources = files('file1.c', ...)
- headers = files('file1.c', ...)
+ headers = files('file1.h', ...)
-The will build based on a number of conventions and assumptions within the DPDK
+This will build based on a number of conventions and assumptions within the DPDK
itself, for example, that the library name is the same as the directory name in
which the files are stored.
--
2.19.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide
2019-03-15 9:19 [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide Rami Rosen
2019-03-15 9:19 ` Rami Rosen
@ 2019-03-15 10:39 ` Kovacevic, Marko
2019-03-15 10:39 ` Kovacevic, Marko
2019-04-05 8:00 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Kovacevic, Marko @ 2019-03-15 10:39 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: Mcnamara, John, Richardson, Bruce
> This patch fixes two typos in the coding style part of DPDK contributing guide:
>
> - The header entry should have .h file instead of .c file.
> - The will->This will
>
> Fixes: 44a6dface13b ("doc: describe how to add new components")
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> doc/guides/contributing/coding_style.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst
> b/doc/guides/contributing/coding_style.rst
> index d96698a73..656563dde 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -825,10 +825,10 @@ format.
> .. code-block:: python
>
> sources = files('file1.c', ...)
> - headers = files('file1.c', ...)
> + headers = files('file1.h', ...)
>
>
> -The will build based on a number of conventions and assumptions within the
> DPDK
> +This will build based on a number of conventions and assumptions within
> +the DPDK
> itself, for example, that the library name is the same as the directory name
> in which the files are stored.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide
2019-03-15 10:39 ` Kovacevic, Marko
@ 2019-03-15 10:39 ` Kovacevic, Marko
2019-04-05 8:00 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Kovacevic, Marko @ 2019-03-15 10:39 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: Mcnamara, John, Richardson, Bruce
> This patch fixes two typos in the coding style part of DPDK contributing guide:
>
> - The header entry should have .h file instead of .c file.
> - The will->This will
>
> Fixes: 44a6dface13b ("doc: describe how to add new components")
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> doc/guides/contributing/coding_style.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/contributing/coding_style.rst
> b/doc/guides/contributing/coding_style.rst
> index d96698a73..656563dde 100644
> --- a/doc/guides/contributing/coding_style.rst
> +++ b/doc/guides/contributing/coding_style.rst
> @@ -825,10 +825,10 @@ format.
> .. code-block:: python
>
> sources = files('file1.c', ...)
> - headers = files('file1.c', ...)
> + headers = files('file1.h', ...)
>
>
> -The will build based on a number of conventions and assumptions within the
> DPDK
> +This will build based on a number of conventions and assumptions within
> +the DPDK
> itself, for example, that the library name is the same as the directory name
> in which the files are stored.
Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide
2019-03-15 10:39 ` Kovacevic, Marko
2019-03-15 10:39 ` Kovacevic, Marko
@ 2019-04-05 8:00 ` Thomas Monjalon
2019-04-05 8:00 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-05 8:00 UTC (permalink / raw)
To: Rami Rosen
Cc: dev, Kovacevic, Marko, Mcnamara, John, Richardson, Bruce, stable
15/03/2019 11:39, Kovacevic, Marko:
> > This patch fixes two typos in the coding style part of DPDK contributing guide:
> >
> > - The header entry should have .h file instead of .c file.
> > - The will->This will
> >
> > Fixes: 44a6dface13b ("doc: describe how to add new components")
+Cc: stable@dpdk.org
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide
2019-04-05 8:00 ` Thomas Monjalon
@ 2019-04-05 8:00 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-05 8:00 UTC (permalink / raw)
To: Rami Rosen
Cc: dev, Kovacevic, Marko, Mcnamara, John, Richardson, Bruce, stable
15/03/2019 11:39, Kovacevic, Marko:
> > This patch fixes two typos in the coding style part of DPDK contributing guide:
> >
> > - The header entry should have .h file instead of .c file.
> > - The will->This will
> >
> > Fixes: 44a6dface13b ("doc: describe how to add new components")
+Cc: stable@dpdk.org
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-05 8:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 9:19 [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide Rami Rosen
2019-03-15 9:19 ` Rami Rosen
2019-03-15 10:39 ` Kovacevic, Marko
2019-03-15 10:39 ` Kovacevic, Marko
2019-04-05 8:00 ` Thomas Monjalon
2019-04-05 8:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).