From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AD234A0679 for ; Fri, 5 Apr 2019 14:35:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 351FB1B4CF; Fri, 5 Apr 2019 14:35:30 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B9AB31B4CD for ; Fri, 5 Apr 2019 14:35:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5712722196; Fri, 5 Apr 2019 08:35:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 05 Apr 2019 08:35:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=bo9sEQpooX5w1CLaCgMiVk8Go4sVBUH0Qq8FrYrvzPI=; b=lswZufsv/Qmz 3tt06x3NjNoyHmH1v1vykgDpVfzRlbroA6you5H4qGf/xXgo4Cjeq85r3N/ndqg0 CDwz1F+MOwUJJbF/wbZkUN7ihJqzKSJLJfbwNzALuVFe1NC9+rp95I1fkllU8eis fxClcUEYEdoKFR6+b8XOJHD+mg2eypI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=bo9sEQpooX5w1CLaCgMiVk8Go4sVBUH0Qq8FrYrvz PI=; b=vpugul1ls73UNjXm0e/81/JIK4YJIL2gZ0VIF+9ksBZ4JlYgGhPPa7SHA qMGYXA1WyOxeIZseevr3I8sC86nBYRCDszteKcxP4KS1lUmdcahSEhwePxKjymIB eemkc9mefInEfdwYUCsMr3B/Vz2AlPrc8LdhN8yWCj4Ndudya1wyk50huEhJEFBv YgARtxnOVibMvzmCrbBdIvOef5erDYCaxJPJWW6enKfFc6GTWG5jxygnFcuhJUOB X5Ch4YqDWSJkN4aaBxXeFkVKKAfSbxE2cGC+FrKuFHMCbf3GroJ3CGDzmnCgv92G YfvM97fzWtZGtYp1fu3YsBPfq4zjg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdejgdehtdculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D41DB10380; Fri, 5 Apr 2019 08:35:26 -0400 (EDT) From: Thomas Monjalon To: Shreyansh Jain Cc: Ferruh Yigit , "dev@dpdk.org" Date: Fri, 05 Apr 2019 14:35:24 +0200 Message-ID: <1997651.eKLBMHFVRg@xps> In-Reply-To: References: <20190403142357.17700-1-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190405123524.K-DPfEFfRjjcCYZV9AGZOGqiUMEv9b0XUwjOD-9Aq8A@z> 05/04/2019 13:38, Shreyansh Jain: > On 05/04/19 4:49 PM, Shreyansh Jain wrote: > > On 05/04/19 3:13 AM, Thomas Monjalon wrote: > >> 04/04/2019 23:29, Ferruh Yigit: > >>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote: > >>>> Removes some unused firmware code which was added in last bump > >>>> of the firmware version. No current features uses these APIs. > >>>> > >>>> Signed-off-by: Shreyansh Jain > >>> > >>> <...> > >>> > >>>> diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h > >>>> index 9af9097e5..cf3d15267 100644 > >>>> --- a/drivers/bus/fslmc/mc/fsl_dpci.h > >>>> +++ b/drivers/bus/fslmc/mc/fsl_dpci.h > >>>> @@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io, > >>>> uint16_t token, > >>>> struct dpci_attr *attr); > >>>> > >>>> -/** > >>>> - * struct dpci_peer_attr - Structure representing the peer DPCI attributes > >>>> - * @peer_id: DPCI peer id; if no peer is connected returns (-1) > >>>> - * @num_of_priorities: The pper's number of receive priorities; determines the > >>>> - * number of transmit priorities for the local DPCI object > >>>> - */ > >>>> -struct dpci_peer_attr { > >>>> - int peer_id; > >>>> - uint8_t num_of_priorities; > >>>> -}; > >>>> - > >>>> -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io, > >>>> - uint32_t cmd_flags, > >>>> - uint16_t token, > >>>> - struct dpci_peer_attr *attr); > >>>> - > >>>> -int dpci_get_link_state(struct fsl_mc_io *mc_io, > >>>> - uint32_t cmd_flags, > >>>> - uint16_t token, > >>>> - int *up); > >>> > >>> These needs to be removed from .map file too. > > > > Wow! indeed a great catch. > > And, yup, my bad. Sorry! I wish I had your eye-for-detail. > > > >> > >> Removed from master. > >> Thanks for the catch. > > Thomas, > I still see this applied on the master and net-next. > Can you tell me how do you want me to do - send a fresh series or just > the delta change for map file? I don't see them. Please update master and check again.