* [dpdk-dev] [PATCH] net/af_xdp: fix meson for non Linux platforms
@ 2019-04-05 15:20 Ferruh Yigit
2019-04-05 15:20 ` Ferruh Yigit
2019-04-05 15:33 ` [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification Bruce Richardson
0 siblings, 2 replies; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-05 15:20 UTC (permalink / raw)
To: Xiaolong Ye, Qi Zhang; +Cc: dev
Fixes: 55bcda7b3515 ("net/af_xdp: introduce AF XDP PMD driver")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/af_xdp/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index 840c93728..e3d86c39a 100644
--- a/drivers/net/af_xdp/meson.build
+++ b/drivers/net/af_xdp/meson.build
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2019 Intel Corporation
+build = false
if host_machine.system() == 'linux'
bpf_dep = dependency('libbpf', required: false)
if bpf_dep.found()
@@ -10,8 +11,6 @@ if host_machine.system() == 'linux'
if bpf_dep.found() and cc.has_header('bpf/xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')
build = true
pkgconfig_extra_libs += '-lbpf'
- else
- build = false
endif
endif
ext_deps += bpf_dep
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH] net/af_xdp: fix meson for non Linux platforms
2019-04-05 15:20 [dpdk-dev] [PATCH] net/af_xdp: fix meson for non Linux platforms Ferruh Yigit
@ 2019-04-05 15:20 ` Ferruh Yigit
2019-04-05 15:33 ` [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification Bruce Richardson
1 sibling, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-05 15:20 UTC (permalink / raw)
To: Xiaolong Ye, Qi Zhang; +Cc: dev
Fixes: 55bcda7b3515 ("net/af_xdp: introduce AF XDP PMD driver")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/af_xdp/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index 840c93728..e3d86c39a 100644
--- a/drivers/net/af_xdp/meson.build
+++ b/drivers/net/af_xdp/meson.build
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2019 Intel Corporation
+build = false
if host_machine.system() == 'linux'
bpf_dep = dependency('libbpf', required: false)
if bpf_dep.found()
@@ -10,8 +11,6 @@ if host_machine.system() == 'linux'
if bpf_dep.found() and cc.has_header('bpf/xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')
build = true
pkgconfig_extra_libs += '-lbpf'
- else
- build = false
endif
endif
ext_deps += bpf_dep
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification
2019-04-05 15:20 [dpdk-dev] [PATCH] net/af_xdp: fix meson for non Linux platforms Ferruh Yigit
2019-04-05 15:20 ` Ferruh Yigit
@ 2019-04-05 15:33 ` Bruce Richardson
2019-04-05 15:33 ` Bruce Richardson
` (2 more replies)
1 sibling, 3 replies; 8+ messages in thread
From: Bruce Richardson @ 2019-04-05 15:33 UTC (permalink / raw)
To: dev, ferruh.yigit, Xiaolong Ye; +Cc: Bruce Richardson
The build spec has lots of levels of indentation, which can be reduced by
not explicitly checking for linux, but for the needed header and library
files needed for the driver.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/af_xdp/meson.build | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index 840c93728..7904840f0 100644
--- a/drivers/net/af_xdp/meson.build
+++ b/drivers/net/af_xdp/meson.build
@@ -1,19 +1,16 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2019 Intel Corporation
-if host_machine.system() == 'linux'
- bpf_dep = dependency('libbpf', required: false)
- if bpf_dep.found()
- build = true
- else
- bpf_dep = cc.find_library('bpf', required: false)
- if bpf_dep.found() and cc.has_header('bpf/xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')
- build = true
- pkgconfig_extra_libs += '-lbpf'
- else
- build = false
- endif
- endif
+sources = files('rte_eth_af_xdp.c')
+
+bpf_dep = dependency('libbpf', required: false)
+if not bpf_dep.found()
+ bpf_dep = cc.find_library('bpf', required: false)
+endif
+
+if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xdp.h')
ext_deps += bpf_dep
+ pkgconfig_extra_libs += '-lbpf'
+else
+ build = false
endif
-sources = files('rte_eth_af_xdp.c')
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification
2019-04-05 15:33 ` [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification Bruce Richardson
@ 2019-04-05 15:33 ` Bruce Richardson
2019-04-05 15:41 ` Ferruh Yigit
2019-04-05 15:45 ` Ferruh Yigit
2 siblings, 0 replies; 8+ messages in thread
From: Bruce Richardson @ 2019-04-05 15:33 UTC (permalink / raw)
To: dev, ferruh.yigit, Xiaolong Ye; +Cc: Bruce Richardson
The build spec has lots of levels of indentation, which can be reduced by
not explicitly checking for linux, but for the needed header and library
files needed for the driver.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/af_xdp/meson.build | 25 +++++++++++--------------
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
index 840c93728..7904840f0 100644
--- a/drivers/net/af_xdp/meson.build
+++ b/drivers/net/af_xdp/meson.build
@@ -1,19 +1,16 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2019 Intel Corporation
-if host_machine.system() == 'linux'
- bpf_dep = dependency('libbpf', required: false)
- if bpf_dep.found()
- build = true
- else
- bpf_dep = cc.find_library('bpf', required: false)
- if bpf_dep.found() and cc.has_header('bpf/xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')
- build = true
- pkgconfig_extra_libs += '-lbpf'
- else
- build = false
- endif
- endif
+sources = files('rte_eth_af_xdp.c')
+
+bpf_dep = dependency('libbpf', required: false)
+if not bpf_dep.found()
+ bpf_dep = cc.find_library('bpf', required: false)
+endif
+
+if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xdp.h')
ext_deps += bpf_dep
+ pkgconfig_extra_libs += '-lbpf'
+else
+ build = false
endif
-sources = files('rte_eth_af_xdp.c')
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification
2019-04-05 15:33 ` [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification Bruce Richardson
2019-04-05 15:33 ` Bruce Richardson
@ 2019-04-05 15:41 ` Ferruh Yigit
2019-04-05 15:41 ` Ferruh Yigit
2019-04-05 15:45 ` Ferruh Yigit
2 siblings, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-05 15:41 UTC (permalink / raw)
To: Bruce Richardson, dev, Xiaolong Ye
On 4/5/2019 4:33 PM, Bruce Richardson wrote:
> The build spec has lots of levels of indentation, which can be reduced by
> not explicitly checking for linux, but for the needed header and library
> files needed for the driver.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/af_xdp/meson.build | 25 +++++++++++--------------
> 1 file changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
> index 840c93728..7904840f0 100644
> --- a/drivers/net/af_xdp/meson.build
> +++ b/drivers/net/af_xdp/meson.build
> @@ -1,19 +1,16 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2019 Intel Corporation
>
> -if host_machine.system() == 'linux'
> - bpf_dep = dependency('libbpf', required: false)
> - if bpf_dep.found()
> - build = true
> - else
> - bpf_dep = cc.find_library('bpf', required: false)
> - if bpf_dep.found() and cc.has_header('bpf/xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')
> - build = true
> - pkgconfig_extra_libs += '-lbpf'
> - else
> - build = false
> - endif
> - endif
> +sources = files('rte_eth_af_xdp.c')
> +
> +bpf_dep = dependency('libbpf', required: false)
> +if not bpf_dep.found()
> + bpf_dep = cc.find_library('bpf', required: false)
> +endif
> +
> +if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xdp.h')
> ext_deps += bpf_dep
> + pkgconfig_extra_libs += '-lbpf'
> +else
> + build = false
> endif
> -sources = files('rte_eth_af_xdp.c')
>
Looks good to me.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification
2019-04-05 15:41 ` Ferruh Yigit
@ 2019-04-05 15:41 ` Ferruh Yigit
0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-05 15:41 UTC (permalink / raw)
To: Bruce Richardson, dev, Xiaolong Ye
On 4/5/2019 4:33 PM, Bruce Richardson wrote:
> The build spec has lots of levels of indentation, which can be reduced by
> not explicitly checking for linux, but for the needed header and library
> files needed for the driver.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/af_xdp/meson.build | 25 +++++++++++--------------
> 1 file changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build
> index 840c93728..7904840f0 100644
> --- a/drivers/net/af_xdp/meson.build
> +++ b/drivers/net/af_xdp/meson.build
> @@ -1,19 +1,16 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2019 Intel Corporation
>
> -if host_machine.system() == 'linux'
> - bpf_dep = dependency('libbpf', required: false)
> - if bpf_dep.found()
> - build = true
> - else
> - bpf_dep = cc.find_library('bpf', required: false)
> - if bpf_dep.found() and cc.has_header('bpf/xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')
> - build = true
> - pkgconfig_extra_libs += '-lbpf'
> - else
> - build = false
> - endif
> - endif
> +sources = files('rte_eth_af_xdp.c')
> +
> +bpf_dep = dependency('libbpf', required: false)
> +if not bpf_dep.found()
> + bpf_dep = cc.find_library('bpf', required: false)
> +endif
> +
> +if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xdp.h')
> ext_deps += bpf_dep
> + pkgconfig_extra_libs += '-lbpf'
> +else
> + build = false
> endif
> -sources = files('rte_eth_af_xdp.c')
>
Looks good to me.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification
2019-04-05 15:33 ` [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification Bruce Richardson
2019-04-05 15:33 ` Bruce Richardson
2019-04-05 15:41 ` Ferruh Yigit
@ 2019-04-05 15:45 ` Ferruh Yigit
2019-04-05 15:45 ` Ferruh Yigit
2 siblings, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-05 15:45 UTC (permalink / raw)
To: Bruce Richardson, dev, Xiaolong Ye
On 4/5/2019 4:33 PM, Bruce Richardson wrote:
> The build spec has lots of levels of indentation, which can be reduced by
> not explicitly checking for linux, but for the needed header and library
> files needed for the driver.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification
2019-04-05 15:45 ` Ferruh Yigit
@ 2019-04-05 15:45 ` Ferruh Yigit
0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-05 15:45 UTC (permalink / raw)
To: Bruce Richardson, dev, Xiaolong Ye
On 4/5/2019 4:33 PM, Bruce Richardson wrote:
> The build spec has lots of levels of indentation, which can be reduced by
> not explicitly checking for linux, but for the needed header and library
> files needed for the driver.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-05 15:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-05 15:20 [dpdk-dev] [PATCH] net/af_xdp: fix meson for non Linux platforms Ferruh Yigit
2019-04-05 15:20 ` Ferruh Yigit
2019-04-05 15:33 ` [dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification Bruce Richardson
2019-04-05 15:33 ` Bruce Richardson
2019-04-05 15:41 ` Ferruh Yigit
2019-04-05 15:41 ` Ferruh Yigit
2019-04-05 15:45 ` Ferruh Yigit
2019-04-05 15:45 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).