From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <marcinx.hajkowski@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id A179F1B569
for <dev@dpdk.org>; Fri, 5 Apr 2019 18:23:40 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
05 Apr 2019 09:23:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,313,1549958400"; d="scan'208";a="158588057"
Received: from mhajkowx-mobl.ger.corp.intel.com ([10.104.116.181])
by fmsmga002.fm.intel.com with ESMTP; 05 Apr 2019 09:23:39 -0700
From: Hajkowski <marcinx.hajkowski@intel.com>
To: david.hunt@intel.com
Cc: dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Date: Fri, 5 Apr 2019 18:22:05 +0200
Message-Id: <20190405162205.4824-4-marcinx.hajkowski@intel.com>
X-Mailer: git-send-email 2.20.1.windows.1
In-Reply-To: <20190405162205.4824-1-marcinx.hajkowski@intel.com>
References: <20190405162205.4824-1-marcinx.hajkowski@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH 3/3] power: add UTs for all power env types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 16:23:41 -0000
From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.
Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
app/test/test_power.c | 156 ++++++++++++++++++++++++++++++++----------
1 file changed, 121 insertions(+), 35 deletions(-)
diff --git a/app/test/test_power.c b/app/test/test_power.c
index a0ee21983..0ff2aa0d1 100644
--- a/app/test/test_power.c
+++ b/app/test/test_power.c
@@ -7,6 +7,7 @@
#include <unistd.h>
#include <limits.h>
#include <string.h>
+#include <stdbool.h>
#include "test.h"
@@ -23,6 +24,86 @@ test_power(void)
#include <rte_power.h>
+static int
+check_function_ptrs(void)
+{
+ enum power_management_env env = rte_power_get_env();
+
+ const bool not_null_expected = !(env == PM_ENV_NOT_SET);
+
+ const char *inject_not_string1 = not_null_expected ? " not" : "";
+ const char *inject_not_string2 = not_null_expected ? "" : " not";
+
+ if ((rte_power_freqs == NULL) == not_null_expected) {
+ printf("rte_power_freqs should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_get_freq == NULL) == not_null_expected) {
+ printf("rte_power_get_freq should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_set_freq == NULL) == not_null_expected) {
+ printf("rte_power_set_freq should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_up == NULL) == not_null_expected) {
+ printf("rte_power_freq_up should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_down == NULL) == not_null_expected) {
+ printf("rte_power_freq_down should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_max == NULL) == not_null_expected) {
+ printf("rte_power_freq_max should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_min == NULL) == not_null_expected) {
+ printf("rte_power_freq_min should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_turbo_status == NULL) == not_null_expected) {
+ printf("rte_power_turbo_status should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_enable_turbo == NULL) == not_null_expected) {
+ printf("rte_power_freq_enable_turbo should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_disable_turbo == NULL) == not_null_expected) {
+ printf("rte_power_freq_disable_turbo should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_get_capabilities == NULL) == not_null_expected) {
+ printf("rte_power_get_capabilities should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+
+ return 0;
+}
+
static int
test_power(void)
{
@@ -43,43 +124,48 @@ test_power(void)
return -1;
}
- /* verify that function pointers are NULL */
- if (rte_power_freqs != NULL) {
- printf("rte_power_freqs should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_get_freq != NULL) {
- printf("rte_power_get_freq should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_set_freq != NULL) {
- printf("rte_power_set_freq should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_up != NULL) {
- printf("rte_power_freq_up should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_down != NULL) {
- printf("rte_power_freq_down should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_max != NULL) {
- printf("rte_power_freq_max should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_min != NULL) {
- printf("rte_power_freq_min should be NULL, environment has not been "
- "initialised\n");
+ /* Verify that function pointers are NULL */
+ if (check_function_ptrs() < 0)
goto fail_all;
- }
+
rte_power_unset_env();
+
+ /* Perform tests for valid environments.*/
+ const enum power_management_env envs[] = {PM_ENV_ACPI_CPUFREQ,
+ PM_ENV_KVM_VM,
+ PM_ENV_PSTATE_CPUFREQ};
+
+ const int envs_size = sizeof(envs)/sizeof(enum power_management_env);
+
+ int i;
+ for (i = 0; i < envs_size; ++i) {
+
+ /* Test setting a valid environment */
+ ret = rte_power_set_env(envs[i]);
+ if (ret != 0) {
+ printf("Unexpectedly unsucceeded on setting a valid environment\n");
+ return -1;
+ }
+
+ /* Test that the environment has been set */
+ env = rte_power_get_env();
+ if (env != envs[i]) {
+ printf("Not expected environment configuration\n");
+ return -1;
+ }
+
+ /* Verify that function pointers are NOT NULL */
+ if (check_function_ptrs() < 0)
+ goto fail_all;
+
+ rte_power_unset_env();
+
+ /* Verify that function pointers are NULL */
+ if (check_function_ptrs() < 0)
+ goto fail_all;
+
+ }
+
return 0;
fail_all:
rte_power_unset_env();
--
2.17.2
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id D12A3A0679
for <public@inbox.dpdk.org>; Fri, 5 Apr 2019 18:24:00 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 48BD81B579;
Fri, 5 Apr 2019 18:23:49 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id A179F1B569
for <dev@dpdk.org>; Fri, 5 Apr 2019 18:23:40 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
05 Apr 2019 09:23:40 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,313,1549958400"; d="scan'208";a="158588057"
Received: from mhajkowx-mobl.ger.corp.intel.com ([10.104.116.181])
by fmsmga002.fm.intel.com with ESMTP; 05 Apr 2019 09:23:39 -0700
From: Hajkowski <marcinx.hajkowski@intel.com>
To: david.hunt@intel.com
Cc: dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Date: Fri, 5 Apr 2019 18:22:05 +0200
Message-Id: <20190405162205.4824-4-marcinx.hajkowski@intel.com>
X-Mailer: git-send-email 2.20.1.windows.1
In-Reply-To: <20190405162205.4824-1-marcinx.hajkowski@intel.com>
References: <20190405162205.4824-1-marcinx.hajkowski@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH 3/3] power: add UTs for all power env types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20190405162205.tvvrC8HL_zZXSl9oqcGXYBppmW_DNocnx7L65MySfH0@z>
From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
Test all existing power environment configuration to verify if related
data is properly initialized and clean in set/unset scenarios.
Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
app/test/test_power.c | 156 ++++++++++++++++++++++++++++++++----------
1 file changed, 121 insertions(+), 35 deletions(-)
diff --git a/app/test/test_power.c b/app/test/test_power.c
index a0ee21983..0ff2aa0d1 100644
--- a/app/test/test_power.c
+++ b/app/test/test_power.c
@@ -7,6 +7,7 @@
#include <unistd.h>
#include <limits.h>
#include <string.h>
+#include <stdbool.h>
#include "test.h"
@@ -23,6 +24,86 @@ test_power(void)
#include <rte_power.h>
+static int
+check_function_ptrs(void)
+{
+ enum power_management_env env = rte_power_get_env();
+
+ const bool not_null_expected = !(env == PM_ENV_NOT_SET);
+
+ const char *inject_not_string1 = not_null_expected ? " not" : "";
+ const char *inject_not_string2 = not_null_expected ? "" : " not";
+
+ if ((rte_power_freqs == NULL) == not_null_expected) {
+ printf("rte_power_freqs should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_get_freq == NULL) == not_null_expected) {
+ printf("rte_power_get_freq should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_set_freq == NULL) == not_null_expected) {
+ printf("rte_power_set_freq should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_up == NULL) == not_null_expected) {
+ printf("rte_power_freq_up should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_down == NULL) == not_null_expected) {
+ printf("rte_power_freq_down should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_max == NULL) == not_null_expected) {
+ printf("rte_power_freq_max should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_min == NULL) == not_null_expected) {
+ printf("rte_power_freq_min should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_turbo_status == NULL) == not_null_expected) {
+ printf("rte_power_turbo_status should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_enable_turbo == NULL) == not_null_expected) {
+ printf("rte_power_freq_enable_turbo should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_freq_disable_turbo == NULL) == not_null_expected) {
+ printf("rte_power_freq_disable_turbo should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+ if ((rte_power_get_capabilities == NULL) == not_null_expected) {
+ printf("rte_power_get_capabilities should%s be NULL, environment has%s been "
+ "initialised\n", inject_not_string1,
+ inject_not_string2);
+ return -1;
+ }
+
+ return 0;
+}
+
static int
test_power(void)
{
@@ -43,43 +124,48 @@ test_power(void)
return -1;
}
- /* verify that function pointers are NULL */
- if (rte_power_freqs != NULL) {
- printf("rte_power_freqs should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_get_freq != NULL) {
- printf("rte_power_get_freq should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_set_freq != NULL) {
- printf("rte_power_set_freq should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_up != NULL) {
- printf("rte_power_freq_up should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_down != NULL) {
- printf("rte_power_freq_down should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_max != NULL) {
- printf("rte_power_freq_max should be NULL, environment has not been "
- "initialised\n");
- goto fail_all;
- }
- if (rte_power_freq_min != NULL) {
- printf("rte_power_freq_min should be NULL, environment has not been "
- "initialised\n");
+ /* Verify that function pointers are NULL */
+ if (check_function_ptrs() < 0)
goto fail_all;
- }
+
rte_power_unset_env();
+
+ /* Perform tests for valid environments.*/
+ const enum power_management_env envs[] = {PM_ENV_ACPI_CPUFREQ,
+ PM_ENV_KVM_VM,
+ PM_ENV_PSTATE_CPUFREQ};
+
+ const int envs_size = sizeof(envs)/sizeof(enum power_management_env);
+
+ int i;
+ for (i = 0; i < envs_size; ++i) {
+
+ /* Test setting a valid environment */
+ ret = rte_power_set_env(envs[i]);
+ if (ret != 0) {
+ printf("Unexpectedly unsucceeded on setting a valid environment\n");
+ return -1;
+ }
+
+ /* Test that the environment has been set */
+ env = rte_power_get_env();
+ if (env != envs[i]) {
+ printf("Not expected environment configuration\n");
+ return -1;
+ }
+
+ /* Verify that function pointers are NOT NULL */
+ if (check_function_ptrs() < 0)
+ goto fail_all;
+
+ rte_power_unset_env();
+
+ /* Verify that function pointers are NULL */
+ if (check_function_ptrs() < 0)
+ goto fail_all;
+
+ }
+
return 0;
fail_all:
rte_power_unset_env();
--
2.17.2