From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 204CEA0679
	for <public@inbox.dpdk.org>; Fri,  5 Apr 2019 19:09:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id D2DEF1B56E;
	Fri,  5 Apr 2019 19:09:06 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id E14FC1B56B
 for <dev@dpdk.org>; Fri,  5 Apr 2019 19:09:05 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 05 Apr 2019 10:09:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,313,1549958400"; d="scan'208";a="161781558"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by fmsmga001.fm.intel.com with ESMTP; 05 Apr 2019 10:09:03 -0700
Received: from irsmsx110.ger.corp.intel.com ([169.254.15.173]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.115]) with mapi id 14.03.0415.000;
 Fri, 5 Apr 2019 18:09:02 +0100
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Kovacevic, Marko" <marko.kovacevic@intel.com>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>
CC: "Wiles, Keith" <keith.wiles@intel.com>, "Mcnamara, John"
 <john.mcnamara@intel.com>, "Byrne, Stephen1" <stephen1.byrne@intel.com>,
 "Tamboli, Amit S" <amit.tamboli@intel.com>, "Padubidri, Sanjay A"
 <sanjay.padubidri@intel.com>, "Patel, Amol" <amol.patel@intel.com>
Thread-Topic: [PATCH v6 2/2] app/pdump: enhance to support multi-core capture
Thread-Index: AQHU6sQbek81ycqqK0adyw4F90vB+6YtzE1Q
Date: Fri, 5 Apr 2019 17:09:01 +0000
Message-ID:
 <3AEA2BF9852C6F48A459DA490692831F2A443D4B@irsmsx110.ger.corp.intel.com>
References: <20190402091836.35779-3-vipin.varghese@intel.com>
 <20190404085515.15789-1-vipin.varghese@intel.com>
 <20190404085515.15789-3-vipin.varghese@intel.com>
In-Reply-To: <20190404085515.15789-3-vipin.varghese@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjA2ZjczOGItOGJlNC00ZjQ5LTgzMDQtZDIwODE2NmEzZGI2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaUZaWEQ4MjJOXC9qSlpWZ2MxNDhWTzN1WmFXRlRQOHpBUGdGakRqbTZFc0JpTm11XC9hTGN5cnROZUl0dUszVTFOIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support
	multi-core capture
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190405170901.OMUBGNd_-UKVKT8ys_skiDFHbNfqJEl_wDXnS6VLX5M@z>



> -----Original Message-----
> From: Varghese, Vipin
>=20


Nit picks:

>=20
> +The ``--multi`` command line option is optional argument. If passed,
> +capture will be running on unique cores for all ``--pdump`` options. If
> +ignored, capture will be running on single core for all ``--pdump`` opti=
ons.
> +

Instead of just saying on single cores or on unique cores, worth mentioning=
  uses the 1st core of eal coremask/corelist for single case.
For multi case uses the cores except the 1st in one in coremask?=20

>  The ``--pdump`` command line option is mandatory and it takes various su=
b
> arguments which are described in  below section.


> +   $ sudo ./build/app/dpdk-pdump -l 3,4,5 -- --multi --pdump
> 'port=3D0,queue=3D*,rx-dev=3D/tmp/rx-1.pcap' --pdump 'port=3D1,queue=3D*,=
rx-
> dev=3D/tmp/rx-2.pcap'
> --
> 2.17.1

In the command if you pass anything --m/--mul/--mult/multi the command stil=
l succeeds..  Did you check the reason for that?

Thanks,
Reshma