From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 18EF0A0679
for <public@inbox.dpdk.org>; Sat, 6 Apr 2019 14:38:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 6230D3798;
Sat, 6 Apr 2019 14:38:06 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 6436B27D;
Sat, 6 Apr 2019 14:38:03 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
06 Apr 2019 05:38:01 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,316,1549958400"; d="scan'208";a="289262446"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
by orsmga004.jf.intel.com with ESMTP; 06 Apr 2019 05:38:00 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.31]) by
IRSMSX101.ger.corp.intel.com ([169.254.1.115]) with mapi id 14.03.0415.000;
Sat, 6 Apr 2019 13:37:59 +0100
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Zhang, Roy Fan"
<roy.fan.zhang@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv offset
Thread-Index: AQHU68myIlgpLgeEJUKm+nvmFaBoyKYvE34g
Date: Sat, 6 Apr 2019 12:37:58 +0000
Message-ID:
<2601191342CEEE43887BDE71AB9772580148A93C8A@irsmsx105.ger.corp.intel.com>
References: <20190405153112.60248-1-roy.fan.zhang@intel.com>
<20190405160424.39320-1-roy.fan.zhang@intel.com>
In-Reply-To: <20190405160424.39320-1-roy.fan.zhang@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjhkZDliYWEtODE2My00MWUyLTk1NDItNmY5NTY1YmIzYmJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYUxJb3VWT3p5WGRNQ2twUWlKckZWUWUyVTBTK1E2TzZFOGU2aEx2bTJ5b25sYXgycGQ3dUNPVG02Z003R1ZuTSJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv offset
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190406123758.qj0ReLwhCGZayFNhW83v55DXQQOwYLfVtr-o0lKySfY@z>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Friday, April 5, 2019 5:04 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; stable=
@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv offset
>=20
> This patch fixes the incorrect iv offset calculation.
>=20
> Fixes: b063e843fa03 ("crypto/virtio: fix IV physical address")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> v2:
> fixed a typo
>=20
> drivers/crypto/virtio/virtio_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/crypto/virtio/virtio_rxtx.c b/drivers/crypto/virtio/=
virtio_rxtx.c
> index e32a1ecd6..e9a63cb5a 100644
> --- a/drivers/crypto/virtio/virtio_rxtx.c
> +++ b/drivers/crypto/virtio/virtio_rxtx.c
> @@ -203,8 +203,8 @@ virtqueue_crypto_sym_enqueue_xmit(
> uint16_t req_data_len =3D sizeof(struct virtio_crypto_op_data_req);
> uint32_t indirect_vring_addr_offset =3D req_data_len +
> sizeof(struct virtio_crypto_inhdr);
> - uint32_t indirect_iv_addr_offset =3D indirect_vring_addr_offset +
> - sizeof(struct vring_desc) * NUM_ENTRY_VIRTIO_CRYPTO_OP;
> + uint32_t indirect_iv_addr_offset =3D
> + offsetof(struct virtio_crypto_op_cookie, iv);
> struct rte_crypto_sym_op *sym_op =3D cop->sym;
> struct virtio_crypto_session *session =3D
> (struct virtio_crypto_session *)get_sym_session_private_data(
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.14.5