DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection
@ 2019-04-06 13:29 Jerin Jacob Kollanukkaran
  2019-04-06 13:29 ` Jerin Jacob Kollanukkaran
  2019-04-08 13:37 ` Dumitrescu, Cristian
  0 siblings, 2 replies; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-04-06 13:29 UTC (permalink / raw)
  To: Cristian Dumitrescu
  Cc: dev, thomas, Jerin Jacob Kollanukkaran, Gavin Hu, stable

From: Jerin Jacob <jerinj@marvell.com>

Use CRC32 instruction only when it is available to avoid
the build issue like below.

{standard input}:16: Error:
selected processor does not support `crc32cx w3,w3,x0'

Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
Cc: Gavin Hu <gavin.hu@arm.com>
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 lib/librte_table/rte_table_hash_func.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_table/rte_table_hash_func.h b/lib/librte_table/rte_table_hash_func.h
index 02296eabe..11ea5a90e 100644
--- a/lib/librte_table/rte_table_hash_func.h
+++ b/lib/librte_table/rte_table_hash_func.h
@@ -40,7 +40,7 @@ rte_crc32_u64(uint64_t crc, uint64_t v)
 	return _mm_crc32_u64(crc, v);
 }
 
-#elif defined(RTE_ARCH_ARM64)
+#elif defined(RTE_ARCH_ARM64) && defined(RTE_MACHINE_CPUFLAG_CRC32)
 #include "rte_table_hash_func_arm64.h"
 #else
 
-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection
  2019-04-06 13:29 [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection Jerin Jacob Kollanukkaran
@ 2019-04-06 13:29 ` Jerin Jacob Kollanukkaran
  2019-04-08 13:37 ` Dumitrescu, Cristian
  1 sibling, 0 replies; 6+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-04-06 13:29 UTC (permalink / raw)
  To: Cristian Dumitrescu
  Cc: dev, thomas, Jerin Jacob Kollanukkaran, Gavin Hu, stable

From: Jerin Jacob <jerinj@marvell.com>

Use CRC32 instruction only when it is available to avoid
the build issue like below.

{standard input}:16: Error:
selected processor does not support `crc32cx w3,w3,x0'

Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
Cc: Gavin Hu <gavin.hu@arm.com>
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 lib/librte_table/rte_table_hash_func.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_table/rte_table_hash_func.h b/lib/librte_table/rte_table_hash_func.h
index 02296eabe..11ea5a90e 100644
--- a/lib/librte_table/rte_table_hash_func.h
+++ b/lib/librte_table/rte_table_hash_func.h
@@ -40,7 +40,7 @@ rte_crc32_u64(uint64_t crc, uint64_t v)
 	return _mm_crc32_u64(crc, v);
 }
 
-#elif defined(RTE_ARCH_ARM64)
+#elif defined(RTE_ARCH_ARM64) && defined(RTE_MACHINE_CPUFLAG_CRC32)
 #include "rte_table_hash_func_arm64.h"
 #else
 
-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection
  2019-04-06 13:29 [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection Jerin Jacob Kollanukkaran
  2019-04-06 13:29 ` Jerin Jacob Kollanukkaran
@ 2019-04-08 13:37 ` Dumitrescu, Cristian
  2019-04-08 13:37   ` Dumitrescu, Cristian
  2019-04-10 20:05   ` Thomas Monjalon
  1 sibling, 2 replies; 6+ messages in thread
From: Dumitrescu, Cristian @ 2019-04-08 13:37 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran; +Cc: dev, thomas, Gavin Hu, stable



> -----Original Message-----
> From: Jerin Jacob Kollanukkaran [mailto:jerinj@marvell.com]
> Sent: Saturday, April 6, 2019 2:30 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Gavin Hu <gavin.hu@arm.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function
> selection
> 
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Use CRC32 instruction only when it is available to avoid
> the build issue like below.
> 
> {standard input}:16: Error:
> selected processor does not support `crc32cx w3,w3,x0'
> 
> Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
> Cc: Gavin Hu <gavin.hu@arm.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  lib/librte_table/rte_table_hash_func.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection
  2019-04-08 13:37 ` Dumitrescu, Cristian
@ 2019-04-08 13:37   ` Dumitrescu, Cristian
  2019-04-10 20:05   ` Thomas Monjalon
  1 sibling, 0 replies; 6+ messages in thread
From: Dumitrescu, Cristian @ 2019-04-08 13:37 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran; +Cc: dev, thomas, Gavin Hu, stable



> -----Original Message-----
> From: Jerin Jacob Kollanukkaran [mailto:jerinj@marvell.com]
> Sent: Saturday, April 6, 2019 2:30 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Gavin Hu <gavin.hu@arm.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function
> selection
> 
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Use CRC32 instruction only when it is available to avoid
> the build issue like below.
> 
> {standard input}:16: Error:
> selected processor does not support `crc32cx w3,w3,x0'
> 
> Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
> Cc: Gavin Hu <gavin.hu@arm.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  lib/librte_table/rte_table_hash_func.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection
  2019-04-08 13:37 ` Dumitrescu, Cristian
  2019-04-08 13:37   ` Dumitrescu, Cristian
@ 2019-04-10 20:05   ` Thomas Monjalon
  2019-04-10 20:05     ` Thomas Monjalon
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-10 20:05 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran; +Cc: dev, Dumitrescu, Cristian, Gavin Hu, stable

> > From: Jerin Jacob <jerinj@marvell.com>
> > 
> > Use CRC32 instruction only when it is available to avoid
> > the build issue like below.
> > 
> > {standard input}:16: Error:
> > selected processor does not support `crc32cx w3,w3,x0'
> > 
> > Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
> > Cc: Gavin Hu <gavin.hu@arm.com>
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection
  2019-04-10 20:05   ` Thomas Monjalon
@ 2019-04-10 20:05     ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-10 20:05 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran; +Cc: dev, Dumitrescu, Cristian, Gavin Hu, stable

> > From: Jerin Jacob <jerinj@marvell.com>
> > 
> > Use CRC32 instruction only when it is available to avoid
> > the build issue like below.
> > 
> > {standard input}:16: Error:
> > selected processor does not support `crc32cx w3,w3,x0'
> > 
> > Fixes: ea7be0a0386e ("lib/librte_table: add hash function headers")
> > Cc: Gavin Hu <gavin.hu@arm.com>
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-04-10 20:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 13:29 [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection Jerin Jacob Kollanukkaran
2019-04-06 13:29 ` Jerin Jacob Kollanukkaran
2019-04-08 13:37 ` Dumitrescu, Cristian
2019-04-08 13:37   ` Dumitrescu, Cristian
2019-04-10 20:05   ` Thomas Monjalon
2019-04-10 20:05     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).