From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 255782C54; Mon, 8 Apr 2019 05:23:30 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 20:23:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,323,1549958400"; d="scan'208";a="147371644" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by FMSMGA003.fm.intel.com with ESMTP; 07 Apr 2019 20:23:29 -0700 Date: Mon, 8 Apr 2019 11:23:02 +0800 From: Tiwei Bie To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Zhihong Wang Message-ID: <20190408032301.GA20719@dpdk-tbie.sh.intel.com> References: <20190405134511.49066-1-bruce.richardson@intel.com> <20190405143709.50352-1-bruce.richardson@intel.com> <20190405143709.50352-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190405143709.50352-2-bruce.richardson@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 1/5] examples/vhost_scsi: fix header check for meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 03:23:31 -0000 On Fri, Apr 05, 2019 at 03:37:05PM +0100, Bruce Richardson wrote: > The header check for the example app was looking for virtio_scsi.h without > the "linux/" prefix, which meant it was never getting found when it should > have been. > > Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency") > CC: stable@dpdk.org > CC: Maxime Coquelin > CC: Tiwei Bie > CC: Zhihong Wang > > Signed-off-by: Bruce Richardson > --- > examples/vhost_scsi/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/vhost_scsi/meson.build b/examples/vhost_scsi/meson.build > index ca1248023..e00a7dab1 100644 > --- a/examples/vhost_scsi/meson.build > +++ b/examples/vhost_scsi/meson.build > @@ -10,7 +10,7 @@ if host_machine.system() != 'linux' > build = false > endif > > -if not cc.has_header('virtio_scsi.h') > +if not cc.has_header('linux/virtio_scsi.h') > build = false > endif > > -- > 2.20.1 Reviewed-by: Tiwei Bie From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4ED94A0096 for ; Mon, 8 Apr 2019 05:23:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 826EB4CA6; Mon, 8 Apr 2019 05:23:33 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 255782C54; Mon, 8 Apr 2019 05:23:30 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 20:23:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,323,1549958400"; d="scan'208";a="147371644" Received: from dpdk-tbie.sh.intel.com ([10.67.104.173]) by FMSMGA003.fm.intel.com with ESMTP; 07 Apr 2019 20:23:29 -0700 Date: Mon, 8 Apr 2019 11:23:02 +0800 From: Tiwei Bie To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Maxime Coquelin , Zhihong Wang Message-ID: <20190408032301.GA20719@dpdk-tbie.sh.intel.com> References: <20190405134511.49066-1-bruce.richardson@intel.com> <20190405143709.50352-1-bruce.richardson@intel.com> <20190405143709.50352-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190405143709.50352-2-bruce.richardson@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 1/5] examples/vhost_scsi: fix header check for meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408032302.9liFIxBDXpMbYygG0oCVph8W_J8k8oTrX0cTCJ4Nb2E@z> On Fri, Apr 05, 2019 at 03:37:05PM +0100, Bruce Richardson wrote: > The header check for the example app was looking for virtio_scsi.h without > the "linux/" prefix, which meant it was never getting found when it should > have been. > > Fixes: 8d47a753b7cb ("examples/vhost_scsi: disable build if missing dependency") > CC: stable@dpdk.org > CC: Maxime Coquelin > CC: Tiwei Bie > CC: Zhihong Wang > > Signed-off-by: Bruce Richardson > --- > examples/vhost_scsi/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/vhost_scsi/meson.build b/examples/vhost_scsi/meson.build > index ca1248023..e00a7dab1 100644 > --- a/examples/vhost_scsi/meson.build > +++ b/examples/vhost_scsi/meson.build > @@ -10,7 +10,7 @@ if host_machine.system() != 'linux' > build = false > endif > > -if not cc.has_header('virtio_scsi.h') > +if not cc.has_header('linux/virtio_scsi.h') > build = false > endif > > -- > 2.20.1 Reviewed-by: Tiwei Bie