From: Shahaf Shuler <shahafs@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix device probing for old kernel drivers
Date: Mon, 8 Apr 2019 06:00:11 +0000 [thread overview]
Message-ID: <AM0PR0502MB37955667C9DBF4E107E41AC4C32C0@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
Message-ID: <20190408060011.F-afDpZiTDgCl6D2OTiLXtnEHlgCaYu_S0ohd6SnjDo@z> (raw)
In-Reply-To: <1554470755-14183-1-git-send-email-viacheslavo@mellanox.com>
Friday, April 5, 2019 4:26 PM, Viacheslav Ovsiienko:
> Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix device probing for old
> kernel drivers
>
> Retrieving network interface index via Netlink fails in case of old ib_core
> kernel driver installed - mlx5_nl_ifindex() routine fails due to
> RDMA_NLDEV_ATTR_NDEV_INDEX attribute is not supported by the old
> driver.
>
> The patch allowing to retrieve the network interface index and name via
> Netlink [1]. So, the problem depends on ib_core module version - 4.16
> supports getting ifindex via Netlink, 4.15 does not.
>
> This error was ignored in previous versions of MLX5 PMD probing routine. For
> single device ifindex was retrieved via sysfs and link control was not lost, so
> problem just was not noticed.
> In order to support MLX5 PMD functioning over old kernel driver this patch
> adds ifindex retrieving via sysfs into probing routine.
> It is worth to note this method works for master/standalone device only.
>
> [1]
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww
> .spinics.net%2Flists%2Flinux-
> rdma%2Fmsg62948.html&data=02%7C01%7Cshahafs%40mellanox.com
> %7C0968f75813714ee221ac08d6b9ca45ea%7Ca652971c7d2e4d9ba6a4d149256
> f461b%7C0%7C0%7C636900675741983483&sdata=ONhYWfZ7Y4zEOunEd
> wx9H0zyOiFIyzHDxnw7MXtTIAk%3D&reserved=0
> Linux tree: 5b2cc79d (Leon Romanovsky 2018-03-27 20:40:49 +0300 270)
>
> Fixes: ad74bc619504 ("net/mlx5: support multiport IB device during probing")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Applied to next-net-mlx, thanks.
next prev parent reply other threads:[~2019-04-08 6:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 14:14 [dpdk-dev] [PATCH " Viacheslav Ovsiienko
2019-04-03 14:14 ` Viacheslav Ovsiienko
2019-04-04 19:06 ` David Christensen
2019-04-04 19:06 ` David Christensen
2019-04-05 9:37 ` Slava Ovsiienko
2019-04-05 9:37 ` Slava Ovsiienko
2019-04-05 12:49 ` Slava Ovsiienko
2019-04-05 12:49 ` Slava Ovsiienko
2019-04-05 13:25 ` [dpdk-dev] [PATCH v2 " Viacheslav Ovsiienko
2019-04-05 13:25 ` Viacheslav Ovsiienko
2019-04-08 6:00 ` Shahaf Shuler [this message]
2019-04-08 6:00 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB37955667C9DBF4E107E41AC4C32C0@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).