From: Jens Freimann <jfreimann@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, stable@dpdk.org, maxime.coquelin@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2] virtio: fix buffer leak on vlan insert
Date: Mon, 8 Apr 2019 11:21:57 +0200 [thread overview]
Message-ID: <20190408092157.6d452opyioqp5fkd@jenstp.localdomain> (raw)
Message-ID: <20190408092157.JaOKN3Hr4u9a2lW1IcsWYPsub2aYBPMEEDphSFlSBEw@z> (raw)
In-Reply-To: <20190405163115.5068-1-stephen@networkplumber.org>
On Fri, Apr 05, 2019 at 09:31:15AM -0700, Stephen Hemminger wrote:
>The function rte_vlan_insert may allocate a new buffer for the
>vlan header and return a different mbuf than originally passed.
>In this case, the stored mbuf in txm[] array could point to wrong
>buffer.
>
>Fixes: dd856dfcb9e7 ("virtio: use any layout on Tx")
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
>v2 - catch a couple more places.
> The virtio code needs some refactoring to not have 3 copies of same
> loop...
>
> drivers/net/virtio/virtio_rxtx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Added stable@ back to Cc list as it was for v1.
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
next prev parent reply other threads:[~2019-04-08 9:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 0:03 [dpdk-dev] [PATCH] " Stephen Hemminger
2019-04-05 0:03 ` Stephen Hemminger
2019-04-05 7:43 ` Jens Freimann
2019-04-05 7:43 ` Jens Freimann
2019-04-05 16:31 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-04-05 16:31 ` Stephen Hemminger
2019-04-08 9:21 ` Jens Freimann [this message]
2019-04-08 9:21 ` Jens Freimann
2019-04-17 7:16 ` Maxime Coquelin
2019-04-17 7:16 ` Maxime Coquelin
2019-04-17 7:56 ` Maxime Coquelin
2019-04-17 7:56 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408092157.6d452opyioqp5fkd@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).