From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: dev@dpdk.org
Cc: stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/nfp: fix resource leak
Date: Mon, 8 Apr 2019 11:49:39 +0100 [thread overview]
Message-ID: <20190408104939.22902-1-alejandro.lucero@netronome.com> (raw)
Message-ID: <20190408104939.jS8Hg6BoiCqIS2FB7UTZUkIBGDdyzD1mQBLtTHP0Xpk@z> (raw)
Coverity issue: 32806
Fixes: ef28aa96e53b ("net/nfp: support multiprocess")
Cc: stable@dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index 33baa989b..0b9db974e 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -690,12 +690,16 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
lockfile = calloc(strlen(home_path) + strlen(lockname) + 1,
sizeof(char));
+ if (!lockfile)
+ return -ENOMEM;
+
strcat(lockfile, home_path);
strcat(lockfile, "/.lock_nfp_secondary");
desc->secondary_lock = open(lockfile, O_RDWR | O_CREAT | O_NONBLOCK,
0666);
if (desc->secondary_lock < 0) {
RTE_LOG(ERR, PMD, "NFP lock for secondary process failed\n");
+ free(lockfile);
return desc->secondary_lock;
}
@@ -707,6 +711,7 @@ nfp_acquire_secondary_process_lock(struct nfp_pcie_user *desc)
close(desc->secondary_lock);
}
+ free(lockfile);
return rc;
}
--
2.17.1
next reply other threads:[~2019-04-08 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 10:49 Alejandro Lucero [this message]
2019-04-08 10:49 ` Alejandro Lucero
2019-04-08 16:50 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-08 16:50 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2017-11-08 12:14 [dpdk-dev] " Alejandro Lucero
2017-11-10 9:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408104939.22902-1-alejandro.lucero@netronome.com \
--to=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).