From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id A8D91A0096
	for <public@inbox.dpdk.org>; Mon,  8 Apr 2019 15:29:23 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1BC122BD8;
	Mon,  8 Apr 2019 15:29:22 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id F36D62BCE
 for <dev@dpdk.org>; Mon,  8 Apr 2019 15:29:19 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 08 Apr 2019 06:29:19 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,325,1549958400"; d="scan'208";a="140928721"
Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59])
 by orsmga003.jf.intel.com with ESMTP; 08 Apr 2019 06:29:17 -0700
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Mon, 8 Apr 2019 14:29:16 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.82]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.85]) with mapi id 14.03.0415.000;
 Mon, 8 Apr 2019 14:29:16 +0100
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Alan Dewar
 <alangordondewar@gmail.com>
CC: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Kantecki, Tomasz"
 <tomasz.kantecki@intel.com>, Stephen Hemminger <stephen@networkplumber.org>,
 "dev@dpdk.org" <dev@dpdk.org>, Alan Dewar <alan.dewar@att.com>
Thread-Topic: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable
Thread-Index: AQHU68VWuD8xAnE3ZEmfv9/74qG4naYx4KmAgAAIBgCAAF0JgA==
Date: Mon, 8 Apr 2019 13:29:15 +0000
Message-ID:
 <3EB4FA525960D640B5BDFFD6A3D891268E87276A@IRSMSX108.ger.corp.intel.com>
References: <1516032969-23894-1-git-send-email-alan.dewar@att.com>
 <cffdd4b0-a4c6-8f5e-8715-f699ab5aa84c@intel.com>
 <CAOEQf6hjC7X0M6+97ba6SC7xhyW0UqgsEQjgfFFs6nca5Z5o1g@mail.gmail.com>
 <2596922.ozHIldrUZQ@xps>
In-Reply-To: <2596922.ozHIldrUZQ@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzRmZTNiYTQtNTlkYi00ZWNiLTlkMTctZWJjMWZmMTNkZmUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQkZHNDBlMkFMVW5IRExRTllKVlozNnVId3JDa04zSHhaWlNoM1Uxa2pHN1BRM1p2WU5LcWtxRDdmNVBJZFpmcyJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190408132915.6UolzVW0ea9awzIVS2-iKP17_Atf6KxUKJlOGyQUA-M@z>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, April 8, 2019 9:53 AM
> To: Alan Dewar <alangordondewar@gmail.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Kantecki, Tomasz
> <tomasz.kantecki@intel.com>; Stephen Hemminger
> <stephen@networkplumber.org>; dev@dpdk.org; Alan Dewar
> <alan.dewar@att.com>
> Subject: Re: [dpdk-dev] [PATCH v7] sched: make RED scaling configurable
>=20
> 08/04/2019 10:24, Alan Dewar:
> > On Fri, Apr 5, 2019 at 4:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wr=
ote:
> > > On 1/16/2018 4:07 PM, alangordondewar@gmail.com wrote:
> > > > From: Alan Dewar <alan.dewar@att.com>
> > > >
> > > > The RED code stores the weighted moving average in a 32-bit integer=
 as
> > > > a pseudo fixed-point floating number with 10 fractional bits.  Twel=
ve
> > > > other bits are used to encode the filter weight, leaving just 10 bi=
ts
> > > > for the queue length.  This limits the maximum queue length support=
ed
> > > > by RED queues to 1024 packets.
> > > >
> > > > Introduce a new API to allow the RED scaling factor to be configure=
d
> > > > based upon maximum queue length.  If this API is not called, the RE=
D
> > > > scaling factor remains at its default value.
> > > >
> > > > Added some new RED scaling unit-tests to test with RED queue-length=
s
> > > > up to 8192 packets long.
> > > >
> > > > Signed-off-by: Alan Dewar <alan.dewar@att.com>
> > >
> > > Hi Cristian, Alan,
> > >
> > > The v7 of this patch is sting without any comment for more than a yea=
r.
> > > What is the status of this patch? Is it still valid? What is blocking=
 it?
> > >
> > > For reference patch:
> > > https://patches.dpdk.org/patch/33837/
> >
> > We are still using this patch against DPDK 17.11 and 18.11 as part of
> > the AT&T Vyatta NOS.   It is needed to make WRED queues longer than
> > 1024 packets work correctly.  I'm afraid that I have no idea what is
> > holding it up from being merged.
>=20
> It will be in a release when it will be merged in the git tree
> dpdk-next-qos, managed by Cristian.
>=20

I was hoping to get a review & ACK from Tomasz Kantecki, the author of the =
WRED code in DPDK, hence the lack of progress on this patch.