From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 02CC24CA6; Mon, 8 Apr 2019 22:00:40 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 13:00:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,326,1549958400"; d="scan'208";a="162511230" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.86.32]) by fmsmga001.fm.intel.com with SMTP; 08 Apr 2019 13:00:37 -0700 Received: by (sSMTP sendmail emulation); Mon, 08 Apr 2019 21:00:36 +0100 Date: Mon, 8 Apr 2019 21:00:35 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> References: <20190408142226.88179-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190408142226.88179-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 20:00:41 -0000 On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote: > Build error seen with Linux kernel 5.1 and > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > Build error: > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: > error: initialization of ... from incompatible pointer type ... > [-Werror=incompatible-pointer-types] > .ndo_fdb_add = igb_ndo_fdb_add, > ^~~~~~~~~~~~~~~ > > ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires > a new parameter, 'struct netlink_ext_ack *extack': > Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()") > > ndo_fdb_add() parameter updated with compile time Linux kernel version > check. > > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- Thanks, Ferruh. This allows my builds to start passing again on bleeding-edge kernels. Tested-by: Bruce Richardson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CD5A0A0096 for ; Mon, 8 Apr 2019 22:00:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 126BE4CA9; Mon, 8 Apr 2019 22:00:43 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 02CC24CA6; Mon, 8 Apr 2019 22:00:40 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 13:00:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,326,1549958400"; d="scan'208";a="162511230" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.86.32]) by fmsmga001.fm.intel.com with SMTP; 08 Apr 2019 13:00:37 -0700 Received: by (sSMTP sendmail emulation); Mon, 08 Apr 2019 21:00:36 +0100 Date: Mon, 8 Apr 2019 21:00:35 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20190408200035.GA1146@bricha3-MOBL.ger.corp.intel.com> References: <20190408142226.88179-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190408142226.88179-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] kni: fix build for ndo_fdb_add in Linux 5.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408200035.mDmcDYLcF3LIm5Tsrw-ysleSyjmPfoYlHrqu_Ho8-WI@z> On Mon, Apr 08, 2019 at 03:22:26PM +0100, Ferruh Yigit wrote: > Build error seen with Linux kernel 5.1 and > when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > Build error: > .../dpdk/build/build/kernel/linux/kni/igb_main.c:2352:18: > error: initialization of ... from incompatible pointer type ... > [-Werror=incompatible-pointer-types] > .ndo_fdb_add = igb_ndo_fdb_add, > ^~~~~~~~~~~~~~~ > > ndo_fdb_add() is changed in Linux kernel version 5.1 and now requires > a new parameter, 'struct netlink_ext_ack *extack': > Linux Commit 87b0984ebfab ("net: Add extack argument to ndo_fdb_add()") > > ndo_fdb_add() parameter updated with compile time Linux kernel version > check. > > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- Thanks, Ferruh. This allows my builds to start passing again on bleeding-edge kernels. Tested-by: Bruce Richardson