From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7889AA0096 for ; Mon, 8 Apr 2019 22:40:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8C3C4CA6; Mon, 8 Apr 2019 22:40:52 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1756F3572 for ; Mon, 8 Apr 2019 22:40:51 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 53F7830842AC; Mon, 8 Apr 2019 20:40:50 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 71F261A7CD; Mon, 8 Apr 2019 20:40:48 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Cc: Konstantin Ananyev , Jerin Jacob , Gavin Hu , David Marchand References: <20190408182420.4398-1-aconole@redhat.com> Date: Mon, 08 Apr 2019 16:40:48 -0400 In-Reply-To: <20190408182420.4398-1-aconole@redhat.com> (Aaron Conole's message of "Mon, 8 Apr 2019 14:24:17 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Mon, 08 Apr 2019 20:40:50 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 0/3] librte_acl: fixes related to testing with the meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408204048.jH8kVCP7Cd8enOclNPUYX3z9LhkkHdouwOcIck0eyko@z> Aaron Conole writes: > This series fixes the following conditions in the RTE_ACL library: > > 1. Fix outstanding compilation issues on ARM with the NEON optimized code > These consisted mostly of compiler type-cast warnings. Additionally, some > of the vector code didn't initialize memory properly. > > 2. Properly include ARM, and PPC objects when building on those platforms > During the meson port, only the scalar code, and some of the x86_64 code was > ported. > > 3. Allow the unit tests to pass > In order to support this, the unsupported symbols were moved to a separate > file, which was needed to prevent the compiler from inlining references to the > functions (resulting in non-scalar code always falling into the -ENOTSUP case). > > The tests were modified to primarily test the scalar version - a better system > for exercising the non-scalar code needs to be developed. > > Aaron Conole (3): > acl: fix arm argument types > acl: update the build for multi-arch > acl: adjust the tests > > app/test/test_acl.c | 62 +++++++++++++-------------------- > lib/librte_acl/Makefile | 1 + > lib/librte_acl/acl_run_neon.h | 46 ++++++++++++++---------- > lib/librte_acl/acl_run_notsup.c | 46 ++++++++++++++++++++++++ > lib/librte_acl/meson.build | 9 +++-- > 5 files changed, 104 insertions(+), 60 deletions(-) > create mode 100644 lib/librte_acl/acl_run_notsup.c Might have sent prematurely - please ignore for the time being.