From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 4/5] app/test: use lcore accessor functions
Date: Tue, 9 Apr 2019 09:43:40 +0200 [thread overview]
Message-ID: <CAJFAV8wf3PSqThXOQLo14RM8+dV3NAtZ+TxM+bsbW=kipC_B2w@mail.gmail.com> (raw)
Message-ID: <20190409074340.B67yUjf8njd7uzZWWCAXW2BORxq5JHahpPL8N44eCP8@z> (raw)
In-Reply-To: <20190408182510.16078-5-stephen@networkplumber.org>
On Mon, Apr 8, 2019 at 8:26 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:
> Use the new accessor functions. Don't refer to lcore_config directly.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> app/test/test_cryptodev.c | 2 +-
> app/test/test_hash_readwrite_lf.c | 14 +++++++-------
> app/test/test_ring_perf.c | 22 ++++++++++++----------
> app/test/test_stack_perf.c | 20 ++++++++++----------
> 4 files changed, 30 insertions(+), 28 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 9f31aaa7e6b2..eca6d3db16a5 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -378,7 +378,7 @@ testsuite_setup(void)
> strcpy(temp_str, vdev_args);
> strlcat(temp_str, ";", sizeof(temp_str));
> slave_core_count++;
> - socket_id = lcore_config[i].socket_id;
> + socket_id = rte_lcore_to_socket_id(i);
> }
> if (slave_core_count != 2) {
> RTE_LOG(ERR, USER1,
> diff --git a/app/test/test_hash_readwrite_lf.c
> b/app/test/test_hash_readwrite_lf.c
> index 4ab4c8ee64cf..1361a8aa4c9c 100644
> --- a/app/test/test_hash_readwrite_lf.c
> +++ b/app/test/test_hash_readwrite_lf.c
> @@ -741,7 +741,7 @@ test_hash_add_no_ks_lookup_hit(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
> rte_eal_mp_wait_lcore();
>
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_lcore_return_code(i) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> @@ -813,7 +813,7 @@ test_hash_add_no_ks_lookup_miss(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
> if (ret < 0)
> goto err;
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_lcore_return_code(i) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> @@ -889,7 +889,7 @@ test_hash_add_ks_lookup_hit_non_sp(struct rwc_perf
> *rwc_perf_results,
> if (ret < 0)
> goto err;
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_lcore_return_code(i) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> @@ -965,7 +965,7 @@ test_hash_add_ks_lookup_hit_sp(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
> if (ret < 0)
> goto err;
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_lcore_return_code(i) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> @@ -1040,7 +1040,7 @@ test_hash_add_ks_lookup_miss(struct rwc_perf
> *rwc_perf_results, int rwc_lf, int
> if (ret < 0)
> goto err;
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_lcore_return_code(i) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> @@ -1141,7 +1141,7 @@ test_hash_multi_add_lookup(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
> rte_eal_mp_wait_lcore();
>
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_lcore_return_code(i) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> @@ -1225,7 +1225,7 @@ test_hash_add_ks_lookup_hit_extbkt(struct rwc_perf
> *rwc_perf_results,
> rte_eal_mp_wait_lcore();
>
> for (i = 1; i <= rwc_core_cnt[n]; i++)
> - if (lcore_config[i].ret < 0)
> + if (rte_lcore_return_code(i) < 0)
> goto err;
>
> unsigned long long cycles_per_lookup =
> diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c
> index ebb3939f51d0..6eccccfe93b4 100644
> --- a/app/test/test_ring_perf.c
> +++ b/app/test/test_ring_perf.c
> @@ -52,10 +52,11 @@ get_two_hyperthreads(struct lcore_pair *lcp)
> RTE_LCORE_FOREACH(id2) {
> if (id1 == id2)
> continue;
> - c1 = lcore_config[id1].core_id;
> - c2 = lcore_config[id2].core_id;
> - s1 = lcore_config[id1].socket_id;
> - s2 = lcore_config[id2].socket_id;
> +
> + c1 = rte_lcore_to_cpu_id(id1);
> + c2 = rte_lcore_to_cpu_id(id2);
> + s1 = rte_lcore_to_socket_id(id1);
> + s2 = rte_lcore_to_socket_id(id2);
> if ((c1 == c2) && (s1 == s2)){
> lcp->c1 = id1;
> lcp->c2 = id2;
> @@ -75,10 +76,11 @@ get_two_cores(struct lcore_pair *lcp)
> RTE_LCORE_FOREACH(id2) {
> if (id1 == id2)
> continue;
> - c1 = lcore_config[id1].core_id;
> - c2 = lcore_config[id2].core_id;
> - s1 = lcore_config[id1].socket_id;
> - s2 = lcore_config[id2].socket_id;
> +
> + c1 = rte_lcore_to_cpu_id(id1);
> + c2 = rte_lcore_to_cpu_id(id2);
> + s1 = rte_lcore_to_socket_id(id1);
> + s2 = rte_lcore_to_socket_id(id2);
> if ((c1 != c2) && (s1 == s2)){
> lcp->c1 = id1;
> lcp->c2 = id2;
> @@ -98,8 +100,8 @@ get_two_sockets(struct lcore_pair *lcp)
> RTE_LCORE_FOREACH(id2) {
> if (id1 == id2)
> continue;
> - s1 = lcore_config[id1].socket_id;
> - s2 = lcore_config[id2].socket_id;
> + s1 = rte_lcore_to_socket_id(id1);
> + s2 = rte_lcore_to_socket_id(id2);
> if (s1 != s2){
> lcp->c1 = id1;
> lcp->c2 = id2;
> diff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c
> index ba27fbf7076d..70561fecda0d 100644
> --- a/app/test/test_stack_perf.c
> +++ b/app/test/test_stack_perf.c
> @@ -44,10 +44,10 @@ get_two_hyperthreads(struct lcore_pair *lcp)
> RTE_LCORE_FOREACH(id[1]) {
> if (id[0] == id[1])
> continue;
> - core[0] = lcore_config[id[0]].core_id;
> - core[1] = lcore_config[id[1]].core_id;
> - socket[0] = lcore_config[id[0]].socket_id;
> - socket[1] = lcore_config[id[1]].socket_id;
> + core[0] = rte_lcore_to_cpu_id(id[0]);
> + core[1] = rte_lcore_to_cpu_id(id[1]);
> + socket[0] = rte_lcore_to_socket_id(id[0]);
> + socket[1] = rte_lcore_to_socket_id(id[1]);
> if ((core[0] == core[1]) && (socket[0] ==
> socket[1])) {
> lcp->c1 = id[0];
> lcp->c2 = id[1];
> @@ -70,10 +70,10 @@ get_two_cores(struct lcore_pair *lcp)
> RTE_LCORE_FOREACH(id[1]) {
> if (id[0] == id[1])
> continue;
> - core[0] = lcore_config[id[0]].core_id;
> - core[1] = lcore_config[id[1]].core_id;
> - socket[0] = lcore_config[id[0]].socket_id;
> - socket[1] = lcore_config[id[1]].socket_id;
> + core[0] = rte_lcore_to_cpu_id(id[0]);
> + core[1] = rte_lcore_to_cpu_id(id[1]);
> + socket[0] = rte_lcore_to_socket_id(id[0]);
> + socket[1] = rte_lcore_to_socket_id(id[1]);
> if ((core[0] != core[1]) && (socket[0] ==
> socket[1])) {
> lcp->c1 = id[0];
> lcp->c2 = id[1];
> @@ -95,8 +95,8 @@ get_two_sockets(struct lcore_pair *lcp)
> RTE_LCORE_FOREACH(id[1]) {
> if (id[0] == id[1])
> continue;
> - socket[0] = lcore_config[id[0]].socket_id;
> - socket[1] = lcore_config[id[1]].socket_id;
> + socket[0] = rte_lcore_to_socket_id(id[0]);
> + socket[1] = rte_lcore_to_socket_id(id[1]);
> if (socket[0] != socket[1]) {
> lcp->c1 = id[0];
> lcp->c2 = id[1];
> --
> 2.17.1
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-04-09 7:43 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 18:25 [dpdk-dev] [PATCH v1 0/5] make lcore_config internal Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 1/5] eal: add accessor functions for lcore_config Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 2/5] bus: use lcore accessor functions Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 3/5] examples/bond: use lcore accessor Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 4/5] app/test: use lcore accessor functions Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-09 7:43 ` David Marchand [this message]
2019-04-09 7:43 ` David Marchand
2019-04-08 18:25 ` [dpdk-dev] [PATCH v1 5/5] eal: make lcore_config private Stephen Hemminger
2019-04-08 18:25 ` Stephen Hemminger
2019-04-10 17:15 ` [dpdk-dev] [PATCH v2 0/5] make lcore_config internal Stephen Hemminger
2019-04-10 17:15 ` Stephen Hemminger
2019-04-10 17:15 ` [dpdk-dev] [PATCH v2 1/5] eal: use unsigned int in rte_lcore.h functions Stephen Hemminger
2019-04-10 17:15 ` Stephen Hemminger
2019-05-03 7:24 ` David Marchand
2019-05-03 7:24 ` David Marchand
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 2/5] eal: add accessor functions for lcore_config Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-04-16 17:03 ` Jerin Jacob Kollanukkaran
2019-04-16 17:03 ` Jerin Jacob Kollanukkaran
2019-04-30 20:53 ` Stephen Hemminger
2019-04-30 20:53 ` Stephen Hemminger
2019-05-01 2:12 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-05-01 2:12 ` Jerin Jacob Kollanukkaran
2019-05-03 7:22 ` [dpdk-dev] " David Marchand
2019-05-03 7:22 ` David Marchand
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 3/5] bus: use lcore accessor functions Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 4/5] examples/bond: use lcore accessor Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-05-03 7:29 ` David Marchand
2019-05-03 7:29 ` David Marchand
2019-04-10 17:16 ` [dpdk-dev] [PATCH v2 5/5] app/test: use lcore accessor functions Stephen Hemminger
2019-04-10 17:16 ` Stephen Hemminger
2019-05-02 23:15 ` [dpdk-dev] [PATCH v2 0/5] make lcore_config internal Stephen Hemminger
2019-05-02 23:15 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 1/5] eal: use unsigned int in rte_lcore.h functions Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 2/5] eal: add accessor functions for lcore_config Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 3/5] bus: use lcore accessor functions Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 4/5] examples/bond: use lcore accessor Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-03 17:25 ` [dpdk-dev] [PATCH v3 5/5] app/test: use lcore accessor functions Stephen Hemminger
2019-05-03 17:25 ` Stephen Hemminger
2019-05-06 7:20 ` [dpdk-dev] [PATCH v3 0/5] prepare to make lcore_config not visible in ABI David Marchand
2019-05-06 7:20 ` David Marchand
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 0/5] make lcore_config internal David Marchand
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 1/5] eal: use unsigned int in lcore API prototypes David Marchand
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 2/5] eal: add lcore accessors David Marchand
2019-05-29 22:46 ` Thomas Monjalon
2019-05-29 22:51 ` Stephen Hemminger
2019-05-30 7:31 ` David Marchand
2019-05-30 7:40 ` Thomas Monjalon
2019-05-30 10:11 ` Bruce Richardson
2019-05-30 13:39 ` Thomas Monjalon
2019-05-30 17:00 ` David Marchand
2019-05-30 20:08 ` Bruce Richardson
2019-05-23 13:58 ` [dpdk-dev] [PATCH v4 3/5] drivers/bus: use " David Marchand
2019-05-23 13:59 ` [dpdk-dev] [PATCH v4 4/5] examples/bond: " David Marchand
2019-05-23 13:59 ` [dpdk-dev] [PATCH v4 5/5] test: " David Marchand
2019-05-23 15:14 ` [dpdk-dev] [PATCH v4 0/5] make lcore_config internal Stephen Hemminger
2019-05-31 15:36 ` [dpdk-dev] [PATCH v5 " David Marchand
2019-05-31 15:36 ` [dpdk-dev] [PATCH v5 1/5] eal: use unsigned int in lcore API prototypes David Marchand
2019-05-31 15:36 ` [dpdk-dev] [PATCH v5 2/5] eal: add lcore accessors David Marchand
2019-05-31 15:37 ` [dpdk-dev] [PATCH v5 3/5] drivers/bus: use " David Marchand
2019-05-31 15:37 ` [dpdk-dev] [PATCH v5 4/5] examples/bond: " David Marchand
2019-05-31 15:37 ` [dpdk-dev] [PATCH v5 5/5] test: " David Marchand
2019-06-04 15:11 ` Eads, Gage
2019-06-03 10:32 ` [dpdk-dev] [PATCH v5 0/5] make lcore_config internal Thomas Monjalon
2019-06-03 20:15 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wf3PSqThXOQLo14RM8+dV3NAtZ+TxM+bsbW=kipC_B2w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).