From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 87A66A0096
	for <public@inbox.dpdk.org>; Tue,  9 Apr 2019 09:43:54 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1F468568A;
	Tue,  9 Apr 2019 09:43:54 +0200 (CEST)
Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com
 [209.85.217.54]) by dpdk.org (Postfix) with ESMTP id 5637F5681
 for <dev@dpdk.org>; Tue,  9 Apr 2019 09:43:52 +0200 (CEST)
Received: by mail-vs1-f54.google.com with SMTP id e2so9207296vsc.13
 for <dev@dpdk.org>; Tue, 09 Apr 2019 00:43:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=wPxGRcDcs2q6XD5Z7cqANouxdlxl/lgfh+tgIjfA/KA=;
 b=A3GfqSYhAlsP0QjAg35HJfUJxHSvQ0Uq3+O8LoG4cvOBf+MrNaG7LnS+eXyoH5Kjq4
 pmOsdjam6Pz3n/k2Me9wx2W4JlR8UoCvx3+k8xdgVfw69mY0OezCPVWjrTVtOt7FQ/DZ
 CtBQsYB8DMeweOqCxT1o1kozIc0NievF3ncQ5iVgYVYmR7IZS/+GzHcebGQTmv3EpWnF
 R5nZFYuDbdUKAG8I7BWigFOFiwF7Zgg0U0tfq/RO8yb6Yh0VqexvM8eGb01BFGjU0L/9
 5m1Aaof7Q0tv6DT1Bvw7IVYY2BOdmI7Cl4FsHNQ32oA3zO35kUmi0bWyY4zJAS0W4LGX
 WgeA==
X-Gm-Message-State: APjAAAW2fJ+7jECDZkfrJneYzr7iJUDkhp8o2RJegkEah3Gfah/dp5DH
 FxOW6FPApkHtlLQoOf9KSMcLG7c1y6vUsbNMLcwR50+6
X-Google-Smtp-Source: APXvYqzr5ikCwmgYi7Vix3rQnyJii8v5IMTbN7+qofV/C7DU3fN5D8XnqJgvSd35+OpY0mQRj39/1eQPP7r1lT2romc=
X-Received: by 2002:a67:f588:: with SMTP id i8mr15826570vso.91.1554795831751; 
 Tue, 09 Apr 2019 00:43:51 -0700 (PDT)
MIME-Version: 1.0
References: <20190408182510.16078-1-stephen@networkplumber.org>
 <20190408182510.16078-5-stephen@networkplumber.org>
In-Reply-To: <20190408182510.16078-5-stephen@networkplumber.org>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 9 Apr 2019 09:43:40 +0200
Message-ID:
 <CAJFAV8wf3PSqThXOQLo14RM8+dV3NAtZ+TxM+bsbW=kipC_B2w@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v1 4/5] app/test: use lcore accessor functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190409074340.B67yUjf8njd7uzZWWCAXW2BORxq5JHahpPL8N44eCP8@z>

On Mon, Apr 8, 2019 at 8:26 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:

> Use the new accessor functions.  Don't refer to lcore_config directly.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test/test_cryptodev.c         |  2 +-
>  app/test/test_hash_readwrite_lf.c | 14 +++++++-------
>  app/test/test_ring_perf.c         | 22 ++++++++++++----------
>  app/test/test_stack_perf.c        | 20 ++++++++++----------
>  4 files changed, 30 insertions(+), 28 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 9f31aaa7e6b2..eca6d3db16a5 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -378,7 +378,7 @@ testsuite_setup(void)
>                         strcpy(temp_str, vdev_args);
>                         strlcat(temp_str, ";", sizeof(temp_str));
>                         slave_core_count++;
> -                       socket_id = lcore_config[i].socket_id;
> +                       socket_id = rte_lcore_to_socket_id(i);
>                 }
>                 if (slave_core_count != 2) {
>                         RTE_LOG(ERR, USER1,
> diff --git a/app/test/test_hash_readwrite_lf.c
> b/app/test/test_hash_readwrite_lf.c
> index 4ab4c8ee64cf..1361a8aa4c9c 100644
> --- a/app/test/test_hash_readwrite_lf.c
> +++ b/app/test/test_hash_readwrite_lf.c
> @@ -741,7 +741,7 @@ test_hash_add_no_ks_lookup_hit(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
>                         rte_eal_mp_wait_lcore();
>
>                         for (i = 1; i <= rwc_core_cnt[n]; i++)
> -                               if (lcore_config[i].ret < 0)
> +                               if (rte_lcore_return_code(i) < 0)
>                                         goto err;
>
>                         unsigned long long cycles_per_lookup =
> @@ -813,7 +813,7 @@ test_hash_add_no_ks_lookup_miss(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
>                         if (ret < 0)
>                                 goto err;
>                         for (i = 1; i <= rwc_core_cnt[n]; i++)
> -                               if (lcore_config[i].ret < 0)
> +                               if (rte_lcore_return_code(i) < 0)
>                                         goto err;
>
>                         unsigned long long cycles_per_lookup =
> @@ -889,7 +889,7 @@ test_hash_add_ks_lookup_hit_non_sp(struct rwc_perf
> *rwc_perf_results,
>                         if (ret < 0)
>                                 goto err;
>                         for (i = 1; i <= rwc_core_cnt[n]; i++)
> -                               if (lcore_config[i].ret < 0)
> +                               if (rte_lcore_return_code(i) < 0)
>                                         goto err;
>
>                         unsigned long long cycles_per_lookup =
> @@ -965,7 +965,7 @@ test_hash_add_ks_lookup_hit_sp(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
>                         if (ret < 0)
>                                 goto err;
>                         for (i = 1; i <= rwc_core_cnt[n]; i++)
> -                               if (lcore_config[i].ret < 0)
> +                               if (rte_lcore_return_code(i) < 0)
>                                         goto err;
>
>                         unsigned long long cycles_per_lookup =
> @@ -1040,7 +1040,7 @@ test_hash_add_ks_lookup_miss(struct rwc_perf
> *rwc_perf_results, int rwc_lf, int
>                         if (ret < 0)
>                                 goto err;
>                         for (i = 1; i <= rwc_core_cnt[n]; i++)
> -                               if (lcore_config[i].ret < 0)
> +                               if (rte_lcore_return_code(i) < 0)
>                                         goto err;
>
>                         unsigned long long cycles_per_lookup =
> @@ -1141,7 +1141,7 @@ test_hash_multi_add_lookup(struct rwc_perf
> *rwc_perf_results, int rwc_lf,
>                                 rte_eal_mp_wait_lcore();
>
>                                 for (i = 1; i <= rwc_core_cnt[n]; i++)
> -                                       if (lcore_config[i].ret < 0)
> +                                       if (rte_lcore_return_code(i) < 0)
>                                                 goto err;
>
>                                 unsigned long long cycles_per_lookup =
> @@ -1225,7 +1225,7 @@ test_hash_add_ks_lookup_hit_extbkt(struct rwc_perf
> *rwc_perf_results,
>                         rte_eal_mp_wait_lcore();
>
>                         for (i = 1; i <= rwc_core_cnt[n]; i++)
> -                               if (lcore_config[i].ret < 0)
> +                               if (rte_lcore_return_code(i) < 0)
>                                         goto err;
>
>                         unsigned long long cycles_per_lookup =
> diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c
> index ebb3939f51d0..6eccccfe93b4 100644
> --- a/app/test/test_ring_perf.c
> +++ b/app/test/test_ring_perf.c
> @@ -52,10 +52,11 @@ get_two_hyperthreads(struct lcore_pair *lcp)
>                 RTE_LCORE_FOREACH(id2) {
>                         if (id1 == id2)
>                                 continue;
> -                       c1 = lcore_config[id1].core_id;
> -                       c2 = lcore_config[id2].core_id;
> -                       s1 = lcore_config[id1].socket_id;
> -                       s2 = lcore_config[id2].socket_id;
> +
> +                       c1 = rte_lcore_to_cpu_id(id1);
> +                       c2 = rte_lcore_to_cpu_id(id2);
> +                       s1 = rte_lcore_to_socket_id(id1);
> +                       s2 = rte_lcore_to_socket_id(id2);
>                         if ((c1 == c2) && (s1 == s2)){
>                                 lcp->c1 = id1;
>                                 lcp->c2 = id2;
> @@ -75,10 +76,11 @@ get_two_cores(struct lcore_pair *lcp)
>                 RTE_LCORE_FOREACH(id2) {
>                         if (id1 == id2)
>                                 continue;
> -                       c1 = lcore_config[id1].core_id;
> -                       c2 = lcore_config[id2].core_id;
> -                       s1 = lcore_config[id1].socket_id;
> -                       s2 = lcore_config[id2].socket_id;
> +
> +                       c1 = rte_lcore_to_cpu_id(id1);
> +                       c2 = rte_lcore_to_cpu_id(id2);
> +                       s1 = rte_lcore_to_socket_id(id1);
> +                       s2 = rte_lcore_to_socket_id(id2);
>                         if ((c1 != c2) && (s1 == s2)){
>                                 lcp->c1 = id1;
>                                 lcp->c2 = id2;
> @@ -98,8 +100,8 @@ get_two_sockets(struct lcore_pair *lcp)
>                 RTE_LCORE_FOREACH(id2) {
>                         if (id1 == id2)
>                                 continue;
> -                       s1 = lcore_config[id1].socket_id;
> -                       s2 = lcore_config[id2].socket_id;
> +                       s1 = rte_lcore_to_socket_id(id1);
> +                       s2 = rte_lcore_to_socket_id(id2);
>                         if (s1 != s2){
>                                 lcp->c1 = id1;
>                                 lcp->c2 = id2;
> diff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c
> index ba27fbf7076d..70561fecda0d 100644
> --- a/app/test/test_stack_perf.c
> +++ b/app/test/test_stack_perf.c
> @@ -44,10 +44,10 @@ get_two_hyperthreads(struct lcore_pair *lcp)
>                 RTE_LCORE_FOREACH(id[1]) {
>                         if (id[0] == id[1])
>                                 continue;
> -                       core[0] = lcore_config[id[0]].core_id;
> -                       core[1] = lcore_config[id[1]].core_id;
> -                       socket[0] = lcore_config[id[0]].socket_id;
> -                       socket[1] = lcore_config[id[1]].socket_id;
> +                       core[0] = rte_lcore_to_cpu_id(id[0]);
> +                       core[1] = rte_lcore_to_cpu_id(id[1]);
> +                       socket[0] = rte_lcore_to_socket_id(id[0]);
> +                       socket[1] = rte_lcore_to_socket_id(id[1]);
>                         if ((core[0] == core[1]) && (socket[0] ==
> socket[1])) {
>                                 lcp->c1 = id[0];
>                                 lcp->c2 = id[1];
> @@ -70,10 +70,10 @@ get_two_cores(struct lcore_pair *lcp)
>                 RTE_LCORE_FOREACH(id[1]) {
>                         if (id[0] == id[1])
>                                 continue;
> -                       core[0] = lcore_config[id[0]].core_id;
> -                       core[1] = lcore_config[id[1]].core_id;
> -                       socket[0] = lcore_config[id[0]].socket_id;
> -                       socket[1] = lcore_config[id[1]].socket_id;
> +                       core[0] = rte_lcore_to_cpu_id(id[0]);
> +                       core[1] = rte_lcore_to_cpu_id(id[1]);
> +                       socket[0] = rte_lcore_to_socket_id(id[0]);
> +                       socket[1] = rte_lcore_to_socket_id(id[1]);
>                         if ((core[0] != core[1]) && (socket[0] ==
> socket[1])) {
>                                 lcp->c1 = id[0];
>                                 lcp->c2 = id[1];
> @@ -95,8 +95,8 @@ get_two_sockets(struct lcore_pair *lcp)
>                 RTE_LCORE_FOREACH(id[1]) {
>                         if (id[0] == id[1])
>                                 continue;
> -                       socket[0] = lcore_config[id[0]].socket_id;
> -                       socket[1] = lcore_config[id[1]].socket_id;
> +                       socket[0] = rte_lcore_to_socket_id(id[0]);
> +                       socket[1] = rte_lcore_to_socket_id(id[1]);
>                         if (socket[0] != socket[1]) {
>                                 lcp->c1 = id[0];
>                                 lcp->c2 = id[1];
> --
> 2.17.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand