From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0AAA6A0096 for ; Tue, 9 Apr 2019 11:10:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 887605B1E; Tue, 9 Apr 2019 11:10:23 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 4F9045A6E; Tue, 9 Apr 2019 11:10:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 02:10:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,328,1549958400"; d="scan'208";a="336227520" Received: from unknown (HELO [10.237.220.134]) ([10.237.220.134]) by fmsmga005.fm.intel.com with ESMTP; 09 Apr 2019 02:10:18 -0700 To: Andrius Sirvys , dev@dpdk.org Cc: kevin.laatz@intel.com, stable@dpdk.org, ciara.power@intel.com References: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com> <1554730848-97709-1-git-send-email-andrius.sirvys@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 9 Apr 2019 10:10:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554730848-97709-1-git-send-email-andrius.sirvys@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] usertools: replace unsafe input function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409091018.mt4qO1dIXdKJ1G696WzVOYlVxYSvZZ6d7srQmfn6E5w@z> On 08-Apr-19 2:40 PM, Andrius Sirvys wrote: > LGTM static code analysis tool reports that the function 'input' is > unsafe. Changed to use raw_input which then converts it using > ast.literal_eval() which is safe. > > Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") > Cc: ciara.power@intel.com > > Signed-off-by: Andrius Sirvys > Acked-by: Kevin Laatz > --- > v2:raw_input doesn't exist in Python 3, added a clause > to check python version > --- > usertools/dpdk-telemetry-client.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py > index ce0c7a9..5f6c47b 100755 > --- a/usertools/dpdk-telemetry-client.py > +++ b/usertools/dpdk-telemetry-client.py > @@ -14,6 +14,11 @@ > API_UNREG = "{\"action\":2,\"command\":\"clients\",\"data\":{\"client_path\":\"" > DEFAULT_FP = "/var/run/dpdk/default_client" > > +try: > + raw_input # Python 2 > +except NameError: > + raw_input = input # Python 3 > + > class Socket: > > def __init__(self): > Nitpicking, but PEP8 suggests two spaces before comment rather than one, e.g. code # comment rather than code # comment Other than that, Acked-by: Anatoly Burakov -- Thanks, Anatoly