* [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
@ 2019-04-09 9:54 Lukasz Krakowiak
2019-04-09 9:54 ` Lukasz Krakowiak
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Lukasz Krakowiak @ 2019-04-09 9:54 UTC (permalink / raw)
To: david.hunt; +Cc: dev, Lukasz Krakowiak
Removed dependency to mac_list from policies:
* BRANCH_RATIO,
* WORKLOAD,
* TIME
in function update_policy.
Fixes: 1b897991473f ("power: update error handling")
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
---
examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 74df0fe20..ad1ddde07 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
/* Copy the contents of *pkt into the policy.pkt */
policies[i].pkt = *pkt;
get_pcpu_to_control(&policies[i]);
- if (get_pfid(&policies[i]) < 0) {
- updated = 1;
- break;
+ /* Check Eth dev only for Traffic policy */
+ if (policies[i].pkt.policy_to_use == TRAFFIC) {
+ if (get_pfid(&policies[i]) < 0) {
+ updated = 1;
+ break;
+ }
}
core_share_status(i);
policies[i].enabled = 1;
@@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
if (policies[i].enabled == 0) {
policies[i].pkt = *pkt;
get_pcpu_to_control(&policies[i]);
- if (get_pfid(&policies[i]) < 0)
- break;
+ /* Check Eth dev only for Traffic policy */
+ if (policies[i].pkt.policy_to_use == TRAFFIC) {
+ if (get_pfid(&policies[i]) < 0) {
+ updated = 1;
+ break;
+ }
+ }
core_share_status(i);
policies[i].enabled = 1;
break;
--
2.19.2.windows.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
2019-04-09 9:54 [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list Lukasz Krakowiak
@ 2019-04-09 9:54 ` Lukasz Krakowiak
2019-04-18 14:13 ` Hunt, David
2019-04-19 9:39 ` Hunt, David
2 siblings, 0 replies; 8+ messages in thread
From: Lukasz Krakowiak @ 2019-04-09 9:54 UTC (permalink / raw)
To: david.hunt; +Cc: dev, Lukasz Krakowiak
Removed dependency to mac_list from policies:
* BRANCH_RATIO,
* WORKLOAD,
* TIME
in function update_policy.
Fixes: 1b897991473f ("power: update error handling")
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
---
examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 74df0fe20..ad1ddde07 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
/* Copy the contents of *pkt into the policy.pkt */
policies[i].pkt = *pkt;
get_pcpu_to_control(&policies[i]);
- if (get_pfid(&policies[i]) < 0) {
- updated = 1;
- break;
+ /* Check Eth dev only for Traffic policy */
+ if (policies[i].pkt.policy_to_use == TRAFFIC) {
+ if (get_pfid(&policies[i]) < 0) {
+ updated = 1;
+ break;
+ }
}
core_share_status(i);
policies[i].enabled = 1;
@@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
if (policies[i].enabled == 0) {
policies[i].pkt = *pkt;
get_pcpu_to_control(&policies[i]);
- if (get_pfid(&policies[i]) < 0)
- break;
+ /* Check Eth dev only for Traffic policy */
+ if (policies[i].pkt.policy_to_use == TRAFFIC) {
+ if (get_pfid(&policies[i]) < 0) {
+ updated = 1;
+ break;
+ }
+ }
core_share_status(i);
policies[i].enabled = 1;
break;
--
2.19.2.windows.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
2019-04-09 9:54 [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list Lukasz Krakowiak
2019-04-09 9:54 ` Lukasz Krakowiak
@ 2019-04-18 14:13 ` Hunt, David
2019-04-18 14:13 ` Hunt, David
2019-04-22 20:05 ` Thomas Monjalon
2019-04-19 9:39 ` Hunt, David
2 siblings, 2 replies; 8+ messages in thread
From: Hunt, David @ 2019-04-18 14:13 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev
Hi Lukasz,
On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
> Removed dependency to mac_list from policies:
> * BRANCH_RATIO,
> * WORKLOAD,
> * TIME
> in function update_policy.
>
> Fixes: 1b897991473f ("power: update error handling")
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
> examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..ad1ddde07 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
> /* Copy the contents of *pkt into the policy.pkt */
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0) {
> - updated = 1;
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> }
> core_share_status(i);
> policies[i].enabled = 1;
> @@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
> if (policies[i].enabled == 0) {
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0)
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> + }
> core_share_status(i);
> policies[i].enabled = 1;
> break;
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
2019-04-18 14:13 ` Hunt, David
@ 2019-04-18 14:13 ` Hunt, David
2019-04-22 20:05 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Hunt, David @ 2019-04-18 14:13 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev
Hi Lukasz,
On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
> Removed dependency to mac_list from policies:
> * BRANCH_RATIO,
> * WORKLOAD,
> * TIME
> in function update_policy.
>
> Fixes: 1b897991473f ("power: update error handling")
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
> examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..ad1ddde07 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
> /* Copy the contents of *pkt into the policy.pkt */
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0) {
> - updated = 1;
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> }
> core_share_status(i);
> policies[i].enabled = 1;
> @@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
> if (policies[i].enabled == 0) {
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0)
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> + }
> core_share_status(i);
> policies[i].enabled = 1;
> break;
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
2019-04-18 14:13 ` Hunt, David
2019-04-18 14:13 ` Hunt, David
@ 2019-04-22 20:05 ` Thomas Monjalon
2019-04-22 20:05 ` Thomas Monjalon
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-22 20:05 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev, Hunt, David
> > Removed dependency to mac_list from policies:
> > * BRANCH_RATIO,
> > * WORKLOAD,
> > * TIME
> > in function update_policy.
> >
> > Fixes: 1b897991473f ("power: update error handling")
> >
> > Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
2019-04-22 20:05 ` Thomas Monjalon
@ 2019-04-22 20:05 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-22 20:05 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev, Hunt, David
> > Removed dependency to mac_list from policies:
> > * BRANCH_RATIO,
> > * WORKLOAD,
> > * TIME
> > in function update_policy.
> >
> > Fixes: 1b897991473f ("power: update error handling")
> >
> > Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
2019-04-09 9:54 [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list Lukasz Krakowiak
2019-04-09 9:54 ` Lukasz Krakowiak
2019-04-18 14:13 ` Hunt, David
@ 2019-04-19 9:39 ` Hunt, David
2019-04-19 9:39 ` Hunt, David
2 siblings, 1 reply; 8+ messages in thread
From: Hunt, David @ 2019-04-19 9:39 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev
On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
> Removed dependency to mac_list from policies:
> * BRANCH_RATIO,
> * WORKLOAD,
> * TIME
> in function update_policy.
>
> Fixes: 1b897991473f ("power: update error handling")
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
> examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..ad1ddde07 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
> /* Copy the contents of *pkt into the policy.pkt */
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0) {
> - updated = 1;
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> }
> core_share_status(i);
> policies[i].enabled = 1;
> @@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
> if (policies[i].enabled == 0) {
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0)
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> + }
> core_share_status(i);
> policies[i].enabled = 1;
> break;
I hope it's OK to add Yufeng's Tested-by. As a new member to the mailing
list, they've tested the patch, but does not have the original email to
reply to.
Tested-by: Yufeng Mo <yufengx.mo@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list
2019-04-19 9:39 ` Hunt, David
@ 2019-04-19 9:39 ` Hunt, David
0 siblings, 0 replies; 8+ messages in thread
From: Hunt, David @ 2019-04-19 9:39 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev
On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote:
> Removed dependency to mac_list from policies:
> * BRANCH_RATIO,
> * WORKLOAD,
> * TIME
> in function update_policy.
>
> Fixes: 1b897991473f ("power: update error handling")
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
> examples/vm_power_manager/channel_monitor.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..ad1ddde07 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -437,9 +437,12 @@ update_policy(struct channel_packet *pkt)
> /* Copy the contents of *pkt into the policy.pkt */
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0) {
> - updated = 1;
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> }
> core_share_status(i);
> policies[i].enabled = 1;
> @@ -451,8 +454,13 @@ update_policy(struct channel_packet *pkt)
> if (policies[i].enabled == 0) {
> policies[i].pkt = *pkt;
> get_pcpu_to_control(&policies[i]);
> - if (get_pfid(&policies[i]) < 0)
> - break;
> + /* Check Eth dev only for Traffic policy */
> + if (policies[i].pkt.policy_to_use == TRAFFIC) {
> + if (get_pfid(&policies[i]) < 0) {
> + updated = 1;
> + break;
> + }
> + }
> core_share_status(i);
> policies[i].enabled = 1;
> break;
I hope it's OK to add Yufeng's Tested-by. As a new member to the mailing
list, they've tested the patch, but does not have the original email to
reply to.
Tested-by: Yufeng Mo <yufengx.mo@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-22 20:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 9:54 [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list Lukasz Krakowiak
2019-04-09 9:54 ` Lukasz Krakowiak
2019-04-18 14:13 ` Hunt, David
2019-04-18 14:13 ` Hunt, David
2019-04-22 20:05 ` Thomas Monjalon
2019-04-22 20:05 ` Thomas Monjalon
2019-04-19 9:39 ` Hunt, David
2019-04-19 9:39 ` Hunt, David
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).