From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 30FA05A6E for ; Tue, 9 Apr 2019 12:02:59 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 03:02:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="141259782" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga007.fm.intel.com with SMTP; 09 Apr 2019 03:02:57 -0700 Received: by (sSMTP sendmail emulation); Tue, 09 Apr 2019 11:02:56 +0100 Date: Tue, 9 Apr 2019 11:02:56 +0100 From: Bruce Richardson To: David Marchand Cc: dev Message-ID: <20190409100255.GA655@bricha3-MOBL.ger.corp.intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-6-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 10:03:00 -0000 On Tue, Apr 09, 2019 at 11:57:04AM +0200, David Marchand wrote: > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > The pipefile option does not seem to exist on FreeBSD, giving an > error > when running the script. > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on > failure") > Signed-off-by: Bruce Richardson <[2]bruce.richardson@intel.com> > --- > devtools/test-meson-builds.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > diff --git a/devtools/test-meson-builds.sh > b/devtools/test-meson-builds.sh > index b3b5cfbb5..1fd23fac7 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -7,7 +7,10 @@ > # * if a build-directory already exists we assume it was properly > configured > # Run ninja after configuration is done. > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" == "Linux" ] ; then > + set -o pipefail > +fi > > == is a bashism, can't you just use = ? > -- Yes, my bad, I'll do a v2. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E4D5DA0096 for ; Tue, 9 Apr 2019 12:03:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0DBD55B36; Tue, 9 Apr 2019 12:03:02 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 30FA05A6E for ; Tue, 9 Apr 2019 12:02:59 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 03:02:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="141259782" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga007.fm.intel.com with SMTP; 09 Apr 2019 03:02:57 -0700 Received: by (sSMTP sendmail emulation); Tue, 09 Apr 2019 11:02:56 +0100 Date: Tue, 9 Apr 2019 11:02:56 +0100 From: Bruce Richardson To: David Marchand Cc: dev Message-ID: <20190409100255.GA655@bricha3-MOBL.ger.corp.intel.com> References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-6-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409100256.X-fZC1DBpm200QwtKKYNqCGni3bq-eBpi-1Wth8BES0@z> On Tue, Apr 09, 2019 at 11:57:04AM +0200, David Marchand wrote: > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > The pipefile option does not seem to exist on FreeBSD, giving an > error > when running the script. > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on > failure") > Signed-off-by: Bruce Richardson <[2]bruce.richardson@intel.com> > --- > devtools/test-meson-builds.sh | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > diff --git a/devtools/test-meson-builds.sh > b/devtools/test-meson-builds.sh > index b3b5cfbb5..1fd23fac7 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -7,7 +7,10 @@ > # * if a build-directory already exists we assume it was properly > configured > # Run ninja after configuration is done. > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" == "Linux" ] ; then > + set -o pipefail > +fi > > == is a bashism, can't you just use = ? > -- Yes, my bad, I'll do a v2. /Bruce