From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2 1/5] build: simplify subdirectory detection for EAL
Date: Tue, 09 Apr 2019 11:58:08 +0100 [thread overview]
Message-ID: <793e6f8b787bb5e51387d9b4dfa13a89378f5e02.camel@debian.org> (raw)
Message-ID: <20190409105808.fjR3HkjyJ9xkwZ73sE917bH8eaB-28pRVArcSrQ2VXo@z> (raw)
In-Reply-To: <20190409105539.61460-2-bruce.richardson@intel.com>
On Tue, 2019-04-09 at 11:55 +0100, Bruce Richardson wrote:
> Within EAL we had a series of if statements for selecting the EAL
> directory
> to use. Now that the directory names match those of the OS's they are
> for
> we can instead just use a generated subdirectory name, shortening the
> code.
> To avoid strange errors, we still need to check for unsupported OS's,
> but
> do this check up-front in the config meson.build file.
>
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> Reviewed-by: David Marchand <
> david.marchand@redhat.com
> >
> ---
> config/meson.build | 7 +++++++
> lib/librte_eal/meson.build | 17 ++---------------
> 2 files changed, 9 insertions(+), 15 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2019-04-09 10:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 10:55 [dpdk-dev] [PATCH v2 0/5] small cleanup and fixes Bruce Richardson
2019-04-09 10:55 ` Bruce Richardson
2019-04-09 10:55 ` [dpdk-dev] [PATCH v2 1/5] build: simplify subdirectory detection for EAL Bruce Richardson
2019-04-09 10:55 ` Bruce Richardson
2019-04-09 10:58 ` Luca Boccassi [this message]
2019-04-09 10:58 ` Luca Boccassi
2019-04-09 10:55 ` [dpdk-dev] [PATCH v2 2/5] build: increase readability via shortcut variables Bruce Richardson
2019-04-09 10:55 ` Bruce Richardson
2019-04-09 10:55 ` [dpdk-dev] [PATCH v2 3/5] distributor: skip building if power library not found Bruce Richardson
2019-04-09 10:55 ` Bruce Richardson
2019-04-09 10:55 ` [dpdk-dev] [PATCH v2 4/5] examples/l2fwd-cat: fix build on FreeBSD Bruce Richardson
2019-04-09 10:55 ` Bruce Richardson
2019-04-09 10:55 ` [dpdk-dev] [PATCH v2 5/5] devtools/test-meson-builds: fix support for FreeBSD Bruce Richardson
2019-04-09 10:55 ` Bruce Richardson
2019-04-17 16:17 ` Thomas Monjalon
2019-04-17 16:17 ` Thomas Monjalon
2019-04-17 16:30 ` Bruce Richardson
2019-04-17 16:30 ` Bruce Richardson
2019-04-17 16:17 ` [dpdk-dev] [PATCH v2 0/5] small cleanup and fixes Thomas Monjalon
2019-04-17 16:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=793e6f8b787bb5e51387d9b4dfa13a89378f5e02.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).