DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ayuj Verma <ayverma@marvell.com>
To: <akhil.goyal@nxp.com>, <fiona.trahe@intel.com>,
	<arkadiuszx.kusztal@intel.com>, <pablo.de.lara.guarch@intel.com>
Cc: <shallyv@marvell.com>, <ssahu@marvell.com>,
	<kkotamarthy@marvell.com>, <adesai@marvell.com>, <dev@dpdk.org>,
	Ayuj Verma <ayverma@marvell.com>
Subject: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP
Date: Tue, 9 Apr 2019 17:03:39 +0530	[thread overview]
Message-ID: <1554809619-21164-2-git-send-email-ayverma@marvell.com> (raw)
Message-ID: <20190409113339.Q59KfXYHQWOEtCui2f2XV4JnNYTON_wcnYXGI0IYwfM@z> (raw)
In-Reply-To: <1554809619-21164-1-git-send-email-ayverma@marvell.com>

Return -ENOTSUP for unsupported tests

Signed-off-by: Ayuj Verma <ayverma@marvell.com>
Signed-off-by: Shally Verma <shallyv@marvell.com>
---
 app/test/test_cryptodev_asym.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index d2efce9..feed3a8 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -352,7 +352,7 @@ struct test_cases_array {
 		RTE_LOG(INFO, USER1,
 				"Device doesn't support sign op with "
 				"exponent key type. Test Skipped\n");
-		return TEST_SKIPPED;
+		return -ENOTSUP;
 	}
 
 	sess = rte_cryptodev_asym_session_create(sess_mpool);
@@ -498,7 +498,7 @@ struct test_cases_array {
 		RTE_LOG(INFO, USER1,
 				"Device doesn't support sign op with "
 				"exponent key type. Test Skipped\n");
-		return TEST_SKIPPED;
+		return -ENOTSUP;
 	}
 
 	sess = rte_cryptodev_asym_session_create(sess_mpool);
@@ -1261,7 +1261,7 @@ static inline void print_asym_capa(
 		&modinv_xform.xform_type, "modinv") < 0) {
 		RTE_LOG(ERR, USER1,
 				 "Invalid ASYNC algorithm specified\n");
-		return -1;
+		return -ENOTSUP;
 	}
 
 	cap_idx.type = modinv_xform.xform_type;
@@ -1273,7 +1273,7 @@ static inline void print_asym_capa(
 		modinv_xform.modinv.modulus.length)) {
 		RTE_LOG(ERR, USER1,
 				 "Invalid MODULOUS length specified\n");
-				return -1;
+				return -ENOTSUP;
 		}
 
 	sess = rte_cryptodev_asym_session_create(sess_mpool);
@@ -1380,7 +1380,7 @@ static inline void print_asym_capa(
 		< 0) {
 		RTE_LOG(ERR, USER1,
 				"Invalid ASYNC algorithm specified\n");
-		return -1;
+		return -ENOTSUP;
 	}
 
 	/* check for modlen capability */
@@ -1391,7 +1391,7 @@ static inline void print_asym_capa(
 			capability, modex_xform.modex.modulus.length)) {
 		RTE_LOG(ERR, USER1,
 				"Invalid MODULOUS length specified\n");
-				return -1;
+				return -ENOTSUP;
 		}
 
 	/* generate crypto op data structure */
-- 
1.8.3.1


  parent reply	other threads:[~2019-04-09 11:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 11:33 [dpdk-dev] [PATCH v2] fix return value for skipped tests Ayuj Verma
2019-04-09 11:33 ` Ayuj Verma
2019-04-09 11:33 ` Ayuj Verma [this message]
2019-04-09 11:33   ` [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP Ayuj Verma
2019-04-09 14:55   ` Bruce Richardson
2019-04-09 14:55     ` Bruce Richardson
2019-04-10 12:33     ` [dpdk-dev] [EXT] " Ayuj Verma
2019-04-10 12:33       ` Ayuj Verma
2019-04-10 12:48       ` Bruce Richardson
2019-04-10 12:48         ` Bruce Richardson
2019-04-09 15:17   ` [dpdk-dev] " Trahe, Fiona
2019-04-09 15:17     ` Trahe, Fiona
2019-04-12  7:08     ` Ayuj Verma
2019-04-12  7:08       ` Ayuj Verma
2019-04-12 10:25       ` Trahe, Fiona
2019-04-12 10:25         ` Trahe, Fiona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554809619-21164-2-git-send-email-ayverma@marvell.com \
    --to=ayverma@marvell.com \
    --cc=adesai@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=kkotamarthy@marvell.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=shallyv@marvell.com \
    --cc=ssahu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).