* [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
@ 2019-04-08 8:59 Gagandeep Singh
2019-04-08 8:59 ` Gagandeep Singh
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Gagandeep Singh @ 2019-04-08 8:59 UTC (permalink / raw)
To: dev, Akhil Goyal; +Cc: Gagandeep Singh
build a shared descriptor accordingly if core and
CAAM endianness is same or different
Fixes: 6ef6beca8844 ("crypto/caam_jr: add enqueue/dequeue operations")
Cc: g.singh@nxp.com
Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
drivers/crypto/caam_jr/caam_jr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 190053e..20452e3 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -311,7 +311,7 @@ void caam_jr_stats_reset(struct rte_cryptodev *dev)
int32_t shared_desc_len = 0;
struct sec_cdb *cdb;
int err;
-#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+#if CAAM_BYTE_ORDER == CORE_BYTE_ORDER
int swap = false;
#else
int swap = true;
--
1.9.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
2019-04-08 8:59 [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Gagandeep Singh
@ 2019-04-08 8:59 ` Gagandeep Singh
2019-04-08 8:59 ` [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case Gagandeep Singh
2019-04-09 14:17 ` [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Akhil Goyal
2 siblings, 0 replies; 10+ messages in thread
From: Gagandeep Singh @ 2019-04-08 8:59 UTC (permalink / raw)
To: dev, Akhil Goyal; +Cc: Gagandeep Singh
build a shared descriptor accordingly if core and
CAAM endianness is same or different
Fixes: 6ef6beca8844 ("crypto/caam_jr: add enqueue/dequeue operations")
Cc: g.singh@nxp.com
Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
drivers/crypto/caam_jr/caam_jr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 190053e..20452e3 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -311,7 +311,7 @@ void caam_jr_stats_reset(struct rte_cryptodev *dev)
int32_t shared_desc_len = 0;
struct sec_cdb *cdb;
int err;
-#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN
+#if CAAM_BYTE_ORDER == CORE_BYTE_ORDER
int swap = false;
#else
int swap = true;
--
1.9.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case
2019-04-08 8:59 [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Gagandeep Singh
2019-04-08 8:59 ` Gagandeep Singh
@ 2019-04-08 8:59 ` Gagandeep Singh
2019-04-08 8:59 ` Gagandeep Singh
2019-04-09 14:06 ` Akhil Goyal
2019-04-09 14:17 ` [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Akhil Goyal
2 siblings, 2 replies; 10+ messages in thread
From: Gagandeep Singh @ 2019-04-08 8:59 UTC (permalink / raw)
To: dev, Akhil Goyal; +Cc: Gagandeep Singh
CAAM return wrong digest value in AUTH only sg test case
because digest calculated on wrong length of data
Fixes: 71dd6b9d44e7 ("crypto/caam_jr: add scatter gather")
Cc: g.singh@nxp.com
Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
drivers/crypto/caam_jr/caam_jr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 20452e3..efc69b6 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -798,7 +798,7 @@ void caam_jr_stats_reset(struct rte_cryptodev *dev)
sg->len = cpu_to_caam32(ses->digest_length);
length += ses->digest_length;
} else {
- length -= ses->digest_length;
+ sg->len -= ses->digest_length;
}
/* last element*/
--
1.9.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case
2019-04-08 8:59 ` [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case Gagandeep Singh
@ 2019-04-08 8:59 ` Gagandeep Singh
2019-04-09 14:06 ` Akhil Goyal
1 sibling, 0 replies; 10+ messages in thread
From: Gagandeep Singh @ 2019-04-08 8:59 UTC (permalink / raw)
To: dev, Akhil Goyal; +Cc: Gagandeep Singh
CAAM return wrong digest value in AUTH only sg test case
because digest calculated on wrong length of data
Fixes: 71dd6b9d44e7 ("crypto/caam_jr: add scatter gather")
Cc: g.singh@nxp.com
Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
---
drivers/crypto/caam_jr/caam_jr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 20452e3..efc69b6 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -798,7 +798,7 @@ void caam_jr_stats_reset(struct rte_cryptodev *dev)
sg->len = cpu_to_caam32(ses->digest_length);
length += ses->digest_length;
} else {
- length -= ses->digest_length;
+ sg->len -= ses->digest_length;
}
/* last element*/
--
1.9.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case
2019-04-08 8:59 ` [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case Gagandeep Singh
2019-04-08 8:59 ` Gagandeep Singh
@ 2019-04-09 14:06 ` Akhil Goyal
2019-04-09 14:06 ` Akhil Goyal
1 sibling, 1 reply; 10+ messages in thread
From: Akhil Goyal @ 2019-04-09 14:06 UTC (permalink / raw)
To: Gagandeep Singh, dev
> -----Original Message-----
> From: Gagandeep Singh
> Sent: Monday, April 8, 2019 2:30 PM
> To: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>
> Cc: Gagandeep Singh <G.Singh@nxp.com>
> Subject: [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case
>
> CAAM return wrong digest value in AUTH only sg test case
> because digest calculated on wrong length of data
>
> Fixes: 71dd6b9d44e7 ("crypto/caam_jr: add scatter gather")
> Cc: g.singh@nxp.com
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case
2019-04-09 14:06 ` Akhil Goyal
@ 2019-04-09 14:06 ` Akhil Goyal
0 siblings, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2019-04-09 14:06 UTC (permalink / raw)
To: Gagandeep Singh, dev
> -----Original Message-----
> From: Gagandeep Singh
> Sent: Monday, April 8, 2019 2:30 PM
> To: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>
> Cc: Gagandeep Singh <G.Singh@nxp.com>
> Subject: [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case
>
> CAAM return wrong digest value in AUTH only sg test case
> because digest calculated on wrong length of data
>
> Fixes: 71dd6b9d44e7 ("crypto/caam_jr: add scatter gather")
> Cc: g.singh@nxp.com
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
2019-04-08 8:59 [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Gagandeep Singh
2019-04-08 8:59 ` Gagandeep Singh
2019-04-08 8:59 ` [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case Gagandeep Singh
@ 2019-04-09 14:17 ` Akhil Goyal
2019-04-09 14:17 ` Akhil Goyal
2019-04-16 14:51 ` Akhil Goyal
2 siblings, 2 replies; 10+ messages in thread
From: Akhil Goyal @ 2019-04-09 14:17 UTC (permalink / raw)
To: Gagandeep Singh, dev
> -----Original Message-----
> From: Gagandeep Singh
> Sent: Monday, April 8, 2019 2:29 PM
> To: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>
> Cc: Gagandeep Singh <G.Singh@nxp.com>
> Subject: [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
>
> build a shared descriptor accordingly if core and
> CAAM endianness is same or different
>
> Fixes: 6ef6beca8844 ("crypto/caam_jr: add enqueue/dequeue operations")
> Cc: g.singh@nxp.com
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
2019-04-09 14:17 ` [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Akhil Goyal
@ 2019-04-09 14:17 ` Akhil Goyal
2019-04-16 14:51 ` Akhil Goyal
1 sibling, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2019-04-09 14:17 UTC (permalink / raw)
To: Gagandeep Singh, dev
> -----Original Message-----
> From: Gagandeep Singh
> Sent: Monday, April 8, 2019 2:29 PM
> To: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>
> Cc: Gagandeep Singh <G.Singh@nxp.com>
> Subject: [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
>
> build a shared descriptor accordingly if core and
> CAAM endianness is same or different
>
> Fixes: 6ef6beca8844 ("crypto/caam_jr: add enqueue/dequeue operations")
> Cc: g.singh@nxp.com
>
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
2019-04-09 14:17 ` [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Akhil Goyal
2019-04-09 14:17 ` Akhil Goyal
@ 2019-04-16 14:51 ` Akhil Goyal
2019-04-16 14:51 ` Akhil Goyal
1 sibling, 1 reply; 10+ messages in thread
From: Akhil Goyal @ 2019-04-16 14:51 UTC (permalink / raw)
To: Gagandeep Singh, dev
> > -----Original Message-----
> > From: Gagandeep Singh
> > Sent: Monday, April 8, 2019 2:29 PM
> > To: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>
> > Cc: Gagandeep Singh <G.Singh@nxp.com>
> > Subject: [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
> >
> > build a shared descriptor accordingly if core and
> > CAAM endianness is same or different
> >
> > Fixes: 6ef6beca8844 ("crypto/caam_jr: add enqueue/dequeue operations")
> > Cc: g.singh@nxp.com
> >
> > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Series Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
2019-04-16 14:51 ` Akhil Goyal
@ 2019-04-16 14:51 ` Akhil Goyal
0 siblings, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2019-04-16 14:51 UTC (permalink / raw)
To: Gagandeep Singh, dev
> > -----Original Message-----
> > From: Gagandeep Singh
> > Sent: Monday, April 8, 2019 2:29 PM
> > To: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>
> > Cc: Gagandeep Singh <G.Singh@nxp.com>
> > Subject: [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness
> >
> > build a shared descriptor accordingly if core and
> > CAAM endianness is same or different
> >
> > Fixes: 6ef6beca8844 ("crypto/caam_jr: add enqueue/dequeue operations")
> > Cc: g.singh@nxp.com
> >
> > Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> > ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Series Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-04-16 14:51 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 8:59 [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Gagandeep Singh
2019-04-08 8:59 ` Gagandeep Singh
2019-04-08 8:59 ` [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case Gagandeep Singh
2019-04-08 8:59 ` Gagandeep Singh
2019-04-09 14:06 ` Akhil Goyal
2019-04-09 14:06 ` Akhil Goyal
2019-04-09 14:17 ` [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness Akhil Goyal
2019-04-09 14:17 ` Akhil Goyal
2019-04-16 14:51 ` Akhil Goyal
2019-04-16 14:51 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).