* [dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
@ 2019-04-09 14:32 Li Qiang
2019-04-09 14:32 ` Li Qiang
2019-04-10 10:23 ` Xu, Rosen
0 siblings, 2 replies; 4+ messages in thread
From: Li Qiang @ 2019-04-09 14:32 UTC (permalink / raw)
To: rosen.xu, tianfei.zhang; +Cc: dev, liq3ea, Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the
'file_fd' is never closed thus leading a fd leak. This patch
avoids this.
Spotted by Coverity: CID 27441
Signed-off-by: Li Qiang <liq3ea@163.com>
---
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index da772d026..0dbb16ca6 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -244,7 +244,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,
if (ret) {
IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n",
file_name);
- return -EINVAL;
+ goto close_fd;
}
buffer_size = file_stat.st_size;
IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
2019-04-09 14:32 [dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr Li Qiang
@ 2019-04-09 14:32 ` Li Qiang
2019-04-10 10:23 ` Xu, Rosen
1 sibling, 0 replies; 4+ messages in thread
From: Li Qiang @ 2019-04-09 14:32 UTC (permalink / raw)
To: rosen.xu, tianfei.zhang; +Cc: dev, liq3ea, Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the
'file_fd' is never closed thus leading a fd leak. This patch
avoids this.
Spotted by Coverity: CID 27441
Signed-off-by: Li Qiang <liq3ea@163.com>
---
drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index da772d026..0dbb16ca6 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -244,7 +244,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,
if (ret) {
IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n",
file_name);
- return -EINVAL;
+ goto close_fd;
}
buffer_size = file_stat.st_size;
IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
2019-04-09 14:32 [dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr Li Qiang
2019-04-09 14:32 ` Li Qiang
@ 2019-04-10 10:23 ` Xu, Rosen
2019-04-10 10:23 ` Xu, Rosen
1 sibling, 1 reply; 4+ messages in thread
From: Xu, Rosen @ 2019-04-10 10:23 UTC (permalink / raw)
To: Li Qiang, Zhang, Tianfei; +Cc: dev, liq3ea
> -----Original Message-----
> From: Li Qiang [mailto:liq3ea@163.com]
> Sent: Tuesday, April 09, 2019 22:32
> To: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>
> Cc: dev@dpdk.org; liq3ea@gmail.com; Li Qiang <liq3ea@163.com>
> Subject: [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
>
> In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed
> thus leading a fd leak. This patch avoids this.
>
> Spotted by Coverity: CID 27441
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> index da772d026..0dbb16ca6 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -244,7 +244,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int
> port_id,
> if (ret) {
> IFPGA_RAWDEV_PMD_ERR("stat on bitstream file
> failed: %s\n",
> file_name);
> - return -EINVAL;
Fill ret before goto close_fd.
> + goto close_fd;
> }
> buffer_size = file_stat.st_size;
> IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
2019-04-10 10:23 ` Xu, Rosen
@ 2019-04-10 10:23 ` Xu, Rosen
0 siblings, 0 replies; 4+ messages in thread
From: Xu, Rosen @ 2019-04-10 10:23 UTC (permalink / raw)
To: Li Qiang, Zhang, Tianfei; +Cc: dev, liq3ea
> -----Original Message-----
> From: Li Qiang [mailto:liq3ea@163.com]
> Sent: Tuesday, April 09, 2019 22:32
> To: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>
> Cc: dev@dpdk.org; liq3ea@gmail.com; Li Qiang <liq3ea@163.com>
> Subject: [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
>
> In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed
> thus leading a fd leak. This patch avoids this.
>
> Spotted by Coverity: CID 27441
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> index da772d026..0dbb16ca6 100644
> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
> @@ -244,7 +244,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int
> port_id,
> if (ret) {
> IFPGA_RAWDEV_PMD_ERR("stat on bitstream file
> failed: %s\n",
> file_name);
> - return -EINVAL;
Fill ret before goto close_fd.
> + goto close_fd;
> }
> buffer_size = file_stat.st_size;
> IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-10 10:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 14:32 [dpdk-dev] [PATCH] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr Li Qiang
2019-04-09 14:32 ` Li Qiang
2019-04-10 10:23 ` Xu, Rosen
2019-04-10 10:23 ` Xu, Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).