* [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
@ 2019-04-09 14:44 bugzilla
2019-04-09 14:44 ` bugzilla
2019-04-09 14:51 ` David Marchand
0 siblings, 2 replies; 12+ messages in thread
From: bugzilla @ 2019-04-09 14:44 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=248
Bug ID: 248
Summary: Bonding PMD: Invalid array dimension in TX burst for
802.3ad mode with fast queue leads to SEGFAULT
Product: DPDK
Version: 18.11
Hardware: All
OS: All
Status: CONFIRMED
Severity: major
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: p.oltarzewski@gmail.com
Target Milestone: ---
DPDK 18.11.1
In drivers/net/bonding/rte_eth_bond_pmd.c::bond_ethdev_tx_burst_8023ad,
bufs_slave_port_idxs array is defined as follows (lines 1293-1294):
/* Mapping array generated by hash function to map mbufs to slaves */
uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };
Array dimension should be equal to number of packets being transmitted
(nb_pkts) - as correctly implemented in
rte_eth_bond_pmd.c::bond_ethdev_tx_burst_balance.
Invalid array dimension causes overflow when number of transmitted packets is
greater than RTE_MAX_ETHPORTS. Some areas of memory end up overwritten (in my
particular case, slave_nb_bufs array), which leads to SIGSEGV and crash.
To work around the issue, ensure that number of packets transmitted in a single
burst is no greater than RTE_MAX_ETHPORTS.
To fix it, it should be sufficient to define bufs_slave_port_idxs as a
variable-length array, as in bond_ethdev_tx_burst_balance:
/* Mapping array generated by hash function to map mbufs to slaves */
uint16_t bufs_slave_port_idxs[nb_bufs];
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-09 14:44 [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT bugzilla
@ 2019-04-09 14:44 ` bugzilla
2019-04-09 14:51 ` David Marchand
1 sibling, 0 replies; 12+ messages in thread
From: bugzilla @ 2019-04-09 14:44 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=248
Bug ID: 248
Summary: Bonding PMD: Invalid array dimension in TX burst for
802.3ad mode with fast queue leads to SEGFAULT
Product: DPDK
Version: 18.11
Hardware: All
OS: All
Status: CONFIRMED
Severity: major
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: p.oltarzewski@gmail.com
Target Milestone: ---
DPDK 18.11.1
In drivers/net/bonding/rte_eth_bond_pmd.c::bond_ethdev_tx_burst_8023ad,
bufs_slave_port_idxs array is defined as follows (lines 1293-1294):
/* Mapping array generated by hash function to map mbufs to slaves */
uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };
Array dimension should be equal to number of packets being transmitted
(nb_pkts) - as correctly implemented in
rte_eth_bond_pmd.c::bond_ethdev_tx_burst_balance.
Invalid array dimension causes overflow when number of transmitted packets is
greater than RTE_MAX_ETHPORTS. Some areas of memory end up overwritten (in my
particular case, slave_nb_bufs array), which leads to SIGSEGV and crash.
To work around the issue, ensure that number of packets transmitted in a single
burst is no greater than RTE_MAX_ETHPORTS.
To fix it, it should be sufficient to define bufs_slave_port_idxs as a
variable-length array, as in bond_ethdev_tx_burst_balance:
/* Mapping array generated by hash function to map mbufs to slaves */
uint16_t bufs_slave_port_idxs[nb_bufs];
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-09 14:44 [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT bugzilla
2019-04-09 14:44 ` bugzilla
@ 2019-04-09 14:51 ` David Marchand
2019-04-09 14:51 ` David Marchand
2019-04-10 11:39 ` Przemysław Ołtarzewski
1 sibling, 2 replies; 12+ messages in thread
From: David Marchand @ 2019-04-09 14:51 UTC (permalink / raw)
To: p.oltarzewski, Chas Williams; +Cc: dev
On Tue, Apr 9, 2019 at 4:45 PM <bugzilla@dpdk.org> wrote:
> https://bugs.dpdk.org/show_bug.cgi?id=248
>
> Bug ID: 248
> Summary: Bonding PMD: Invalid array dimension in TX burst for
> 802.3ad mode with fast queue leads to SEGFAULT
> Product: DPDK
> Version: 18.11
> Hardware: All
> OS: All
> Status: CONFIRMED
> Severity: major
> Priority: Normal
> Component: ethdev
> Assignee: dev@dpdk.org
> Reporter: p.oltarzewski@gmail.com
> Target Milestone: ---
>
> DPDK 18.11.1
>
> In drivers/net/bonding/rte_eth_bond_pmd.c::bond_ethdev_tx_burst_8023ad,
> bufs_slave_port_idxs array is defined as follows (lines 1293-1294):
>
> /* Mapping array generated by hash function to map mbufs to slaves */
> uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };
>
> Array dimension should be equal to number of packets being transmitted
> (nb_pkts) - as correctly implemented in
> rte_eth_bond_pmd.c::bond_ethdev_tx_burst_balance.
>
> Invalid array dimension causes overflow when number of transmitted packets
> is
> greater than RTE_MAX_ETHPORTS. Some areas of memory end up overwritten (in
> my
> particular case, slave_nb_bufs array), which leads to SIGSEGV and crash.
>
> To work around the issue, ensure that number of packets transmitted in a
> single
> burst is no greater than RTE_MAX_ETHPORTS.
>
> To fix it, it should be sufficient to define bufs_slave_port_idxs as a
> variable-length array, as in bond_ethdev_tx_burst_balance:
>
> /* Mapping array generated by hash function to map mbufs to slaves */
> uint16_t bufs_slave_port_idxs[nb_bufs];
>
I have a series of fixes for this, and on the rx parts as well but did not
have time to properly check them.
Would you have some time to test it if I send it ?
--
David Marchand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-09 14:51 ` David Marchand
@ 2019-04-09 14:51 ` David Marchand
2019-04-10 11:39 ` Przemysław Ołtarzewski
1 sibling, 0 replies; 12+ messages in thread
From: David Marchand @ 2019-04-09 14:51 UTC (permalink / raw)
To: p.oltarzewski, Chas Williams; +Cc: dev
On Tue, Apr 9, 2019 at 4:45 PM <bugzilla@dpdk.org> wrote:
> https://bugs.dpdk.org/show_bug.cgi?id=248
>
> Bug ID: 248
> Summary: Bonding PMD: Invalid array dimension in TX burst for
> 802.3ad mode with fast queue leads to SEGFAULT
> Product: DPDK
> Version: 18.11
> Hardware: All
> OS: All
> Status: CONFIRMED
> Severity: major
> Priority: Normal
> Component: ethdev
> Assignee: dev@dpdk.org
> Reporter: p.oltarzewski@gmail.com
> Target Milestone: ---
>
> DPDK 18.11.1
>
> In drivers/net/bonding/rte_eth_bond_pmd.c::bond_ethdev_tx_burst_8023ad,
> bufs_slave_port_idxs array is defined as follows (lines 1293-1294):
>
> /* Mapping array generated by hash function to map mbufs to slaves */
> uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };
>
> Array dimension should be equal to number of packets being transmitted
> (nb_pkts) - as correctly implemented in
> rte_eth_bond_pmd.c::bond_ethdev_tx_burst_balance.
>
> Invalid array dimension causes overflow when number of transmitted packets
> is
> greater than RTE_MAX_ETHPORTS. Some areas of memory end up overwritten (in
> my
> particular case, slave_nb_bufs array), which leads to SIGSEGV and crash.
>
> To work around the issue, ensure that number of packets transmitted in a
> single
> burst is no greater than RTE_MAX_ETHPORTS.
>
> To fix it, it should be sufficient to define bufs_slave_port_idxs as a
> variable-length array, as in bond_ethdev_tx_burst_balance:
>
> /* Mapping array generated by hash function to map mbufs to slaves */
> uint16_t bufs_slave_port_idxs[nb_bufs];
>
I have a series of fixes for this, and on the rx parts as well but did not
have time to properly check them.
Would you have some time to test it if I send it ?
--
David Marchand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-09 14:51 ` David Marchand
2019-04-09 14:51 ` David Marchand
@ 2019-04-10 11:39 ` Przemysław Ołtarzewski
2019-04-10 11:39 ` Przemysław Ołtarzewski
2019-04-10 12:56 ` David Marchand
1 sibling, 2 replies; 12+ messages in thread
From: Przemysław Ołtarzewski @ 2019-04-10 11:39 UTC (permalink / raw)
To: David Marchand; +Cc: Chas Williams, dev
Hello David,
I can merge these fixes and run our system using patched DPDK version. Then
report back any problems / improvements I observe. I can also walk through
source code changes and check for anything questionable.
Unfortunately I lack deep enough understanding of DPDK source code to test
these fixes comprehensively and I have been short on time recently as well,
so that's the best I can do right now.
Best Regards,
Przemysław Ołtarzewski
On Tue, Apr 9, 2019 at 4:51 PM David Marchand <david.marchand@redhat.com>
wrote:
>
>
> On Tue, Apr 9, 2019 at 4:45 PM <bugzilla@dpdk.org> wrote:
>
>> https://bugs.dpdk.org/show_bug.cgi?id=248
>>
>> Bug ID: 248
>> Summary: Bonding PMD: Invalid array dimension in TX burst for
>> 802.3ad mode with fast queue leads to SEGFAULT
>> Product: DPDK
>> Version: 18.11
>> Hardware: All
>> OS: All
>> Status: CONFIRMED
>> Severity: major
>> Priority: Normal
>> Component: ethdev
>> Assignee: dev@dpdk.org
>> Reporter: p.oltarzewski@gmail.com
>> Target Milestone: ---
>>
>> DPDK 18.11.1
>>
>> In drivers/net/bonding/rte_eth_bond_pmd.c::bond_ethdev_tx_burst_8023ad,
>> bufs_slave_port_idxs array is defined as follows (lines 1293-1294):
>>
>> /* Mapping array generated by hash function to map mbufs to slaves */
>> uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };
>>
>> Array dimension should be equal to number of packets being transmitted
>> (nb_pkts) - as correctly implemented in
>> rte_eth_bond_pmd.c::bond_ethdev_tx_burst_balance.
>>
>> Invalid array dimension causes overflow when number of transmitted
>> packets is
>> greater than RTE_MAX_ETHPORTS. Some areas of memory end up overwritten
>> (in my
>> particular case, slave_nb_bufs array), which leads to SIGSEGV and crash.
>>
>> To work around the issue, ensure that number of packets transmitted in a
>> single
>> burst is no greater than RTE_MAX_ETHPORTS.
>>
>> To fix it, it should be sufficient to define bufs_slave_port_idxs as a
>> variable-length array, as in bond_ethdev_tx_burst_balance:
>>
>> /* Mapping array generated by hash function to map mbufs to slaves */
>> uint16_t bufs_slave_port_idxs[nb_bufs];
>>
>
> I have a series of fixes for this, and on the rx parts as well but did not
> have time to properly check them.
> Would you have some time to test it if I send it ?
>
>
> --
> David Marchand
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-10 11:39 ` Przemysław Ołtarzewski
@ 2019-04-10 11:39 ` Przemysław Ołtarzewski
2019-04-10 12:56 ` David Marchand
1 sibling, 0 replies; 12+ messages in thread
From: Przemysław Ołtarzewski @ 2019-04-10 11:39 UTC (permalink / raw)
To: David Marchand; +Cc: Chas Williams, dev
Hello David,
I can merge these fixes and run our system using patched DPDK version. Then
report back any problems / improvements I observe. I can also walk through
source code changes and check for anything questionable.
Unfortunately I lack deep enough understanding of DPDK source code to test
these fixes comprehensively and I have been short on time recently as well,
so that's the best I can do right now.
Best Regards,
Przemysław Ołtarzewski
On Tue, Apr 9, 2019 at 4:51 PM David Marchand <david.marchand@redhat.com>
wrote:
>
>
> On Tue, Apr 9, 2019 at 4:45 PM <bugzilla@dpdk.org> wrote:
>
>> https://bugs.dpdk.org/show_bug.cgi?id=248
>>
>> Bug ID: 248
>> Summary: Bonding PMD: Invalid array dimension in TX burst for
>> 802.3ad mode with fast queue leads to SEGFAULT
>> Product: DPDK
>> Version: 18.11
>> Hardware: All
>> OS: All
>> Status: CONFIRMED
>> Severity: major
>> Priority: Normal
>> Component: ethdev
>> Assignee: dev@dpdk.org
>> Reporter: p.oltarzewski@gmail.com
>> Target Milestone: ---
>>
>> DPDK 18.11.1
>>
>> In drivers/net/bonding/rte_eth_bond_pmd.c::bond_ethdev_tx_burst_8023ad,
>> bufs_slave_port_idxs array is defined as follows (lines 1293-1294):
>>
>> /* Mapping array generated by hash function to map mbufs to slaves */
>> uint16_t bufs_slave_port_idxs[RTE_MAX_ETHPORTS] = { 0 };
>>
>> Array dimension should be equal to number of packets being transmitted
>> (nb_pkts) - as correctly implemented in
>> rte_eth_bond_pmd.c::bond_ethdev_tx_burst_balance.
>>
>> Invalid array dimension causes overflow when number of transmitted
>> packets is
>> greater than RTE_MAX_ETHPORTS. Some areas of memory end up overwritten
>> (in my
>> particular case, slave_nb_bufs array), which leads to SIGSEGV and crash.
>>
>> To work around the issue, ensure that number of packets transmitted in a
>> single
>> burst is no greater than RTE_MAX_ETHPORTS.
>>
>> To fix it, it should be sufficient to define bufs_slave_port_idxs as a
>> variable-length array, as in bond_ethdev_tx_burst_balance:
>>
>> /* Mapping array generated by hash function to map mbufs to slaves */
>> uint16_t bufs_slave_port_idxs[nb_bufs];
>>
>
> I have a series of fixes for this, and on the rx parts as well but did not
> have time to properly check them.
> Would you have some time to test it if I send it ?
>
>
> --
> David Marchand
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-10 11:39 ` Przemysław Ołtarzewski
2019-04-10 11:39 ` Przemysław Ołtarzewski
@ 2019-04-10 12:56 ` David Marchand
2019-04-10 12:56 ` David Marchand
2019-04-15 9:50 ` Przemysław Ołtarzewski
1 sibling, 2 replies; 12+ messages in thread
From: David Marchand @ 2019-04-10 12:56 UTC (permalink / raw)
To: Przemysław Ołtarzewski; +Cc: Chas Williams, dev
On Wed, Apr 10, 2019 at 1:33 PM Przemysław Ołtarzewski <
p.oltarzewski@gmail.com> wrote:
> Hello David,
>
> I can merge these fixes and run our system using patched DPDK version.
> Then report back any problems / improvements I observe. I can also walk
> through source code changes and check for anything questionable.
>
> Unfortunately I lack deep enough understanding of DPDK source code to test
> these fixes comprehensively and I have been short on time recently as well,
> so that's the best I can do right now.
>
Please, be aware that other fixes have been already merged in master since
18.11.
https://git.dpdk.org/dpdk/log/drivers/net/bonding
I just sent the patchset that should fix your issue:
http://patchwork.dpdk.org/project/dpdk/list/?series=4240
--
David Marchand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-10 12:56 ` David Marchand
@ 2019-04-10 12:56 ` David Marchand
2019-04-15 9:50 ` Przemysław Ołtarzewski
1 sibling, 0 replies; 12+ messages in thread
From: David Marchand @ 2019-04-10 12:56 UTC (permalink / raw)
To: Przemysław Ołtarzewski; +Cc: Chas Williams, dev
On Wed, Apr 10, 2019 at 1:33 PM Przemysław Ołtarzewski <
p.oltarzewski@gmail.com> wrote:
> Hello David,
>
> I can merge these fixes and run our system using patched DPDK version.
> Then report back any problems / improvements I observe. I can also walk
> through source code changes and check for anything questionable.
>
> Unfortunately I lack deep enough understanding of DPDK source code to test
> these fixes comprehensively and I have been short on time recently as well,
> so that's the best I can do right now.
>
Please, be aware that other fixes have been already merged in master since
18.11.
https://git.dpdk.org/dpdk/log/drivers/net/bonding
I just sent the patchset that should fix your issue:
http://patchwork.dpdk.org/project/dpdk/list/?series=4240
--
David Marchand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-10 12:56 ` David Marchand
2019-04-10 12:56 ` David Marchand
@ 2019-04-15 9:50 ` Przemysław Ołtarzewski
2019-04-15 9:50 ` Przemysław Ołtarzewski
2019-04-18 9:38 ` Kevin Traynor
1 sibling, 2 replies; 12+ messages in thread
From: Przemysław Ołtarzewski @ 2019-04-15 9:50 UTC (permalink / raw)
To: David Marchand; +Cc: Chas Williams, dev
Hello,
Last week I attempted to migrate our system from DPDK 18.11.1 to current
master with David's patches applied. I haven't been able to make it work
correctly - probably due to other changes in master since 18.11.1 - so
unfortunately I cannot confirm that David's patchset solves the issue
(although from source code analysis it seems that array dimension has been
fixed).
I have already spent considerable time migrating from 17.11.5 to 18.11.1
and for the time being I need to focus on diagnosing the original issue in
our system that led to discovery of invalid array dimension. I will try
again when I have some more time.
Best Regards,
Przemysław Ołtarzewski
On Wed, Apr 10, 2019 at 2:56 PM David Marchand <david.marchand@redhat.com>
wrote:
> On Wed, Apr 10, 2019 at 1:33 PM Przemysław Ołtarzewski <
> p.oltarzewski@gmail.com> wrote:
>
>> Hello David,
>>
>> I can merge these fixes and run our system using patched DPDK version.
>> Then report back any problems / improvements I observe. I can also walk
>> through source code changes and check for anything questionable.
>>
>> Unfortunately I lack deep enough understanding of DPDK source code to
>> test these fixes comprehensively and I have been short on time recently as
>> well, so that's the best I can do right now.
>>
>
> Please, be aware that other fixes have been already merged in master since
> 18.11.
> https://git.dpdk.org/dpdk/log/drivers/net/bonding
>
> I just sent the patchset that should fix your issue:
> http://patchwork.dpdk.org/project/dpdk/list/?series=4240
>
>
> --
> David Marchand
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-15 9:50 ` Przemysław Ołtarzewski
@ 2019-04-15 9:50 ` Przemysław Ołtarzewski
2019-04-18 9:38 ` Kevin Traynor
1 sibling, 0 replies; 12+ messages in thread
From: Przemysław Ołtarzewski @ 2019-04-15 9:50 UTC (permalink / raw)
To: David Marchand; +Cc: Chas Williams, dev
Hello,
Last week I attempted to migrate our system from DPDK 18.11.1 to current
master with David's patches applied. I haven't been able to make it work
correctly - probably due to other changes in master since 18.11.1 - so
unfortunately I cannot confirm that David's patchset solves the issue
(although from source code analysis it seems that array dimension has been
fixed).
I have already spent considerable time migrating from 17.11.5 to 18.11.1
and for the time being I need to focus on diagnosing the original issue in
our system that led to discovery of invalid array dimension. I will try
again when I have some more time.
Best Regards,
Przemysław Ołtarzewski
On Wed, Apr 10, 2019 at 2:56 PM David Marchand <david.marchand@redhat.com>
wrote:
> On Wed, Apr 10, 2019 at 1:33 PM Przemysław Ołtarzewski <
> p.oltarzewski@gmail.com> wrote:
>
>> Hello David,
>>
>> I can merge these fixes and run our system using patched DPDK version.
>> Then report back any problems / improvements I observe. I can also walk
>> through source code changes and check for anything questionable.
>>
>> Unfortunately I lack deep enough understanding of DPDK source code to
>> test these fixes comprehensively and I have been short on time recently as
>> well, so that's the best I can do right now.
>>
>
> Please, be aware that other fixes have been already merged in master since
> 18.11.
> https://git.dpdk.org/dpdk/log/drivers/net/bonding
>
> I just sent the patchset that should fix your issue:
> http://patchwork.dpdk.org/project/dpdk/list/?series=4240
>
>
> --
> David Marchand
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-15 9:50 ` Przemysław Ołtarzewski
2019-04-15 9:50 ` Przemysław Ołtarzewski
@ 2019-04-18 9:38 ` Kevin Traynor
2019-04-18 9:38 ` Kevin Traynor
1 sibling, 1 reply; 12+ messages in thread
From: Kevin Traynor @ 2019-04-18 9:38 UTC (permalink / raw)
To: Przemysław Ołtarzewski, David Marchand; +Cc: Chas Williams, dev
On 15/04/2019 10:50, Przemysław Ołtarzewski wrote:
> Hello,
>
> Last week I attempted to migrate our system from DPDK 18.11.1 to current
> master with David's patches applied. I haven't been able to make it work
> correctly - probably due to other changes in master since 18.11.1 - so
> unfortunately I cannot confirm that David's patchset solves the issue
> (although from source code analysis it seems that array dimension has been
> fixed).
>
> I have already spent considerable time migrating from 17.11.5 to 18.11.1
> and for the time being I need to focus on diagnosing the original issue in
> our system that led to discovery of invalid array dimension. I will try
> again when I have some more time.
>
Hi, assuming that David's patches are merged to master DPDK, then they
should be part of 18.11.2. There are also several other bonding fixes
that will be part of 18.11.2. So you could consider taking the 18.11
stable branch and applying the patches you need on top of that to test.
Kevin.
> Best Regards,
> Przemysław Ołtarzewski
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT
2019-04-18 9:38 ` Kevin Traynor
@ 2019-04-18 9:38 ` Kevin Traynor
0 siblings, 0 replies; 12+ messages in thread
From: Kevin Traynor @ 2019-04-18 9:38 UTC (permalink / raw)
To: Przemysław Ołtarzewski, David Marchand; +Cc: Chas Williams, dev
On 15/04/2019 10:50, Przemysław Ołtarzewski wrote:
> Hello,
>
> Last week I attempted to migrate our system from DPDK 18.11.1 to current
> master with David's patches applied. I haven't been able to make it work
> correctly - probably due to other changes in master since 18.11.1 - so
> unfortunately I cannot confirm that David's patchset solves the issue
> (although from source code analysis it seems that array dimension has been
> fixed).
>
> I have already spent considerable time migrating from 17.11.5 to 18.11.1
> and for the time being I need to focus on diagnosing the original issue in
> our system that led to discovery of invalid array dimension. I will try
> again when I have some more time.
>
Hi, assuming that David's patches are merged to master DPDK, then they
should be part of 18.11.2. There are also several other bonding fixes
that will be part of 18.11.2. So you could consider taking the 18.11
stable branch and applying the patches you need on top of that to test.
Kevin.
> Best Regards,
> Przemysław Ołtarzewski
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-04-18 9:38 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 14:44 [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT bugzilla
2019-04-09 14:44 ` bugzilla
2019-04-09 14:51 ` David Marchand
2019-04-09 14:51 ` David Marchand
2019-04-10 11:39 ` Przemysław Ołtarzewski
2019-04-10 11:39 ` Przemysław Ołtarzewski
2019-04-10 12:56 ` David Marchand
2019-04-10 12:56 ` David Marchand
2019-04-15 9:50 ` Przemysław Ołtarzewski
2019-04-15 9:50 ` Przemysław Ołtarzewski
2019-04-18 9:38 ` Kevin Traynor
2019-04-18 9:38 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).