From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 872184F93 for ; Tue, 9 Apr 2019 16:55:39 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 07:55:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="138826211" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga008.fm.intel.com with SMTP; 09 Apr 2019 07:55:33 -0700 Received: by (sSMTP sendmail emulation); Tue, 09 Apr 2019 15:55:33 +0100 Date: Tue, 9 Apr 2019 15:55:32 +0100 From: Bruce Richardson To: Ayuj Verma Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, arkadiuszx.kusztal@intel.com, pablo.de.lara.guarch@intel.com, shallyv@marvell.com, ssahu@marvell.com, kkotamarthy@marvell.com, adesai@marvell.com, dev@dpdk.org Message-ID: <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1554809619-21164-2-git-send-email-ayverma@marvell.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 14:55:40 -0000 On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote: > Return -ENOTSUP for unsupported tests > I disagree with this, since TEST_SKIPPED is the correct return value for unsupported test conditions IMHO. If part of the current infrastructure doesn't support that return value, I think the infrastructure should be updated. Ref: http://mesonbuild.com/Unit-tests.html#skipped-tests-and-hard-errors /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 00D26A0096 for ; Tue, 9 Apr 2019 16:55:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DAF04F9A; Tue, 9 Apr 2019 16:55:41 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 872184F93 for ; Tue, 9 Apr 2019 16:55:39 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2019 07:55:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,329,1549958400"; d="scan'208";a="138826211" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga008.fm.intel.com with SMTP; 09 Apr 2019 07:55:33 -0700 Received: by (sSMTP sendmail emulation); Tue, 09 Apr 2019 15:55:33 +0100 Date: Tue, 9 Apr 2019 15:55:32 +0100 From: Bruce Richardson To: Ayuj Verma Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, arkadiuszx.kusztal@intel.com, pablo.de.lara.guarch@intel.com, shallyv@marvell.com, ssahu@marvell.com, kkotamarthy@marvell.com, adesai@marvell.com, dev@dpdk.org Message-ID: <20190409145532.GA693@bricha3-MOBL.ger.corp.intel.com> References: <1554809619-21164-1-git-send-email-ayverma@marvell.com> <1554809619-21164-2-git-send-email-ayverma@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <1554809619-21164-2-git-send-email-ayverma@marvell.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409145532.TbNM_S8jgzAffJeRmnaFLPgAk_H_y6-63svzu5ancFs@z> On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote: > Return -ENOTSUP for unsupported tests > I disagree with this, since TEST_SKIPPED is the correct return value for unsupported test conditions IMHO. If part of the current infrastructure doesn't support that return value, I think the infrastructure should be updated. Ref: http://mesonbuild.com/Unit-tests.html#skipped-tests-and-hard-errors /Bruce