DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: qiming.yang@intel.com, wenzhuo.lu@intel.com,
	ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com
Cc: ferruh.yigit@intel.com, dev@dpdk.org
Subject: [dpdk-dev] [PATCH 0/2] fix big endian build
Date: Tue,  9 Apr 2019 21:49:02 +0200	[thread overview]
Message-ID: <20190409194904.6822-1-thomas@monjalon.net> (raw)
Message-ID: <20190409194902.rfsTuOLL6VO5BkbrZ3SK1PFRh5VCbZOCO8jH4fA1zco@z> (raw)

There are at least 4 issues when compiling with a big endian toolchain.
2 of them are fixed in this patchset.
The remaining ones are in ice and bnxt PMDs.

About ice, the error is:
    drivers/net/ice/base/ice_flex_pipe.c:302:8: error:
    ‘state.entry_idx’ may be used uninitialized in this function
It is not obvious to fix, there may be few places where
a struct should be initialized. Please fix it soon.

About bnxt, the issue looks like a mistake reproduced several times:
    drivers/net/bnxt/bnxt_ethdev.c:2652:19: error:
    invalid use of void expression
    rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off));
The pattern "rte_cpu_to_le_32(rte_write32(" can be seen 4 times.
The result of the endian conversion is never used.
Please fix it soon.


Thomas Monjalon (2):
  mbuf: fix big endian build
  net/enetc: fix big endian build

 drivers/net/enetc/enetc_rxtx.c | 5 +++--
 lib/librte_mbuf/rte_mbuf.h     | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.21.0


             reply	other threads:[~2019-04-09 19:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 19:49 Thomas Monjalon [this message]
2019-04-09 19:49 ` Thomas Monjalon
2019-04-09 19:49 ` [dpdk-dev] [PATCH 1/2] mbuf: " Thomas Monjalon
2019-04-09 19:49   ` Thomas Monjalon
2019-04-09 19:49 ` [dpdk-dev] [PATCH 2/2] net/enetc: " Thomas Monjalon
2019-04-09 19:49   ` Thomas Monjalon
2019-04-09 20:06 ` [dpdk-dev] [PATCH v2 0/2] " Thomas Monjalon
2019-04-09 20:06   ` Thomas Monjalon
2019-04-09 20:06   ` [dpdk-dev] [PATCH v2 1/2] mbuf: " Thomas Monjalon
2019-04-09 20:06     ` Thomas Monjalon
2019-04-09 22:55     ` Ananyev, Konstantin
2019-04-09 22:55       ` Ananyev, Konstantin
2019-04-22 13:28       ` Thomas Monjalon
2019-04-22 13:28         ` Thomas Monjalon
2019-04-09 20:06   ` [dpdk-dev] [PATCH v2 2/2] net/enetc: " Thomas Monjalon
2019-04-09 20:06     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190409194904.6822-1-thomas@monjalon.net \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).