From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 038065688 for ; Tue, 9 Apr 2019 21:49:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8F3362F0; Tue, 9 Apr 2019 15:49:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Apr 2019 15:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=7BnPGYQAa27AAZU+m+eOqbu SeI4BW1dHv9X6AfzrqZw=; b=Bmy6W0gCjvmtgKjctMak0gLyVd6yEvTxLUHH4Bf x7Jfi89XG7lLu2bAuaHOIKpVdTU5kHAnEi91GAEkcfYiKDfRnwnyNUo3zKxfchrT z+1/+GfRtRnwauEetbo1C3dqpCA3Gw0khpu+iZ/J5F2MuXEQbik0jp2IPIu/b8Jw 2Oq0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7BnPGY QAa27AAZU+m+eOqbuSeI4BW1dHv9X6AfzrqZw=; b=PbLfrNpCzHpqyBGNvPZ1tY 701z8HUyo9WqB/s44HdjZA+170Pbp4p7pyMuKDX+cF9lRYmfEit+V9BSJiJ5YnFp LZdtHKUbSoChp/V0ksQPJ7834Ge297HaETB0t10JoW33FRepunGHJndELm34bsZa Cz4b0gTm2/ItsUs0lc0KD571tabs1zChPZo23WYkqSCYCWmrvWE6/rvA/9D51bh7 PazuNu++HM4I51udaJRzeRQw1DKqLX44gPNR1VfMmVgZzDkCH/RpWlOeoan+zBkE pcX6xwonIN3wKKcpgZvwF/t8dOhMFDzEXR3fP+wqI37iLukz0LfU7hmFe7hhqXOQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 691D2E4664; Tue, 9 Apr 2019 15:49:12 -0400 (EDT) From: Thomas Monjalon To: qiming.yang@intel.com, wenzhuo.lu@intel.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com Cc: ferruh.yigit@intel.com, dev@dpdk.org Date: Tue, 9 Apr 2019 21:49:02 +0200 Message-Id: <20190409194904.6822-1-thomas@monjalon.net> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/2] fix big endian build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 19:49:16 -0000 There are at least 4 issues when compiling with a big endian toolchain. 2 of them are fixed in this patchset. The remaining ones are in ice and bnxt PMDs. About ice, the error is: drivers/net/ice/base/ice_flex_pipe.c:302:8: error: ‘state.entry_idx’ may be used uninitialized in this function It is not obvious to fix, there may be few places where a struct should be initialized. Please fix it soon. About bnxt, the issue looks like a mistake reproduced several times: drivers/net/bnxt/bnxt_ethdev.c:2652:19: error: invalid use of void expression rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off)); The pattern "rte_cpu_to_le_32(rte_write32(" can be seen 4 times. The result of the endian conversion is never used. Please fix it soon. Thomas Monjalon (2): mbuf: fix big endian build net/enetc: fix big endian build drivers/net/enetc/enetc_rxtx.c | 5 +++-- lib/librte_mbuf/rte_mbuf.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A400FA0096 for ; Tue, 9 Apr 2019 21:49:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4AB2C568A; Tue, 9 Apr 2019 21:49:17 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 038065688 for ; Tue, 9 Apr 2019 21:49:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8F3362F0; Tue, 9 Apr 2019 15:49:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Apr 2019 15:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=7BnPGYQAa27AAZU+m+eOqbu SeI4BW1dHv9X6AfzrqZw=; b=Bmy6W0gCjvmtgKjctMak0gLyVd6yEvTxLUHH4Bf x7Jfi89XG7lLu2bAuaHOIKpVdTU5kHAnEi91GAEkcfYiKDfRnwnyNUo3zKxfchrT z+1/+GfRtRnwauEetbo1C3dqpCA3Gw0khpu+iZ/J5F2MuXEQbik0jp2IPIu/b8Jw 2Oq0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=7BnPGY QAa27AAZU+m+eOqbuSeI4BW1dHv9X6AfzrqZw=; b=PbLfrNpCzHpqyBGNvPZ1tY 701z8HUyo9WqB/s44HdjZA+170Pbp4p7pyMuKDX+cF9lRYmfEit+V9BSJiJ5YnFp LZdtHKUbSoChp/V0ksQPJ7834Ge297HaETB0t10JoW33FRepunGHJndELm34bsZa Cz4b0gTm2/ItsUs0lc0KD571tabs1zChPZo23WYkqSCYCWmrvWE6/rvA/9D51bh7 PazuNu++HM4I51udaJRzeRQw1DKqLX44gPNR1VfMmVgZzDkCH/RpWlOeoan+zBkE pcX6xwonIN3wKKcpgZvwF/t8dOhMFDzEXR3fP+wqI37iLukz0LfU7hmFe7hhqXOQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofggtgfgsehtkeertd ertdejnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 691D2E4664; Tue, 9 Apr 2019 15:49:12 -0400 (EDT) From: Thomas Monjalon To: qiming.yang@intel.com, wenzhuo.lu@intel.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com Cc: ferruh.yigit@intel.com, dev@dpdk.org Date: Tue, 9 Apr 2019 21:49:02 +0200 Message-Id: <20190409194904.6822-1-thomas@monjalon.net> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 0/2] fix big endian build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409194902.rfsTuOLL6VO5BkbrZ3SK1PFRh5VCbZOCO8jH4fA1zco@z> There are at least 4 issues when compiling with a big endian toolchain. 2 of them are fixed in this patchset. The remaining ones are in ice and bnxt PMDs. About ice, the error is: drivers/net/ice/base/ice_flex_pipe.c:302:8: error: ‘state.entry_idx’ may be used uninitialized in this function It is not obvious to fix, there may be few places where a struct should be initialized. Please fix it soon. About bnxt, the issue looks like a mistake reproduced several times: drivers/net/bnxt/bnxt_ethdev.c:2652:19: error: invalid use of void expression rte_cpu_to_le_32(rte_write32(reg_base, (uint8_t *)bp->bar0 + win_off)); The pattern "rte_cpu_to_le_32(rte_write32(" can be seen 4 times. The result of the endian conversion is never used. Please fix it soon. Thomas Monjalon (2): mbuf: fix big endian build net/enetc: fix big endian build drivers/net/enetc/enetc_rxtx.c | 5 +++-- lib/librte_mbuf/rte_mbuf.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.21.0