From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: vivkong@ca.ibm.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC 10/12] ethdev: add cast for bus_device
Date: Tue, 9 Apr 2019 19:41:43 -0700 [thread overview]
Message-ID: <20190409194143.1cbee518@shemminger-XPS-13-9360> (raw)
Message-ID: <20190410024143.xX9TVgBvRhGyZiB3FmQ7BFB6DkBM2RNOqe31FbZz6FM@z> (raw)
In-Reply-To: <3802339.Lkezi3CoX2@xps>
On Tue, 09 Apr 2019 22:14:08 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> 09/04/2019 21:06, Vivian Kong:
> > Signed-off-by: Vivian Kong <vivkong@ca.ibm.com>
> > ---
> > static inline int
> > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device) {
> > - struct rte_pci_device *pci_dev = bus_device;
> > + struct rte_pci_device *pci_dev = (struct rte_pci_device *) bus_device;
>
> Why do we need such cast?
>
>
I agree with Thomas, we try to avoid extra casts and there is even
a script to find them.
next prev parent reply other threads:[~2019-04-10 2:41 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 19:06 [dpdk-dev] [RFC 00/12] introduce s390x architecture Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 01/12] mk: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:38 ` Luca Boccassi
2019-04-09 19:38 ` Luca Boccassi
2019-04-10 16:50 ` Vivian Kong
2019-04-10 16:50 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 02/12] eal: add support for " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 03/12] acl: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 04/12] lpm: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 05/12] examples/l3fwd: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 06/12] net/i40e: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 07/12] test: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 08/12] hash: " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-15 20:43 ` Dharmik Thakkar
2019-04-15 20:43 ` Dharmik Thakkar
2019-04-09 19:06 ` [dpdk-dev] [RFC 09/12] doc: introduce " Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:12 ` Thomas Monjalon
2019-04-09 20:12 ` Thomas Monjalon
2019-04-10 16:52 ` Vivian Kong
2019-04-10 16:52 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 10/12] ethdev: add cast for bus_device Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:14 ` Thomas Monjalon
2019-04-09 20:14 ` Thomas Monjalon
2019-04-10 2:41 ` Stephen Hemminger [this message]
2019-04-10 2:41 ` Stephen Hemminger
2019-04-10 17:10 ` Vivian Kong
2019-04-10 17:10 ` Vivian Kong
2019-04-09 19:06 ` [dpdk-dev] [RFC 11/12] mbuf: trivial fix Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:13 ` Thomas Monjalon
2019-04-09 20:13 ` Thomas Monjalon
2019-04-09 19:06 ` [dpdk-dev] [RFC 12/12] test: miscellaneous test fixes Vivian Kong
2019-04-09 19:06 ` Vivian Kong
2019-04-09 20:25 ` [dpdk-dev] [RFC 00/12] introduce s390x architecture Thomas Monjalon
2019-04-09 20:25 ` Thomas Monjalon
2019-04-10 17:09 ` Vivian Kong
2019-04-10 17:09 ` Vivian Kong
2019-04-10 17:43 ` Thomas Monjalon
2019-04-10 17:43 ` Thomas Monjalon
2019-04-10 19:15 ` Vivian Kong
2019-04-10 19:15 ` Vivian Kong
2019-04-10 19:46 ` Thomas Monjalon
2019-04-10 19:46 ` Thomas Monjalon
2019-04-10 20:45 ` Vivian Kong
2019-04-10 20:45 ` Vivian Kong
2019-04-10 20:31 ` David Christensen
2019-04-10 20:31 ` David Christensen
2019-04-10 20:46 ` Thomas Monjalon
2019-04-10 20:46 ` Thomas Monjalon
2019-04-10 21:03 ` David Christensen
2019-04-10 21:03 ` David Christensen
2019-04-10 21:45 ` Pradeep Satyanarayana
2019-04-10 21:45 ` Pradeep Satyanarayana
2019-04-11 6:59 ` Thomas Monjalon
2019-04-11 6:59 ` Thomas Monjalon
2019-04-11 15:57 ` Pradeep Satyanarayana
2019-04-11 15:57 ` Pradeep Satyanarayana
[not found] ` <OFB9049735.7E51096E-ON882583D9.00574783-882583D9.00579FE2@LocalDomain>
2019-04-18 21:06 ` Pradeep Satyanarayana
2019-04-18 21:06 ` Pradeep Satyanarayana
2019-04-18 21:18 ` Thomas Monjalon
2019-04-18 21:18 ` Thomas Monjalon
2019-04-11 7:45 ` David Marchand
2019-04-11 7:45 ` David Marchand
2019-05-15 12:45 ` David Marchand
2019-05-15 12:45 ` David Marchand
2020-02-18 21:03 ` Thomas Monjalon
2020-02-20 0:20 ` Pradeep Satyanarayana
2020-02-21 13:33 ` Vivian Kong
2021-03-24 21:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409194143.1cbee518@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=vivkong@ca.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).