From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Hunt, David" <david.hunt@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues
Date: Wed, 10 Apr 2019 08:52:02 +0100 [thread overview]
Message-ID: <e4c7fdb2-7d04-3405-b423-9b321324c8d8@intel.com> (raw)
Message-ID: <20190410075202.0_yJB24hMtx0yp7MixFv8QWscSJAw2yhWQu_lIJ2uZI@z> (raw)
In-Reply-To: <e66d0bcc-1188-97da-1618-8eec0cc1c102@intel.com>
On 4/9/2019 3:40 PM, Hunt, David wrote:
>
> On 9/4/2019 12:18 PM, Burakov, Anatoly wrote:
>> On 09-Apr-19 10:22 AM, David Hunt wrote:
>>> A previous change removed the limit of 64 cores by
>>> moving away from 64-bit masks to char arrays. However
>>> this left a buffer overrun issue, where the max channels
>>> was defined as 64, and max cores was defined as 256. These
>>> should all be consistently set to RTE_MAX_LCORE.
>>>
>>> The #defines being removed are CHANNEL_CMDS_MAX_CPUS,
>>> CHANNEL_CMDS_MAX_CHANNELS, POWER_MGR_MAX_CPUS, and
>>> CHANNEL_CMDS_MAX_VM_CHANNELS, and are being replaced
>>> with RTE_MAX_LCORE for consistency and simplicity.
>>>
>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
>>> Coverity issue: 337672
>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
>>> Coverity issue: 337673
>>> Fixes: fd73630e95c1 ("examples/power: change 64-bit masks to arrays")
>>> Coverity issue: 337678
>>
>> No need to mention the same commit three times :)
>>
>
> The coverity output said to add this, so I was leaving nothing to
> chance... :)
Can use comma separated list for multiple issues fixed, like:
Coverity issue: 277209, 277215, 277225
Fixes: c7e9729da6b5 ("net/nfp: support CPP")
Cc: stable@dpdk.org
next prev parent reply other threads:[~2019-04-10 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 9:22 David Hunt
2019-04-09 9:22 ` David Hunt
2019-04-09 11:18 ` Burakov, Anatoly
2019-04-09 11:18 ` Burakov, Anatoly
2019-04-09 14:40 ` Hunt, David
2019-04-09 14:40 ` Hunt, David
2019-04-10 7:52 ` Ferruh Yigit [this message]
2019-04-10 7:52 ` Ferruh Yigit
2019-04-10 10:55 ` Burakov, Anatoly
2019-04-10 10:55 ` Burakov, Anatoly
2019-04-10 14:17 ` Ferruh Yigit
2019-04-10 14:17 ` Ferruh Yigit
2019-04-22 20:55 ` Thomas Monjalon
2019-04-22 20:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4c7fdb2-7d04-3405-b423-9b321324c8d8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).