From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: chas3@att.com, p.oltarzewski@gmail.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 3/4] net/bonding: fix unicast packets filtering when not in promisc
Date: Wed, 10 Apr 2019 14:53:48 +0200 [thread overview]
Message-ID: <1554900829-16180-4-git-send-email-david.marchand@redhat.com> (raw)
Message-ID: <20190410125348.ba6tOrg8xx9o8QklaGmrNGMUnaobJqyXpmMLHhVcZhY@z> (raw)
In-Reply-To: <1554900829-16180-1-git-send-email-david.marchand@redhat.com>
By default, the 802.3ad code enables promisc mode on all slaves.
To avoid all packets going to the application (unless the application
asked for promiscuous mode), all frames are supposed to be filtered in
the rx burst handler.
However the incriminated commit broke this because non pure ethernet
frames (basically any unicast Ether()/IP() packet) are not filtered
anymore.
Fixes: 71b7b37ec959 ("net/bonding: use ptype flags for LACP Rx filtering")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 989be5c..9ef0717 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -305,13 +305,6 @@
/* Handle slow protocol packets. */
while (j < num_rx_total) {
-
- /* If packet is not pure L2 and is known, skip it */
- if ((bufs[j]->packet_type & ~RTE_PTYPE_L2_ETHER) != 0) {
- j++;
- continue;
- }
-
if (j + 3 < num_rx_total)
rte_prefetch0(rte_pktmbuf_mtod(bufs[j + 3], void *));
--
1.8.3.1
next prev parent reply other threads:[~2019-04-10 12:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 12:53 [dpdk-dev] [PATCH 0/4] lacp rx/tx handlers fixes for bonding pmd David Marchand
2019-04-10 12:53 ` David Marchand
2019-04-10 12:53 ` [dpdk-dev] [PATCH 1/4] net/bonding: fix oob access in LACP mode when sending many packets David Marchand
2019-04-10 12:53 ` David Marchand
2019-04-10 12:53 ` [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler David Marchand
2019-04-10 12:53 ` David Marchand
2019-04-12 14:01 ` Chas Williams
2019-04-12 14:01 ` Chas Williams
2019-04-18 7:11 ` David Marchand
2019-04-18 7:11 ` David Marchand
2019-04-18 22:50 ` Chas Williams
2019-04-18 22:50 ` Chas Williams
2019-05-16 9:12 ` David Marchand
2019-05-16 9:12 ` David Marchand
2019-07-02 15:01 ` Ferruh Yigit
2019-08-14 1:43 ` Chas Williams
2019-08-19 9:41 ` David Marchand
2019-04-10 12:53 ` David Marchand [this message]
2019-04-10 12:53 ` [dpdk-dev] [PATCH 3/4] net/bonding: fix unicast packets filtering when not in promisc David Marchand
2019-04-10 12:53 ` [dpdk-dev] [PATCH 4/4] net/bonding: prefer allmulti to promisc for LACP David Marchand
2019-04-10 12:53 ` David Marchand
2019-06-27 8:08 ` [dpdk-dev] [PATCH 0/4] lacp rx/tx handlers fixes for bonding pmd Ferruh Yigit
2019-06-27 12:07 ` WILLIAMS, CHARLES J
2019-06-27 12:19 ` Chas Williams
2019-08-22 16:48 ` Yigit, Ferruh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554900829-16180-4-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=p.oltarzewski@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).