From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9199169D4 for ; Wed, 10 Apr 2019 15:46:55 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 06:46:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="335523253" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga006.fm.intel.com with SMTP; 10 Apr 2019 06:46:52 -0700 Received: by (sSMTP sendmail emulation); Wed, 10 Apr 2019 14:46:51 +0100 Date: Wed, 10 Apr 2019 14:46:51 +0100 From: Bruce Richardson To: Aaron Conole Cc: "Ananyev, Konstantin" , "dev@dpdk.org" , Jerin Jacob , Gavin Hu , Michael Santana Message-ID: <20190410134651.GC718@bricha3-MOBL.ger.corp.intel.com> References: <20190408182420.4398-1-aconole@redhat.com> <20190408182420.4398-4-aconole@redhat.com> <2601191342CEEE43887BDE71AB9772580148A94A44@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772580148A94D87@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772580148A94DA8@irsmsx105.ger.corp.intel.com> <20190410132456.GB718@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190410132456.GB718@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 13:46:56 -0000 On Wed, Apr 10, 2019 at 02:24:56PM +0100, Bruce Richardson wrote: > On Wed, Apr 10, 2019 at 09:10:25AM -0400, Aaron Conole wrote: > > > > Okay - I'll look at this part more. I think I went down the path of > > explicitly setting these because the comments didn't match with what was > > occuring (for example, in the section that I changed that loops through > > all versions, only the AVX2 and Scalar were being tested on my system, > > while the comment implied SSE). > > > > I also believe that I split out the functions because of the linking > > issue (I guess the way the linker resolves the functions works properly > > when the weak versions are in a different translation unit)? I'll spend > > some time trying to get it working in a different way. > > > > Regardless, this wasn't ready for posting as 'PATCH' - I meant it as > > RFC. I don't intend to change the first two patches, though. > > > > And thank you for the all the feedback! > > > I've dug into this a bit, and I'm doing up a patch to remove the use of > weak symbols in our libraries (note, just libs, not drivers) entirely. > That's fairly easy to do, and not a big change, but should make this > problem go away. > > /Bruce Ref: http://patches.dpdk.org/project/dpdk/list/?series=4242 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 40C97A0096 for ; Wed, 10 Apr 2019 15:46:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13BC47CCA; Wed, 10 Apr 2019 15:46:58 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9199169D4 for ; Wed, 10 Apr 2019 15:46:55 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 06:46:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="335523253" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.35]) by fmsmga006.fm.intel.com with SMTP; 10 Apr 2019 06:46:52 -0700 Received: by (sSMTP sendmail emulation); Wed, 10 Apr 2019 14:46:51 +0100 Date: Wed, 10 Apr 2019 14:46:51 +0100 From: Bruce Richardson To: Aaron Conole Cc: "Ananyev, Konstantin" , "dev@dpdk.org" , Jerin Jacob , Gavin Hu , Michael Santana Message-ID: <20190410134651.GC718@bricha3-MOBL.ger.corp.intel.com> References: <20190408182420.4398-1-aconole@redhat.com> <20190408182420.4398-4-aconole@redhat.com> <2601191342CEEE43887BDE71AB9772580148A94A44@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772580148A94D87@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772580148A94DA8@irsmsx105.ger.corp.intel.com> <20190410132456.GB718@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190410132456.GB718@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410134651.GV8V0CI4tUOTNrdCwKMQ_o9r8eXvQRFJ2mNvJ3QT2TY@z> On Wed, Apr 10, 2019 at 02:24:56PM +0100, Bruce Richardson wrote: > On Wed, Apr 10, 2019 at 09:10:25AM -0400, Aaron Conole wrote: > > > > Okay - I'll look at this part more. I think I went down the path of > > explicitly setting these because the comments didn't match with what was > > occuring (for example, in the section that I changed that loops through > > all versions, only the AVX2 and Scalar were being tested on my system, > > while the comment implied SSE). > > > > I also believe that I split out the functions because of the linking > > issue (I guess the way the linker resolves the functions works properly > > when the weak versions are in a different translation unit)? I'll spend > > some time trying to get it working in a different way. > > > > Regardless, this wasn't ready for posting as 'PATCH' - I meant it as > > RFC. I don't intend to change the first two patches, though. > > > > And thank you for the all the feedback! > > > I've dug into this a bit, and I'm doing up a patch to remove the use of > weak symbols in our libraries (note, just libs, not drivers) entirely. > That's fairly easy to do, and not a big change, but should make this > problem go away. > > /Bruce Ref: http://patches.dpdk.org/project/dpdk/list/?series=4242