From: David Christensen <drc@linux.vnet.ibm.com>
To: konstantin.ananyev@intel.com
Cc: dev@dpdk.org, radhika.chirra@ibm.com,
David Christensen <drc@linux.vnet.ibm.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH] bpf: rename bpf_validate() to rte_bpf_validate() to avoid collisions
Date: Wed, 10 Apr 2019 14:23:31 -0500 [thread overview]
Message-ID: <1554924211-11946-1-git-send-email-drc@linux.vnet.ibm.com> (raw)
Message-ID: <20190410192331.mnCD0Dzk30DfoC_2Jdbaw7kUKUFxt5fYgnpsAN5Cn3Q@z> (raw)
When using libpcap libraries the error "multiple definition of
'bpf_validate'" is observed. Rename the DPDK version to rte_bpf_validate
to be more consistenet with other DPDK defined functions.
Cc: stable@dpdk.org
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Tested-by: Radhika Chirra <radhika.chirra@ibm.com>
---
lib/librte_bpf/bpf_impl.h | 2 +-
lib/librte_bpf/bpf_load.c | 2 +-
lib/librte_bpf/bpf_validate.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_bpf/bpf_impl.h b/lib/librte_bpf/bpf_impl.h
index b577e2c..f1d6f9a 100644
--- a/lib/librte_bpf/bpf_impl.h
+++ b/lib/librte_bpf/bpf_impl.h
@@ -21,7 +21,7 @@ struct rte_bpf {
uint32_t stack_sz;
};
-extern int bpf_validate(struct rte_bpf *bpf);
+extern int rte_bpf_validate(struct rte_bpf *bpf);
extern int bpf_jit(struct rte_bpf *bpf);
diff --git a/lib/librte_bpf/bpf_load.c b/lib/librte_bpf/bpf_load.c
index d9d163b..bd9eebf 100644
--- a/lib/librte_bpf/bpf_load.c
+++ b/lib/librte_bpf/bpf_load.c
@@ -115,7 +115,7 @@
return NULL;
}
- rc = bpf_validate(bpf);
+ rc = rte_bpf_validate(bpf);
if (rc == 0) {
bpf_jit(bpf);
if (mprotect(bpf, bpf->sz, PROT_READ) != 0)
diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c
index 83983ef..12c34f0 100644
--- a/lib/librte_bpf/bpf_validate.c
+++ b/lib/librte_bpf/bpf_validate.c
@@ -2209,7 +2209,7 @@ struct bpf_ins_check {
}
int
-bpf_validate(struct rte_bpf *bpf)
+rte_bpf_validate(struct rte_bpf *bpf)
{
int32_t rc;
struct bpf_verifier bvf;
--
1.8.3.1
next reply other threads:[~2019-04-10 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 19:23 David Christensen [this message]
2019-04-10 19:23 ` David Christensen
2019-04-10 21:43 ` Ananyev, Konstantin
2019-04-10 21:43 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554924211-11946-1-git-send-email-drc@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=radhika.chirra@ibm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).