DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] meter: replace color definitions with rte_color values
Date: Wed, 10 Apr 2019 23:19:43 +0200	[thread overview]
Message-ID: <2927364.25GnhlBk6h@xps> (raw)
Message-ID: <20190410211943.OvvfTwP13gmiXy__tYXWwr5-VFv9hff6IMdRDX-uYMo@z> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E871CE0@IRSMSX108.ger.corp.intel.com>

> > This patch implements the changes proposed in the deprecation
> > note[1]. Replace multiple color definitions in various places such as
> > rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined
> > in rte_meter.h.
> > 
> > This is simple search and replace exercise without any implementation
> > change.
> > 
> > [1] https://mails.dpdk.org/archives/dev/2019-January/123861.html
> > 
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

There is a compilation failure:

examples/qos_sched/cfg_file.c:67:20: error:
use of undeclared identifier 'e_RTE_METER_COLORS'
         for (k = 0; k < e_RTE_METER_COLORS; k++) {





  parent reply	other threads:[~2019-04-10 21:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 15:44 [dpdk-dev] [PATCH] " Jasvinder Singh
2019-03-27 15:44 ` Jasvinder Singh
2019-04-05 12:00 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
2019-04-05 12:00   ` Jasvinder Singh
2019-04-05 13:54   ` [dpdk-dev] [PATCH v3] " Jasvinder Singh
2019-04-05 13:54     ` Jasvinder Singh
2019-04-05 13:57     ` Dumitrescu, Cristian
2019-04-05 13:57       ` Dumitrescu, Cristian
2019-04-10 21:19       ` Thomas Monjalon [this message]
2019-04-10 21:19         ` Thomas Monjalon
2019-04-11  9:16         ` Singh, Jasvinder
2019-04-11  9:16           ` Singh, Jasvinder
2019-04-11  9:15     ` [dpdk-dev] [PATCH v4] " Jasvinder Singh
2019-04-11  9:15       ` Jasvinder Singh
2019-04-11 15:26       ` Thomas Monjalon
2019-04-11 15:26         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2927364.25GnhlBk6h@xps \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).