Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

[David Marchand <david.marchand@redhat.com>]

Hello,

On Tue, Apr 9, 2019 at 9:06 PM Vivian Kong <vivkong@gmail.com> wrote:

> To build and run DPDK on Linux on IBM Z (s390x), big endian support
> is added and s390x vector intrinics are used in the implementation
>

intrinsics*

of DPDK libraries.
>
> I appreciate your feedback.
>

Quick check since this is not 19.05 material.

- New files should be Copyright 2019.
- Avoid copy/paste from Power, noticed a reference to Power in the config
file.
- Configuration files are stacked, only enable/disable the needed parts in
the specific s390 file
- Meson must be added.
- No need to add dead code, remove the commented code like:
  //#define dsb(opt) asm volatile("" : : : "memory")
- Comments using // are banned.
- No need to introduce a RTE_ACL_CLASSIFY_S390X to map to the scalar code.
  Just avoid the SSE code to be selected in the build framework (iiuc).
- Avoid introducing empty lines


Run check scripts from devtools before submitting:

[dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh

### mk: introduce s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 61 lines checked

### eal: add support for s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 601 lines checked

### acl: add support for s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 208 lines checked

### lpm: add support for s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 203 lines checked

### examples/l3fwd: add support for s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 410 lines checked

### net/i40e: add support for s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 0 checks, 647 lines checked

### test: add support for s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 192 lines checked

### hash: add support for s390x architecture

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 16 lines checked

### doc: introduce s390x architecture

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 2 warnings, 24 lines checked

### ethdev: add cast for bus_device

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 2 warnings, 8 lines checked

### mbuf: trivial fix

WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 2 warnings, 8 lines checked

### test: miscellaneous test fixes

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch
author 'Vivian Kong <vivkong@gmail.com>'

total: 0 errors, 1 warnings, 32 lines checked

0/12 valid patch



-- 
David Marchand